linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt()
@ 2021-07-08  5:13 Nobuhiro Iwamatsu
  2021-07-08  7:02 ` Krzysztof Kozlowski
  2021-07-10  0:42 ` Alexandre Belloni
  0 siblings, 2 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2021-07-08  5:13 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni
  Cc: linux-rtc, Nobuhiro Iwamatsu, Krzysztof Kozlowski,
	Bartlomiej Zolnierkiewicz, linux-samsung-soc

s5m_check_peding_alarm_interrupt() in s5m_rtc_read_alarm() gets the return
value, but doesn't use it.
This modifies using the s5m_check_peding_alarm_interrupt()"s return value
as the s5m_rtc_read_alarm()'s return value.

Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
---
 drivers/rtc/rtc-s5m.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index 038269a6b08c55..6b56f8eacba6fa 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -488,9 +488,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 	dev_dbg(dev, "%s: %ptR(%d)\n", __func__, &alrm->time, alrm->time.tm_wday);
 
-	ret = s5m_check_peding_alarm_interrupt(info, alrm);
-
-	return 0;
+	return s5m_check_peding_alarm_interrupt(info, alrm);
 }
 
 static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info)
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt()
  2021-07-08  5:13 [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt() Nobuhiro Iwamatsu
@ 2021-07-08  7:02 ` Krzysztof Kozlowski
  2021-07-10  0:42 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-08  7:02 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu, Alessandro Zummo, Alexandre Belloni
  Cc: linux-rtc, Bartlomiej Zolnierkiewicz, linux-samsung-soc

On 08/07/2021 07:13, Nobuhiro Iwamatsu wrote:
> s5m_check_peding_alarm_interrupt() in s5m_rtc_read_alarm() gets the return
> value, but doesn't use it.
> This modifies using the s5m_check_peding_alarm_interrupt()"s return value

Avoid "This ..." type of sentences and use simple imperative:
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89

> as the s5m_rtc_read_alarm()'s return value.
> 
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  drivers/rtc/rtc-s5m.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt()
  2021-07-08  5:13 [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt() Nobuhiro Iwamatsu
  2021-07-08  7:02 ` Krzysztof Kozlowski
@ 2021-07-10  0:42 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2021-07-10  0:42 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu, Alessandro Zummo
  Cc: Alexandre Belloni, linux-samsung-soc, linux-rtc,
	Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz

On Thu, 8 Jul 2021 14:13:04 +0900, Nobuhiro Iwamatsu wrote:
> s5m_check_peding_alarm_interrupt() in s5m_rtc_read_alarm() gets the return
> value, but doesn't use it.
> This modifies using the s5m_check_peding_alarm_interrupt()"s return value
> as the s5m_rtc_read_alarm()'s return value.

Applied, thanks!

[1/1] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt()
      commit: f2581b1dfa9858e342afa8034b0f64f923bbf233

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-10  0:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08  5:13 [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt() Nobuhiro Iwamatsu
2021-07-08  7:02 ` Krzysztof Kozlowski
2021-07-10  0:42 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox