From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Jackie Liu <liu.yun@linux.dev>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, liuyun01@kylinos.cn
Subject: Re: [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()
Date: Wed, 15 Sep 2021 09:50:59 +0200 [thread overview]
Message-ID: <163169222223.16372.4373393862023075266.b4-ty@canonical.com> (raw)
In-Reply-To: <20210901123557.1043953-1-liu.yun@linux.dev>
On Wed, 1 Sep 2021 20:35:57 +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> The s3c24xx_init_intc() returns an error pointer upon failure, not NULL.
> let's add an error pointer check in s3c24xx_handle_irq.
>
> s3c_intc[0] is not NULL or ERR, we can simplify the code.
>
> [...]
Applied, thanks!
[1/1] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()
commit: 2aa717473ce96c93ae43a5dc8c23cedc8ce7dd9f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
next prev parent reply other threads:[~2021-09-15 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:35 [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc() Jackie Liu
2021-09-06 10:23 ` Jackie Liu
2021-09-06 10:52 ` Krzysztof Kozlowski
2021-09-15 7:50 ` Krzysztof Kozlowski [this message]
2021-10-26 15:10 ` Arnd Bergmann
2021-10-26 15:22 ` Krzysztof Kozlowski
2021-10-26 15:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163169222223.16372.4373393862023075266.b4-ty@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liu.yun@linux.dev \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).