linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433
@ 2021-08-20  8:14 Krzysztof Kozlowski
  2021-08-20  8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-20  8:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

Align the name of operating-points node to dtschema to fix warnings like:

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 10 +++++-----
 arch/arm64/boot/dts/exynos/exynos5433.dtsi     |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
index 8997f8f2b96c..72ccf18eb9d1 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
@@ -87,7 +87,7 @@ bus_noc2: bus9 {
 		status = "disabled";
 	};
 
-	bus_g2d_400_opp_table: opp-table2 {
+	bus_g2d_400_opp_table: opp-table-2 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -117,7 +117,7 @@ opp-100000000 {
 		};
 	};
 
-	bus_g2d_266_opp_table: opp-table3 {
+	bus_g2d_266_opp_table: opp-table-3 {
 		compatible = "operating-points-v2";
 
 		opp-267000000 {
@@ -137,7 +137,7 @@ opp-100000000 {
 		};
 	};
 
-	bus_gscl_opp_table: opp-table4 {
+	bus_gscl_opp_table: opp-table-4 {
 		compatible = "operating-points-v2";
 
 		opp-333000000 {
@@ -151,7 +151,7 @@ opp-166500000 {
 		};
 	};
 
-	bus_hevc_opp_table: opp-table5 {
+	bus_hevc_opp_table: opp-table-5 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -175,7 +175,7 @@ opp-100000000 {
 		};
 	};
 
-	bus_noc2_opp_table: opp-table6 {
+	bus_noc2_opp_table: opp-table-6 {
 		compatible = "operating-points-v2";
 
 		opp-400000000 {
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 6a6f7dd1d65c..ebd5091d68b4 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -239,7 +239,7 @@ cluster_a53_l2: l2-cache1 {
 		};
 	};
 
-	cluster_a53_opp_table: opp-table0 {
+	cluster_a53_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -285,7 +285,7 @@ opp-1300000000 {
 		};
 	};
 
-	cluster_a57_opp_table: opp-table1 {
+	cluster_a57_opp_table: opp-table-1 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433
  2021-08-20  8:14 [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 Krzysztof Kozlowski
@ 2021-08-20  8:21 ` Krzysztof Kozlowski
  2021-08-20 14:47   ` Alim Akhtar
  2021-08-20 14:44 ` [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema " Alim Akhtar
  2021-09-15  7:50 ` Krzysztof Kozlowski
  2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-20  8:21 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

The syscon nodes should come with specific compatible.  Correct theh
FSYS syscon to fix dtbs_check warnings:

  syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
  ['syscon'] is too short

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index ebd5091d68b4..4422021cf4b2 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1132,7 +1132,7 @@ syscon_cam1: syscon@145f0000 {
 		};
 
 		syscon_fsys: syscon@156f0000 {
-			compatible = "syscon";
+			compatible = "samsung,exynos5433-sysreg", "syscon";
 			reg = <0x156f0000 0x1044>;
 		};
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433
  2021-08-20  8:14 [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 Krzysztof Kozlowski
  2021-08-20  8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
@ 2021-08-20 14:44 ` Alim Akhtar
  2021-08-20 15:04   ` Krzysztof Kozlowski
  2021-09-15  7:50 ` Krzysztof Kozlowski
  2 siblings, 1 reply; 7+ messages in thread
From: Alim Akhtar @ 2021-08-20 14:44 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, devicetree, linux-arm-kernel, linux-samsung-soc, open list

On Fri, Aug 20, 2021 at 1:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Align the name of operating-points node to dtschema to fix warnings like:
>
Did you miss adding warnings here?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Rest looks good.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 10 +++++-----
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi     |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
> index 8997f8f2b96c..72ccf18eb9d1 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi
> @@ -87,7 +87,7 @@ bus_noc2: bus9 {
>                 status = "disabled";
>         };
>
> -       bus_g2d_400_opp_table: opp-table2 {
> +       bus_g2d_400_opp_table: opp-table-2 {
>                 compatible = "operating-points-v2";
>                 opp-shared;
>
> @@ -117,7 +117,7 @@ opp-100000000 {
>                 };
>         };
>
> -       bus_g2d_266_opp_table: opp-table3 {
> +       bus_g2d_266_opp_table: opp-table-3 {
>                 compatible = "operating-points-v2";
>
>                 opp-267000000 {
> @@ -137,7 +137,7 @@ opp-100000000 {
>                 };
>         };
>
> -       bus_gscl_opp_table: opp-table4 {
> +       bus_gscl_opp_table: opp-table-4 {
>                 compatible = "operating-points-v2";
>
>                 opp-333000000 {
> @@ -151,7 +151,7 @@ opp-166500000 {
>                 };
>         };
>
> -       bus_hevc_opp_table: opp-table5 {
> +       bus_hevc_opp_table: opp-table-5 {
>                 compatible = "operating-points-v2";
>                 opp-shared;
>
> @@ -175,7 +175,7 @@ opp-100000000 {
>                 };
>         };
>
> -       bus_noc2_opp_table: opp-table6 {
> +       bus_noc2_opp_table: opp-table-6 {
>                 compatible = "operating-points-v2";
>
>                 opp-400000000 {
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 6a6f7dd1d65c..ebd5091d68b4 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -239,7 +239,7 @@ cluster_a53_l2: l2-cache1 {
>                 };
>         };
>
> -       cluster_a53_opp_table: opp-table0 {
> +       cluster_a53_opp_table: opp-table-0 {
>                 compatible = "operating-points-v2";
>                 opp-shared;
>
> @@ -285,7 +285,7 @@ opp-1300000000 {
>                 };
>         };
>
> -       cluster_a57_opp_table: opp-table1 {
> +       cluster_a57_opp_table: opp-table-1 {
>                 compatible = "operating-points-v2";
>                 opp-shared;
>
> --
> 2.30.2
>


-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433
  2021-08-20  8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
@ 2021-08-20 14:47   ` Alim Akhtar
  2021-08-20 15:05     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Alim Akhtar @ 2021-08-20 14:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, devicetree, linux-arm-kernel, linux-samsung-soc, open list

On Fri, Aug 20, 2021 at 1:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The syscon nodes should come with specific compatible.  Correct theh
s/theh/the?

> FSYS syscon to fix dtbs_check warnings:
>
>   syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
>   ['syscon'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
With typo fixed above,
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index ebd5091d68b4..4422021cf4b2 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1132,7 +1132,7 @@ syscon_cam1: syscon@145f0000 {
>                 };
>
>                 syscon_fsys: syscon@156f0000 {
> -                       compatible = "syscon";
> +                       compatible = "samsung,exynos5433-sysreg", "syscon";
>                         reg = <0x156f0000 0x1044>;
>                 };
>
> --
> 2.30.2
>


-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433
  2021-08-20 14:44 ` [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema " Alim Akhtar
@ 2021-08-20 15:04   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-20 15:04 UTC (permalink / raw)
  To: Alim Akhtar
  Cc: Rob Herring, devicetree, linux-arm-kernel, linux-samsung-soc, open list

On 20/08/2021 16:44, Alim Akhtar wrote:
> On Fri, Aug 20, 2021 at 1:51 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> Align the name of operating-points node to dtschema to fix warnings like:
>>
> Did you miss adding warnings here?

Yeah, I missed. I will add it when applying.

> 
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
> Rest looks good.
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Thanks!


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433
  2021-08-20 14:47   ` Alim Akhtar
@ 2021-08-20 15:05     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-20 15:05 UTC (permalink / raw)
  To: Alim Akhtar
  Cc: Rob Herring, devicetree, linux-arm-kernel, linux-samsung-soc, open list

On 20/08/2021 16:47, Alim Akhtar wrote:
> On Fri, Aug 20, 2021 at 1:52 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The syscon nodes should come with specific compatible.  Correct theh
> s/theh/the?

Indeed, thanks!

> 
>> FSYS syscon to fix dtbs_check warnings:
>>
>>   syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
>>   ['syscon'] is too short
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
> With typo fixed above,
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>



Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433
  2021-08-20  8:14 [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 Krzysztof Kozlowski
  2021-08-20  8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
  2021-08-20 14:44 ` [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema " Alim Akhtar
@ 2021-09-15  7:50 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-15  7:50 UTC (permalink / raw)
  To: linux-samsung-soc, Rob Herring, Krzysztof Kozlowski, devicetree,
	linux-arm-kernel, linux-kernel

On Fri, 20 Aug 2021 10:14:57 +0200, Krzysztof Kozlowski wrote:
> Align the name of operating-points node to dtschema to fix warnings like:
> 
> 

Applied, thanks!

[1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433
      commit: ee3b1f976c5214b79d939ecaba42f9e83b5efc86
[2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433
      commit: 6de3cc6db06d2b9ba1e614aa58a413c9f8f22712

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-09-15  7:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20  8:14 [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 Krzysztof Kozlowski
2021-08-20  8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
2021-08-20 14:47   ` Alim Akhtar
2021-08-20 15:05     ` Krzysztof Kozlowski
2021-08-20 14:44 ` [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema " Alim Akhtar
2021-08-20 15:04   ` Krzysztof Kozlowski
2021-09-15  7:50 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).