linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE
@ 2021-09-09 22:28 David Virag
  2021-09-15  7:51 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: David Virag @ 2021-09-09 22:28 UTC (permalink / raw)
  Cc: virag.david003, Krzysztof Kozlowski, Sylwester Nawrocki,
	Stephen Boyd, linux-arm-kernel, linux-samsung-soc, linux-kernel

Commit 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
adds a "devm_mfd_add_devices" call in the exynos-pmu driver which depends
on CONFIG_MFD_CORE. If no driver selects that config, the build will fail
if CONFIG_EXYNOS_PMU is enabled with the following error:
drivers/soc/samsung/exynos-pmu.c:137: undefined reference to `devm_mfd_add_devices'

Fix this by making CONFIG_EXYNOS_PMU select CONFIG_MFD_CORE.
Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")

Signed-off-by: David Virag <virag.david003@gmail.com>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 5745d7e5908e..1f643c0f5c93 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -25,6 +25,7 @@ config EXYNOS_PMU
 	bool "Exynos PMU controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
 	select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+	select MFD_CORE
 
 # There is no need to enable these drivers for ARMv8
 config EXYNOS_PMU_ARM_DRIVERS
-- 
2.33.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE
  2021-09-09 22:28 [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE David Virag
@ 2021-09-15  7:51 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-15  7:51 UTC (permalink / raw)
  To: David Virag
  Cc: Krzysztof Kozlowski, Stephen Boyd, Sylwester Nawrocki,
	linux-samsung-soc, linux-arm-kernel, linux-kernel

On Fri, 10 Sep 2021 00:28:12 +0200, David Virag wrote:
> Commit 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
> adds a "devm_mfd_add_devices" call in the exynos-pmu driver which depends
> on CONFIG_MFD_CORE. If no driver selects that config, the build will fail
> if CONFIG_EXYNOS_PMU is enabled with the following error:
> drivers/soc/samsung/exynos-pmu.c:137: undefined reference to `devm_mfd_add_devices'
> 
> Fix this by making CONFIG_EXYNOS_PMU select CONFIG_MFD_CORE.
> Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
> 
> [...]

Applied, thanks!

[1/1] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE
      commit: e37ef6dcdb1f4738b01cec7fb7be46af07816af9

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-15  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 22:28 [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE David Virag
2021-09-15  7:51 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).