From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA56C433EF for ; Wed, 15 Sep 2021 07:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CE2C60F92 for ; Wed, 15 Sep 2021 07:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236725AbhIOHwc (ORCPT ); Wed, 15 Sep 2021 03:52:32 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:51280 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236738AbhIOHw3 (ORCPT ); Wed, 15 Sep 2021 03:52:29 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6BA5E40287 for ; Wed, 15 Sep 2021 07:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631692270; bh=6nQjB01kMNpwJ9V5V82yNfJ9kQBFgtVaK0a4ZeKC00M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=E0LxNg+pJXlVHPvt3Znxbt/bWERd6avSeY3jKqaZgZ39B7YGLg7GP9RVxN0Oo9kOi 9QZ50LwnVL+4CA2p530RccQFWeLxl8/ABXgorwdVIsnIqxkEl6PBH889zd8yNB5mYY I/QH9JokNuSVyeQmyp7DIfLkxMP+E/fof7hh5ISQc3X5ExrEdMgPJQ4usUQlUV14un HrVmzhVTPi3gShZoZBlyiuSqlKf7b6lNOJBIN8QVdCwr+4OIhnzR50tenOyFclYpH3 HiY5b3s7O+lJEokQFtUleNpqx8UePWP2YAMe0sj+mIiRhAedhn4vzxuBmbaK6UUDto A1k8n56+fwamQ== Received: by mail-ej1-f69.google.com with SMTP id f10-20020a170906390a00b005eeb8ca19f7so1060544eje.7 for ; Wed, 15 Sep 2021 00:51:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6nQjB01kMNpwJ9V5V82yNfJ9kQBFgtVaK0a4ZeKC00M=; b=kF6SKUDGSpJTWx0dMvn4s4gpMOMYiOEqMM4srQsQPqjpBZWp5foFIGlnhZNNUa9Mrn mU0zkHFDZiS8TcQj1VCe46QlddKw2BG5O9jbITsXClJ4Mq0wFolJcIXPG0sB8yfRemtH +oMhFKpefdl33viWH0X+KTGmNc8kWb1xod4+Tjt5c+BHB3ZQSk2SazLNcEf9ZTATBXFs vmOfC0XD/If2uYHhMNtay3E4bUgQkigriD9Q0942E5/CjNWlw0o1ku2kT5caSwE3kDRs 5gbZv3WfJE/zUIQeXZ6qWCUr85sv3jCh7V6HJhlLand1oakLyEeakgDoKT0cabfwZmFX n8tw== X-Gm-Message-State: AOAM532Aj0ADZlhu4XSYTqaXRNaeWoJenY7EENmYPzxoYfTWhyF/XPIQ uBnM4/UtX47khmJGgH2T35mf0/nKV+mCDNiIige7YwVL3+oeirsZu/0CxC6worFzaivramXdnFX wSlfEP7lcfZF85QIvGjiPG5RDUF+OhkMeQP6HTR2oIdUf8Af5 X-Received: by 2002:aa7:d954:: with SMTP id l20mr24646922eds.149.1631692270183; Wed, 15 Sep 2021 00:51:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA2tbVQBLoL30Jl3YTk9ku6S+NDv6sYxofUgnF4egYt9J3Tr5bgPCBwS5p3dKNR9Or91yKYQ== X-Received: by 2002:aa7:d954:: with SMTP id l20mr24646901eds.149.1631692270057; Wed, 15 Sep 2021 00:51:10 -0700 (PDT) Received: from kozik-lap.lan (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id n11sm591922edr.51.2021.09.15.00.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 00:51:09 -0700 (PDT) From: Krzysztof Kozlowski To: David Virag Cc: Krzysztof Kozlowski , Stephen Boyd , Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE Date: Wed, 15 Sep 2021 09:51:00 +0200 Message-Id: <163169222223.16372.8442242827654330539.b4-ty@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909222812.108614-1-virag.david003@gmail.com> References: <20210909222812.108614-1-virag.david003@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, 10 Sep 2021 00:28:12 +0200, David Virag wrote: > Commit 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD") > adds a "devm_mfd_add_devices" call in the exynos-pmu driver which depends > on CONFIG_MFD_CORE. If no driver selects that config, the build will fail > if CONFIG_EXYNOS_PMU is enabled with the following error: > drivers/soc/samsung/exynos-pmu.c:137: undefined reference to `devm_mfd_add_devices' > > Fix this by making CONFIG_EXYNOS_PMU select CONFIG_MFD_CORE. > Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD") > > [...] Applied, thanks! [1/1] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE commit: e37ef6dcdb1f4738b01cec7fb7be46af07816af9 Best regards, -- Krzysztof Kozlowski