From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@baylibre.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] clk/samsung: exynos542x: mark some clocks as critical
Date: Mon, 09 Jan 2017 13:30:40 +0100 [thread overview]
Message-ID: <1f51a603-b345-2c93-f4e1-9617dca387d0@samsung.com> (raw)
In-Reply-To: <1482399870-18563-1-git-send-email-m.szyprowski@samsung.com>
On 12/22/2016 10:44 AM, Marek Szyprowski wrote:
> Some parent clocks of the Exynos542x clock blocks, which have separate
> power domains (like DISP, MFC, MSC, GSC, FSYS and G2D) must be always
> enabled to access any register related to power management unit or devices
> connected to it. For the time being, until a proper solution based on
> runtime PM is applied, mark those clocks as critical (instead of ignore
> unused or even no flags) to prevent disabling them.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Stephen, Mike, could you apply the $subject patch directly? Due to recent
Exynos IOMMU related changes that patch is needed as a regression fix
for v4.10.
Thanks,
Sylwester
> ---
> drivers/clk/samsung/clk-exynos5420.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c
b/drivers/clk/samsung/clk-exynos5420.c
> index 8c8b495cbf0d..cdc092a1d9ef 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -586,7 +586,7 @@ static void __init exynos5420_clk_sleep_init(void) {}
> GATE(CLK_ACLK550_CAM, "aclk550_cam", "mout_user_aclk550_cam",
> GATE_BUS_TOP, 24, 0, 0),
> GATE(CLK_ACLK432_SCALER, "aclk432_scaler", "mout_user_aclk432_scaler",
> - GATE_BUS_TOP, 27, 0, 0),
> + GATE_BUS_TOP, 27, CLK_IS_CRITICAL, 0),
> };
>
> static const struct samsung_mux_clock exynos5420_mux_clks[] __initconst = {
> @@ -956,20 +956,20 @@ static void __init exynos5420_clk_sleep_init(void) {}
> GATE(CLK_SMMU_G2D, "smmu_g2d", "aclk333_g2d", GATE_IP_G2D, 7, 0, 0),
>
> GATE(0, "aclk200_fsys", "mout_user_aclk200_fsys",
> - GATE_BUS_FSYS0, 9, CLK_IGNORE_UNUSED, 0),
> + GATE_BUS_FSYS0, 9, CLK_IS_CRITICAL, 0),
> GATE(0, "aclk200_fsys2", "mout_user_aclk200_fsys2",
> GATE_BUS_FSYS0, 10, CLK_IGNORE_UNUSED, 0),
>
> GATE(0, "aclk333_g2d", "mout_user_aclk333_g2d",
> GATE_BUS_TOP, 0, CLK_IGNORE_UNUSED, 0),
> GATE(0, "aclk266_g2d", "mout_user_aclk266_g2d",
> - GATE_BUS_TOP, 1, CLK_IGNORE_UNUSED, 0),
> + GATE_BUS_TOP, 1, CLK_IS_CRITICAL, 0),
> GATE(0, "aclk300_jpeg", "mout_user_aclk300_jpeg",
> GATE_BUS_TOP, 4, CLK_IGNORE_UNUSED, 0),
> GATE(0, "aclk333_432_isp0", "mout_user_aclk333_432_isp0",
> GATE_BUS_TOP, 5, 0, 0),
> GATE(0, "aclk300_gscl", "mout_user_aclk300_gscl",
> - GATE_BUS_TOP, 6, CLK_IGNORE_UNUSED, 0),
> + GATE_BUS_TOP, 6, CLK_IS_CRITICAL, 0),
> GATE(0, "aclk333_432_gscl", "mout_user_aclk333_432_gscl",
> GATE_BUS_TOP, 7, CLK_IGNORE_UNUSED, 0),
> GATE(0, "aclk333_432_isp", "mout_user_aclk333_432_isp",
> @@ -983,20 +983,20 @@ static void __init exynos5420_clk_sleep_init(void) {}
> GATE(0, "aclk166", "mout_user_aclk166",
> GATE_BUS_TOP, 14, CLK_IGNORE_UNUSED, 0),
> GATE(CLK_ACLK333, "aclk333", "mout_user_aclk333",
> - GATE_BUS_TOP, 15, CLK_IGNORE_UNUSED, 0),
> + GATE_BUS_TOP, 15, CLK_IS_CRITICAL, 0),
> GATE(0, "aclk400_isp", "mout_user_aclk400_isp",
> GATE_BUS_TOP, 16, 0, 0),
> GATE(0, "aclk400_mscl", "mout_user_aclk400_mscl",
> GATE_BUS_TOP, 17, 0, 0),
> GATE(0, "aclk200_disp1", "mout_user_aclk200_disp1",
> - GATE_BUS_TOP, 18, 0, 0),
> + GATE_BUS_TOP, 18, CLK_IS_CRITICAL, 0),
> GATE(CLK_SCLK_MPHY_IXTAL24, "sclk_mphy_ixtal24", "mphy_refclk_ixtal24",
> GATE_BUS_TOP, 28, 0, 0),
> GATE(CLK_SCLK_HSIC_12M, "sclk_hsic_12m", "ff_hsic_12m",
> GATE_BUS_TOP, 29, 0, 0),
>
> GATE(0, "aclk300_disp1", "mout_user_aclk300_disp1",
> - SRC_MASK_TOP2, 24, 0, 0),
> + SRC_MASK_TOP2, 24, CLK_IS_CRITICAL, 0),
>
> GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk",
> SRC_MASK_TOP7, 20, 0, 0),
next prev parent reply other threads:[~2017-01-09 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161222094441epcas5p330bb16763e02149a275c30eb644b0e7c@epcas5p3.samsung.com>
2016-12-22 9:44 ` [PATCH] clk/samsung: exynos542x: mark some clocks as critical Marek Szyprowski
2016-12-22 13:07 ` Javier Martinez Canillas
2016-12-23 17:00 ` Chanwoo Choi
2016-12-27 8:14 ` Marek Szyprowski
2016-12-27 8:24 ` Chanwoo Choi
2017-01-09 12:30 ` Sylwester Nawrocki [this message]
2017-01-10 0:10 ` Stephen Boyd
2017-01-10 0:11 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f51a603-b345-2c93-f4e1-9617dca387d0@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).