* [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module
@ 2016-12-09 7:22 Marek Szyprowski
2016-12-09 7:22 ` [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards Marek Szyprowski
2016-12-09 14:29 ` [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Marek Szyprowski @ 2016-12-09 7:22 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
"iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S
hardware module, so they should be defined in .dtsi file not in the random
board .dts file.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changelog:
v2:
- added changes for exynos4412-itop-elite board
---
arch/arm/boot/dts/exynos4.dtsi | 6 ++++--
arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ----
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ----
3 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index c64737b..23d85601 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -64,8 +64,10 @@
i2s0: i2s@03830000 {
compatible = "samsung,s5pv210-i2s";
reg = <0x03830000 0x100>;
- clocks = <&clock_audss EXYNOS_I2S_BUS>;
- clock-names = "iis";
+ clocks = <&clock_audss EXYNOS_I2S_BUS>,
+ <&clock_audss EXYNOS_DOUT_AUD_BUS>,
+ <&clock_audss EXYNOS_SCLK_I2S>;
+ clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
#clock-cells = <1>;
clock-output-names = "i2s_cdclk0";
dmas = <&pdma0 12>, <&pdma0 11>, <&pdma0 10>;
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index 76d87f3..1ac9129 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -198,10 +198,6 @@
pinctrl-0 = <&i2s0_bus>;
pinctrl-names = "default";
status = "okay";
- clocks = <&clock_audss EXYNOS_I2S_BUS>,
- <&clock_audss EXYNOS_DOUT_AUD_BUS>,
- <&clock_audss EXYNOS_SCLK_I2S>;
- clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
};
&pinctrl_1 {
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 8aa19ba..7815efd 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -503,10 +503,6 @@
pinctrl-0 = <&i2s0_bus>;
pinctrl-names = "default";
status = "okay";
- clocks = <&clock_audss EXYNOS_I2S_BUS>,
- <&clock_audss EXYNOS_DOUT_AUD_BUS>,
- <&clock_audss EXYNOS_SCLK_I2S>;
- clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
};
&mixer {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards
2016-12-09 7:22 [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Marek Szyprowski
@ 2016-12-09 7:22 ` Marek Szyprowski
2016-12-09 14:30 ` Krzysztof Kozlowski
2016-12-28 17:28 ` Krzysztof Kozlowski
2016-12-09 14:29 ` [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Krzysztof Kozlowski
1 sibling, 2 replies; 6+ messages in thread
From: Marek Szyprowski @ 2016-12-09 7:22 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
Move assigned clocks properties from sound node to audio subsystem clock
controller node. This way clocks topology and rates are set just after
probing audio clocks controller. Leaving those properties under
sound node doesn't guarantee to configure them before they are being used
(for example i2s hardware module can be probed in parallel and it also
require proper audio clocks configuration).
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changelog:
v2:
- added changes for exynos4412-itop-elite board
---
arch/arm/boot/dts/exynos4412-itop-elite.dts | 21 ++++++++++-----------
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 20 ++++++++++----------
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index 1ac9129..d660930 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -82,17 +82,6 @@
compatible = "simple-audio-card";
simple-audio-card,name = "wm-sound";
- assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
- <&clock_audss EXYNOS_MOUT_I2S>,
- <&clock_audss EXYNOS_DOUT_SRP>,
- <&clock_audss EXYNOS_DOUT_AUD_BUS>;
- assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
- <&clock_audss EXYNOS_MOUT_AUDSS>;
- assigned-clock-rates = <0>,
- <0>,
- <112896000>,
- <11289600>;
-
simple-audio-card,format = "i2s";
simple-audio-card,bitclock-master = <&link0_codec>;
simple-audio-card,frame-master = <&link0_codec>;
@@ -145,6 +134,16 @@
status = "okay";
};
+&clock_audss {
+ assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
+ <&clock_audss EXYNOS_MOUT_I2S>,
+ <&clock_audss EXYNOS_DOUT_SRP>,
+ <&clock_audss EXYNOS_DOUT_AUD_BUS>;
+ assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
+ <&clock_audss EXYNOS_MOUT_AUDSS>;
+ assigned-clock-rates = <0>, <0>, <112896000>, <11289600>;
+};
+
&ehci {
status = "okay";
/* In order to reset USB ethernet */
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 7815efd..b6b0f50 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -43,16 +43,6 @@
sound: sound {
compatible = "simple-audio-card";
- assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
- <&clock_audss EXYNOS_MOUT_I2S>,
- <&clock_audss EXYNOS_DOUT_SRP>,
- <&clock_audss EXYNOS_DOUT_AUD_BUS>;
- assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
- <&clock_audss EXYNOS_MOUT_AUDSS>;
- assigned-clock-rates = <0>,
- <0>,
- <192000000>,
- <19200000>;
simple-audio-card,format = "i2s";
simple-audio-card,bitclock-master = <&link0_codec>;
@@ -157,6 +147,16 @@
status = "okay";
};
+&clock_audss {
+ assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
+ <&clock_audss EXYNOS_MOUT_I2S>,
+ <&clock_audss EXYNOS_DOUT_SRP>,
+ <&clock_audss EXYNOS_DOUT_AUD_BUS>;
+ assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
+ <&clock_audss EXYNOS_MOUT_AUDSS>;
+ assigned-clock-rates = <0>, <0>, <192000000>, <19200000>;
+};
+
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module
2016-12-09 7:22 [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Marek Szyprowski
2016-12-09 7:22 ` [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards Marek Szyprowski
@ 2016-12-09 14:29 ` Krzysztof Kozlowski
2016-12-28 17:26 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-12-09 14:29 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
On Fri, Dec 09, 2016 at 08:22:10AM +0100, Marek Szyprowski wrote:
> "iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S
> hardware module, so they should be defined in .dtsi file not in the random
> board .dts file.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Changelog:
> v2:
> - added changes for exynos4412-itop-elite board
> ---
> arch/arm/boot/dts/exynos4.dtsi | 6 ++++--
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ----
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ----
> 3 files changed, 4 insertions(+), 10 deletions(-)
For the reference:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards
2016-12-09 7:22 ` [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards Marek Szyprowski
@ 2016-12-09 14:30 ` Krzysztof Kozlowski
2016-12-28 17:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-12-09 14:30 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
On Fri, Dec 09, 2016 at 08:22:11AM +0100, Marek Szyprowski wrote:
> Move assigned clocks properties from sound node to audio subsystem clock
> controller node. This way clocks topology and rates are set just after
> probing audio clocks controller. Leaving those properties under
> sound node doesn't guarantee to configure them before they are being used
> (for example i2s hardware module can be probed in parallel and it also
> require proper audio clocks configuration).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Changelog:
> v2:
> - added changes for exynos4412-itop-elite board
> ---
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 21 ++++++++++-----------
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 20 ++++++++++----------
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module
2016-12-09 14:29 ` [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Krzysztof Kozlowski
@ 2016-12-28 17:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-12-28 17:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Marek Szyprowski, linux-samsung-soc, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
On Fri, Dec 09, 2016 at 04:29:19PM +0200, Krzysztof Kozlowski wrote:
> On Fri, Dec 09, 2016 at 08:22:10AM +0100, Marek Szyprowski wrote:
> > "iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S
> > hardware module, so they should be defined in .dtsi file not in the random
> > board .dts file.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > Changelog:
> > v2:
> > - added changes for exynos4412-itop-elite board
> > ---
> > arch/arm/boot/dts/exynos4.dtsi | 6 ++++--
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ----
> > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ----
> > 3 files changed, 4 insertions(+), 10 deletions(-)
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards
2016-12-09 7:22 ` [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards Marek Szyprowski
2016-12-09 14:30 ` Krzysztof Kozlowski
@ 2016-12-28 17:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-12-28 17:28 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
On Fri, Dec 09, 2016 at 08:22:11AM +0100, Marek Szyprowski wrote:
> Move assigned clocks properties from sound node to audio subsystem clock
> controller node. This way clocks topology and rates are set just after
> probing audio clocks controller. Leaving those properties under
> sound node doesn't guarantee to configure them before they are being used
> (for example i2s hardware module can be probed in parallel and it also
> require proper audio clocks configuration).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Changelog:
> v2:
> - added changes for exynos4412-itop-elite board
> ---
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 21 ++++++++++-----------
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 20 ++++++++++----------
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-28 17:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-09 7:22 [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Marek Szyprowski
2016-12-09 7:22 ` [PATCH v2 2/2] ARM: dts: exynos: Fix initial audio clocks configuration on Exynos4 boards Marek Szyprowski
2016-12-09 14:30 ` Krzysztof Kozlowski
2016-12-28 17:28 ` Krzysztof Kozlowski
2016-12-09 14:29 ` [PATCH v2 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Krzysztof Kozlowski
2016-12-28 17:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).