From: Andi Shyti <andi@smida.it>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Andi Shyti <andi@etezian.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Andi Shyti <andi.shyti@samsung.com>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM64: dts: exynos5433: remove unused code
Date: Thu, 29 Dec 2016 22:41:46 +0900 [thread overview]
Message-ID: <20161229134146.kolvpxrdo2epfav4@jack.zhora.eu> (raw)
In-Reply-To: <20161229115421.pq52ab57e53xntoz@kozik-lap>
> > #include <dt-bindings/pinctrl/samsung.h>
> >
> > -#define PIN_PULL_NONE 0
> > -#define PIN_PULL_DOWN 1
> > -#define PIN_PULL_UP 3
> > -
> > -#define PIN_DRV_LV1 0
> > -#define PIN_DRV_LV2 2
> > -#define PIN_DRV_LV3 1
> > -#define PIN_DRV_LV4 3
> > -
> > -#define PIN_IN 0
> > -#define PIN_OUT 1
> > -#define PIN_FUNC1 2
> > -
>
> This should be squashed with 3/4 because logically it is strictly
> related to it and splitting it does not bring any benefits. Actually
> while looking at 3/4 I was surprised to see them not removed.
Yes, right :)
Thanks,
Andi
prev parent reply other threads:[~2016-12-29 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161229084221epcas1p4d76b4b30f59734f7eee29aec53b54af3@epcas1p4.samsung.com>
2016-12-29 8:42 ` [PATCH 0/4] Use Exynos macros for pinctrl settings Andi Shyti
[not found] ` <CGME20161229084221epcas5p43926b87dccbee0db4045faa5ddca565d@epcas5p4.samsung.com>
2016-12-29 8:42 ` [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433 Andi Shyti
2016-12-29 9:17 ` Chanwoo Choi
2016-12-29 10:33 ` Chanwoo Choi
[not found] ` <CGME20161229093931epcas1p11b118da454a0dbf3a798ba406f35ce54@epcas1p1.samsung.com>
2016-12-29 9:39 ` [1/4] " Jaehoon Chung
[not found] ` <20161229084211.20442-2-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-12-29 11:50 ` [PATCH 1/4] " Krzysztof Kozlowski
2016-12-29 13:41 ` Andi Shyti
[not found] ` <CGME20161229084222epcas1p4b9ef5db922132015bf74d0f0fcecb486@epcas1p4.samsung.com>
2016-12-29 8:42 ` [PATCH 2/4] ARM64: dts: exynos5433: use macros for pinctrl configuration on Exynos5433 Andi Shyti
[not found] ` <CGME20161229084222epcas1p4c0db2fd327fc92bfe123442f44b88ab5@epcas1p4.samsung.com>
[not found] ` <20161229084211.20442-1-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-12-29 8:42 ` [PATCH 3/4] ARM64: dts: TM2: comply to the samsung pinctrl naming convention Andi Shyti
[not found] ` <CGME20161229084222epcas5p41dacaeed3e2d4f10b07eee3930f7531c@epcas5p4.samsung.com>
2016-12-29 8:42 ` [PATCH 4/4] ARM64: dts: exynos5433: remove unused code Andi Shyti
2016-12-29 11:54 ` Krzysztof Kozlowski
2016-12-29 13:41 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229134146.kolvpxrdo2epfav4@jack.zhora.eu \
--to=andi@smida.it \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).