From: Andi Shyti <andi.shyti@samsung.com>
To: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
javier@osg.samsung.com, airlied@linux.ie,
catalin.marinas@arm.com, sw0312.kim@samsung.com,
linux-kernel@vger.kernel.org, krzk@kernel.org,
inki.dae@samsung.com, robh+dt@kernel.org, kgene@kernel.org,
dri-devel@lists.freedesktop.org, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency properties for exynos3250 dts
Date: Fri, 03 Mar 2017 09:26:07 +0900 [thread overview]
Message-ID: <20170303002607.fdw6ipqzzvo6j5wh@gangnam.samsung> (raw)
In-Reply-To: <1488450019-6482-3-git-send-email-hoegeun.kwon@samsung.com>
Hi Hoegeun,
On Thu, Mar 02, 2017 at 07:20:14PM +0900, Hoegeun Kwon wrote:
> The OF graph is not needed because the panel is a child of dsi. So
> added the burst and esc clock frequency properties to the parent (DSI
> node), taking into account the bisectability problem so that remove
> the OF graph from DSI node.
nitpick:
1. bisectability is not a problem (and for bisectability you
should not mention it in the commit log, you would confuse
bisecting people)
2. you should use the imperative form, not "added the burst... "
but "add the burst..."
Same for the other patches.
Andi
next prev parent reply other threads:[~2017-03-03 0:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170302102112epcas5p476b30508bbaffbf1fe9781b941cd418f@epcas5p4.samsung.com>
2017-03-02 10:20 ` [PATCH v3 0/7] Fix the parse_dt of exynos dsi and remove the OF graph Hoegeun Kwon
[not found] ` <CGME20170302102113epcas5p4992ba2da58333ee0e3fe988334aad9a9@epcas5p4.samsung.com>
2017-03-02 10:20 ` [PATCH v3 1/7] arm64: dts: exynos: Add the burst and esc clock frequency properties for exynos5433 dts Hoegeun Kwon
[not found] ` <CGME20170302102113epcas1p343e9da20f05be0a2359bf32834626c4a@epcas1p3.samsung.com>
2017-03-02 10:20 ` [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency properties for exynos3250 dts Hoegeun Kwon
2017-03-03 0:26 ` Andi Shyti [this message]
[not found] ` <CGME20170302102113epcas5p4c93024f46ed53ac962b332b559553cd5@epcas5p4.samsung.com>
2017-03-02 10:20 ` [PATCH v3 3/7] arm: dts: Add the burst and esc clock frequency properties for exynos4412 dts Hoegeun Kwon
[not found] ` <CGME20170302102113epcas5p491d4220b8ae7a037d1cd7ece49bb2d3e@epcas5p4.samsung.com>
2017-03-02 10:20 ` [PATCH v3 4/7] arm: dts: Add the burst and esc clock frequency properties for exynos4210 dts Hoegeun Kwon
[not found] ` <CGME20170302102113epcas1p306e85959e4bbfe1ecb0e5af8fcd18b7d@epcas1p3.samsung.com>
2017-03-02 10:20 ` [PATCH v3 5/7] drm/exynos: dsi: Fix the parse_dt function Hoegeun Kwon
[not found] ` <CGME20170302102113epcas5p466a64e5f55c008ceec957b1432a30173@epcas5p4.samsung.com>
2017-03-02 10:20 ` [PATCH v3 6/7] arm64: dts: exynos: Remove the OF graph from DSI node Hoegeun Kwon
[not found] ` <CGME20170302102113epcas1p30d42204d23a4e0def2a406086fea9cef@epcas1p3.samsung.com>
2017-03-02 10:20 ` [PATCH v3 7/7] arm: dts: " Hoegeun Kwon
2017-03-03 0:22 ` [PATCH v3 0/7] Fix the parse_dt of exynos dsi and remove the OF graph Andi Shyti
2017-03-04 8:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303002607.fdw6ipqzzvo6j5wh@gangnam.samsung \
--to=andi.shyti@samsung.com \
--cc=airlied@linux.ie \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegeun.kwon@samsung.com \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).