From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 02/10] dt-bindings: sram: Convert Samsung Exynos SYSRAM bindings to json-schema Date: Fri, 11 Oct 2019 09:52:53 +0200 Message-ID: <20191011075253.GA7998@pi3> References: <20191002164316.14905-1-krzk@kernel.org> <20191002164316.14905-2-krzk@kernel.org> <20191010193356.GA9975@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20191010193356.GA9975@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Mark Rutland , Kukjin Kim , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Santosh Shilimkar , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc List-Id: linux-samsung-soc@vger.kernel.org On Thu, Oct 10, 2019 at 02:33:56PM -0500, Rob Herring wrote: > On Wed, Oct 02, 2019 at 06:43:08PM +0200, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos SYSRAM bindings to DT schema format using > > json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v2: > > 1. Use sram as name of node in example. > > > > Changes since v1: > > 1. Indent example with four spaces (more readable). > > --- > > .../devicetree/bindings/sram/samsung-sram.txt | 38 ------------ > > .../bindings/sram/samsung-sram.yaml | 58 +++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 59 insertions(+), 39 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.txt > > create mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.yaml > > > > diff --git a/Documentation/devicetree/bindings/sram/samsung-sram.yaml b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > > new file mode 100644 > > index 000000000000..3e77c434ecca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sram/samsung-sram.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos SoC SYSRAM for SMP bringup > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +description: |+ > > + Samsung SMP-capable Exynos SoCs use part of the SYSRAM for the bringup > > + of the secondary cores. Once the core gets powered up it executes the > > + code that is residing at some specific location of the SYSRAM. > > + > > + Therefore reserved section sub-nodes have to be added to the mmio-sram > > + declaration. These nodes are of two types depending upon secure or > > + non-secure execution environment. > > + > > +allOf: > > + - $ref: "sram.yaml#" > > + > > +properties: > > + $nodename: > > + pattern: "^sysram(@.*)?" > > As you are renaming all the node names, this will no longer work. If you > change it to 'sram', that's going to match others, but would still work > as long as the child node names are unique to Samsung. If you change > them to '*-sram' then, you'd have to come up with something else. That > probably means using 'compatible' strings. At that point, it's kind of > silly to just be validating what your are using to select the schema. It > may be better to just add the compatible strings into sram.yaml if > that's the only difference. You're right. I'll move them to sram.yaml and maybe add also example. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF517C47404 for ; Fri, 11 Oct 2019 07:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99EF121D7D for ; Fri, 11 Oct 2019 07:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570780383; bh=fJAegLI9Pz5Hf9p961wpFRuIFnE2rKXGhap4FRX0sN8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ImH8l4KAkZkdMHSAF2YxAlZSwiLpI01AdL+Pq+OngBzK5P9iePoLZZrlRwm/L1rBx 4jvSEQCHsvU6il+lHug3kkF5hBYAmGypebO4Tp1JBkbR9rT7GtPcxPY11Vruc5T1Yw prO4WnpD/65v08UEtEsb29z6aJROQQI8puUG3F1o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbfJKHxA (ORCPT ); Fri, 11 Oct 2019 03:53:00 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34314 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbfJKHxA (ORCPT ); Fri, 11 Oct 2019 03:53:00 -0400 Received: by mail-wr1-f65.google.com with SMTP id j11so10751250wrp.1; Fri, 11 Oct 2019 00:52:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EwPBmMRYQqmwwMpYc8okL9s1LKq8P2O4QBbeYixrVK4=; b=qmkuo+/I5tcKNbqICKPzw0l/7zJCIDaKZaulAYOf9ZEbUzrdks5JkVy6rmiQn2cWLY /ocsncebfHiZx50AXFtfNs5VCCSoSC5cZvJJ4uMMwPHVziip0zHPmD4d6AgmlsUV3R3z Im3wAue2hHzmrR+j9TlSCppd32ip8lYCtQqnueca3untVi5kw72qgDjPdo5U/XGYV+jK 8Utxp0KN23BbGWjscMsY/bsE62pDXRpZtiWYir9RBIhEB4NllcL5xWc7ek9HOgtzrX5W PlGQ1KcXxa+8/wyOAQYDtSSyOKaogPm7lHFxIkmLPoBNxb8KS4FLZgHE01hz16cA7km5 aRDA== X-Gm-Message-State: APjAAAXRi957Q64y22Rz6xuhwY4gOgixODOLlZxHCZrHOinhQztQ02Mt dEMeoIMGXtq6XGXvGzfE8sU= X-Google-Smtp-Source: APXvYqxUy16ah5vufdoPXO9FppUIVRbpWBWt1wAegLgSI9eN5KbSUDFilIoDI6Bb75H+vXTIy2Z4Rg== X-Received: by 2002:a5d:6949:: with SMTP id r9mr8819898wrw.106.1570780376664; Fri, 11 Oct 2019 00:52:56 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id b22sm7040031wmj.36.2019.10.11.00.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 00:52:55 -0700 (PDT) Date: Fri, 11 Oct 2019 09:52:53 +0200 From: Krzysztof Kozlowski To: Rob Herring Cc: Mark Rutland , Kukjin Kim , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Santosh Shilimkar , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v3 02/10] dt-bindings: sram: Convert Samsung Exynos SYSRAM bindings to json-schema Message-ID: <20191011075253.GA7998@pi3> References: <20191002164316.14905-1-krzk@kernel.org> <20191002164316.14905-2-krzk@kernel.org> <20191010193356.GA9975@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20191010193356.GA9975@bogus> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Message-ID: <20191011075253.Oz1P6P9mpmBHOkr_LGXCxidHqv7c3fGHNZW6KPAsL6k@z> On Thu, Oct 10, 2019 at 02:33:56PM -0500, Rob Herring wrote: > On Wed, Oct 02, 2019 at 06:43:08PM +0200, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos SYSRAM bindings to DT schema format using > > json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v2: > > 1. Use sram as name of node in example. > > > > Changes since v1: > > 1. Indent example with four spaces (more readable). > > --- > > .../devicetree/bindings/sram/samsung-sram.txt | 38 ------------ > > .../bindings/sram/samsung-sram.yaml | 58 +++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 59 insertions(+), 39 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.txt > > create mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.yaml > > > > diff --git a/Documentation/devicetree/bindings/sram/samsung-sram.yaml b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > > new file mode 100644 > > index 000000000000..3e77c434ecca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sram/samsung-sram.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos SoC SYSRAM for SMP bringup > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +description: |+ > > + Samsung SMP-capable Exynos SoCs use part of the SYSRAM for the bringup > > + of the secondary cores. Once the core gets powered up it executes the > > + code that is residing at some specific location of the SYSRAM. > > + > > + Therefore reserved section sub-nodes have to be added to the mmio-sram > > + declaration. These nodes are of two types depending upon secure or > > + non-secure execution environment. > > + > > +allOf: > > + - $ref: "sram.yaml#" > > + > > +properties: > > + $nodename: > > + pattern: "^sysram(@.*)?" > > As you are renaming all the node names, this will no longer work. If you > change it to 'sram', that's going to match others, but would still work > as long as the child node names are unique to Samsung. If you change > them to '*-sram' then, you'd have to come up with something else. That > probably means using 'compatible' strings. At that point, it's kind of > silly to just be validating what your are using to select the schema. It > may be better to just add the compatible strings into sram.yaml if > that's the only difference. You're right. I'll move them to sram.yaml and maybe add also example. Best regards, Krzysztof