From: Bjorn Helgaas <helgaas@kernel.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: jingoohan1@gmail.com, lorenzo.pieralisi@arm.com,
andrew.murray@arm.com, kgene@kernel.org, krzk@kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH] pci: controller: dwc: Remove dev_err use after platform_get_irq
Date: Wed, 30 Oct 2019 16:46:21 -0500 [thread overview]
Message-ID: <20191030214621.GA256263@google.com> (raw)
In-Reply-To: <20191028202144.GA29158@saurav>
Please run "git log --oneline drivers/pci/controller/dwc/pci-exynos.c"
and make your subject line match, e.g.,
PCI: exynos: Remove dev_err() usage after platform_get_irq()
The body of that was copied from similar commits like:
fb5a35dbee8d pwm: Remove dev_err() usage after platform_get_irq()
9a7957d0c955 mmc: Remove dev_err() usage after platform_get_irq()
1df217868178 tty: Remove dev_err() usage after platform_get_irq()
It's nice when similar commits have similar subject lines.
In fact, this whole thing has been approached before:
https://lore.kernel.org/lkml/20190730181557.90391-32-swboyd@chromium.org/
That patch would have fixed many similar issues in PCI, but I don't
know what happened to it. Would you mind resurrecting that and fixing
the minor issues so we can do everything in PCI at once?
On Tue, Oct 29, 2019 at 01:51:44AM +0530, Saurav Girepunje wrote:
> Don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/pci/controller/dwc/pci-exynos.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
> index 14a6ba4067fb..2293b346d96a 100644
> --- a/drivers/pci/controller/dwc/pci-exynos.c
> +++ b/drivers/pci/controller/dwc/pci-exynos.c
> @@ -403,7 +403,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
>
> pp->irq = platform_get_irq(pdev, 1);
> if (pp->irq < 0) {
> - dev_err(dev, "failed to get irq\n");
> return pp->irq;
> }
> ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,
> @@ -416,7 +415,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
> if (IS_ENABLED(CONFIG_PCI_MSI)) {
> pp->msi_irq = platform_get_irq(pdev, 0);
> if (pp->msi_irq < 0) {
> - dev_err(dev, "failed to get msi irq\n");
> return pp->msi_irq;
> }
> }
> --
> 2.20.1
>
prev parent reply other threads:[~2019-10-30 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 20:21 [PATCH] pci: controller: dwc: Remove dev_err use after platform_get_irq Saurav Girepunje
2019-10-30 21:46 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030214621.GA256263@google.com \
--to=helgaas@kernel.org \
--cc=andrew.murray@arm.com \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).