From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8092C43215 for ; Tue, 3 Dec 2019 06:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EA8A2073F for ; Tue, 3 Dec 2019 06:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D14DfDQG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbfLCGjt (ORCPT ); Tue, 3 Dec 2019 01:39:49 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:56442 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbfLCGjt (ORCPT ); Tue, 3 Dec 2019 01:39:49 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 70227309; Tue, 3 Dec 2019 07:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575355186; bh=NKJAGVwnbEA5vcxRJnNw/eHXqWVE7J8TQMaQ6WQ1rME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D14DfDQGqmcPI/cWzbaSwFmIu2oGRWeQ94ouc59CDImFZ8t3SX6+BbiXsn2fRsOZk Tnv6M49uf5jSzTHOa93zxLqOpHWEUA/ltoic1as76ib31vB5+Oo8hU9R8nUV2Cj5eu z/3+mXvqwo0HuNNUiRzpAUwj6s6qiSBMTuin2TnY= Date: Tue, 3 Dec 2019 08:39:40 +0200 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Abhinav Kumar , Andrzej Hajda , Benjamin Gaignard , Boris Brezillon , Daniel Vetter , David Airlie , Jagan Teki , Jitao Shi , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Neil Armstrong , NXP Linux Team , Pengutronix Kernel Team , Purism Kernel Team , Sean Paul , Stefan Agner , Tomi Valkeinen Subject: Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support Message-ID: <20191203063940.GC4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202193230.21310-4-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:07PM +0100, Sam Ravnborg wrote: > Use drm_panel infrastructure for backlight. > Replace direct calls with drm_panel_*() calls > to utilize the drm_panel support. > > Signed-off-by: Sam Ravnborg > cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 50 ++++++---------------------- > 1 file changed, 11 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 72f69709f349..a5df6d6dd455 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -21,7 +21,6 @@ > * DEALINGS IN THE SOFTWARE. > */ > > -#include > #include > #include > #include > @@ -105,7 +104,6 @@ struct panel_simple { > > const struct panel_desc *desc; > > - struct backlight_device *backlight; > struct regulator *supply; > struct i2c_adapter *ddc; > > @@ -236,12 +234,6 @@ static int panel_simple_disable(struct drm_panel *panel) > if (!p->enabled) > return 0; > > - if (p->backlight) { > - p->backlight->props.power = FB_BLANK_POWERDOWN; > - p->backlight->props.state |= BL_CORE_FBBLANK; > - backlight_update_status(p->backlight); > - } > - > if (p->desc->delay.disable) > msleep(p->desc->delay.disable); > > @@ -307,12 +299,6 @@ static int panel_simple_enable(struct drm_panel *panel) > if (p->desc->delay.enable) > msleep(p->desc->delay.enable); > > - if (p->backlight) { > - p->backlight->props.state &= ~BL_CORE_FBBLANK; > - p->backlight->props.power = FB_BLANK_UNBLANK; > - backlight_update_status(p->backlight); > - } > - > p->enabled = true; > > return 0; > @@ -414,9 +400,9 @@ static void panel_simple_parse_panel_timing_node(struct device *dev, > > static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > { > - struct device_node *backlight, *ddc; > struct panel_simple *panel; > struct display_timing dt; > + struct device_node *ddc; > int err; > > panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); > @@ -442,24 +428,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > return err; > } > > - backlight = of_parse_phandle(dev->of_node, "backlight", 0); > - if (backlight) { > - panel->backlight = of_find_backlight_by_node(backlight); > - of_node_put(backlight); > - > - if (!panel->backlight) > - return -EPROBE_DEFER; > - } > - > ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0); > if (ddc) { > panel->ddc = of_find_i2c_adapter_by_node(ddc); > of_node_put(ddc); > > - if (!panel->ddc) { > - err = -EPROBE_DEFER; > - goto free_backlight; > - } > + if (!panel->ddc) > + return -EPROBE_DEFER; > } > > if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) > @@ -468,6 +443,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > drm_panel_init(&panel->base, dev, &panel_simple_funcs, > desc->connector_type); > > + err = drm_panel_of_backlight(&panel->base); > + if (err) > + goto free_ddc; > + > err = drm_panel_add(&panel->base); > if (err < 0) > goto free_ddc; > @@ -479,9 +458,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > -free_backlight: > - if (panel->backlight) > - put_device(&panel->backlight->dev); > > return err; > } > @@ -491,16 +467,12 @@ static int panel_simple_remove(struct device *dev) > struct panel_simple *panel = dev_get_drvdata(dev); > > drm_panel_remove(&panel->base); > - > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); > > if (panel->ddc) > put_device(&panel->ddc->dev); > > - if (panel->backlight) > - put_device(&panel->backlight->dev); > - > return 0; > } > > @@ -508,8 +480,8 @@ static void panel_simple_shutdown(struct device *dev) > { > struct panel_simple *panel = dev_get_drvdata(dev); > > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); Without your panel double-disable protection series, you risk disabling the backlight twice. I think backlight_disable() will work fine, but you may want to double-check. With this checked (and possibly addressed if needed), Reviewed-by: Laurent Pinchart > } > > static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- Regards, Laurent Pinchart