From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7835C43603 for ; Mon, 9 Dec 2019 08:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 797BD207FD for ; Mon, 9 Dec 2019 08:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575880880; bh=UXLOMurqwKkA+gAmAEDj8T5iIPVpTAJCi4LFLRjm3Jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=W04LKeAvHsu1Xai5fM/1c4ixW6BE8npxrsaItoskRWuJR/g0pXozW5CAkjkMa98Hd jwLuitABRGWgxCKrKQVANl1Kx9lee8rqqcS1VykKnqO7tDMeY0Vctu4hnIWm/wWMd0 RXhgc/xApu+2ht2RKz7oJsG3lmXejiITVkOf0hAA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfLIIlU convert rfc822-to-8bit (ORCPT ); Mon, 9 Dec 2019 03:41:20 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:35994 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbfLIIlT (ORCPT ); Mon, 9 Dec 2019 03:41:19 -0500 Received: by mail-ed1-f66.google.com with SMTP id j17so11966630edp.3; Mon, 09 Dec 2019 00:41:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2kW38B0cuYpIKkhvAIys+E2QTBK5Yh5SHGBkdoRtsZ8=; b=U/doeb0ASSeLccIJVyuKbb14cdUxK+NMzI2y90TfR7K3CZwcVjYwkvNnO5Rw3QGWGE Zum0Y67eA2gRY8/0VR9U3KOBRBqWkNgYCiLUlqBFcOgDH/pnPT1OJLhmIIkAMxSMVRmb HmXWsLh67esThZGiT3KpWIYDWC3OMkFaZ1gz3VTqwzwB6R/fy5mazUrJoem9J37zncAi Izh9SzhCN6IQdmCJaKXlMJNZ0WTFgVi4Q29Jrw9vpTAcHdFOEe99MhOy/uFDPUu2GvbZ NQDZdw/mVtrDUTvvmipdM7vw40EImRgmK5viRm8+77NQLRyozrbbx3TifCX3VUIVCzJU a6Pw== X-Gm-Message-State: APjAAAWiP69oileIM5fG9hkeZS9/X/lElHQ9S8J9Um2hA6jG+L1SqDds ht3ivArDIdrxBv5QiJiztiM= X-Google-Smtp-Source: APXvYqxnmfRBujpXQ+VU19W08DbV8Aj87ESy1oEsbFuJ+8f1z5uvtmn43KkwiQePVPVKDlPT9/CHWg== X-Received: by 2002:a17:906:2db1:: with SMTP id g17mr13034085eji.240.1575880877907; Mon, 09 Dec 2019 00:41:17 -0800 (PST) Received: from pi3 ([194.230.155.234]) by smtp.googlemail.com with ESMTPSA id f13sm703065edq.26.2019.12.09.00.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 00:41:17 -0800 (PST) Date: Mon, 9 Dec 2019 09:41:15 +0100 From: Krzysztof Kozlowski To: Hyunki Koo Cc: linux@armlinux.org.uk, kgene@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , kernel-team@android.com, Hyunki Koo Subject: Re: [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER Message-ID: <20191209084115.GA6375@pi3> References: <20191207130049.27533-1-hyunki00.koo@gmail.com> <20191207130049.27533-2-hyunki00.koo@gmail.com> <20191207132855.GA4384@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Sun, Dec 08, 2019 at 07:24:49AM +0900, Hyunki Koo wrote: > > On 19. 12. 7. 오후 10:37, Krzysztof Kozlowski wrote: > > On Sat, 7 Dec 2019 at 14:28, Krzysztof Kozlowski wrote: > > > On Sat, Dec 07, 2019 at 10:00:48PM +0900, Hyunki Koo wrote: > > > > From: Hyunki Koo > > > > > > > > Not all exynos device have IRQ_COMBINER. > > > > Thus add the config for EXYNOS_IRQ_COMBINER. > > > > > > > > Signed-off-by: Hyunki Koo > > > > --- > > > > drivers/irqchip/Kconfig | 7 +++++++ > > > > drivers/irqchip/Makefile | 2 +- > > > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > > > > Hi, > > > > > > There is no changelog and versioning of this patch so I do not > > > understand how it differs with previous. It's a resend? v2? It brings > > > the confusion and looks like you're ignoring previous comments. > > > > > > Looks the same and looks like breaking Exynos platforms in the same way. > > > > > > If you not want to skip combiner on ARMv8, it makes sense, then please > > > follow the approach we did for Pinctrl drivers (PINCTRL_EXYNOS_ARM and > > > PINCTRL_EXYNOS_ARM64). > > > > > > Best regards, > > > Krzysztof > > Ah, now I see the second patch. Still you break bisect which requires > > specific ordering of patches or squashing them into one. Optionally > > this could be default=y if ARCH_EXYNOS && ARM. I prefer just squashing > > both into one patch in this case. > > you mean squashing two files arch/arm/mach-exynos/Kconfig and > arch/arm/mach-exynos/Kconfig into one patch > > or squashing into only one file like blow? > > +config EXYNOS_IRQ_COMBINER > +       bool "Samsung Exynos IRQ combiner support" > +       depends on (ARCH_EXYNOS  && ARM) || COMPILE_TEST > +       default y > > I prefer first one (squashing two files into one patch) Squashing two patches into one. > > > > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > > > index ba152954324b..3ed7b7f2ae26 100644 > > > > --- a/drivers/irqchip/Kconfig > > > > +++ b/drivers/irqchip/Kconfig > > > > @@ -499,4 +499,11 @@ config SIFIVE_PLIC > > > > > > > > If you don't know what to do here, say Y. > > > > > > > > +config EXYNOS_IRQ_COMBINER > > > > + bool "Samsung Exynos IRQ combiner support" > > Now point it to be visible. Only for COMPILE_TEST Typo from my side. I wanted to say "No point" - this should not be selectable by user. > > > > > > + depends on ARCH_EXYNOS > > Since you make it a separate option, make it COMPILE_TEST. > > Is this  good ? Not entirely. The bool should be also with "if COMPILE TEST" so: config EXYNOS_IRQ_COMBINER bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST Best regards, Krzysztof