* [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY [not found] <CGME20191213083209eucas1p1459831639297fc7c37089c8fef4e0248@eucas1p1.samsung.com> @ 2019-12-13 8:31 ` Marek Szyprowski 2020-01-13 14:02 ` Marek Szyprowski 0 siblings, 1 reply; 5+ messages in thread From: Marek Szyprowski @ 2019-12-13 8:31 UTC (permalink / raw) To: linux-usb, linux-samsung-soc Cc: linux-kernel, Kishon Vijay Abraham I, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 646259bee909..f07edd80d2f3 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -714,7 +714,9 @@ static int exynos5_usbdrd_phy_calibrate(struct phy *phy) struct phy_usb_instance *inst = phy_get_drvdata(phy); struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); - return exynos5420_usbdrd_phy_calibrate(phy_drd); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) + return exynos5420_usbdrd_phy_calibrate(phy_drd); + return 0; } static const struct phy_ops exynos5_usbdrd_phy_ops = { -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY 2019-12-13 8:31 ` [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY Marek Szyprowski @ 2020-01-13 14:02 ` Marek Szyprowski 0 siblings, 0 replies; 5+ messages in thread From: Marek Szyprowski @ 2020-01-13 14:02 UTC (permalink / raw) To: linux-usb, linux-samsung-soc Cc: linux-kernel, Kishon Vijay Abraham I, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski On 13.12.2019 09:31, Marek Szyprowski wrote: > PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling > calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. > > Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> gentle ping > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c > index 646259bee909..f07edd80d2f3 100644 > --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c > +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c > @@ -714,7 +714,9 @@ static int exynos5_usbdrd_phy_calibrate(struct phy *phy) > struct phy_usb_instance *inst = phy_get_drvdata(phy); > struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); > > - return exynos5420_usbdrd_phy_calibrate(phy_drd); > + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) > + return exynos5420_usbdrd_phy_calibrate(phy_drd); > + return 0; > } > > static const struct phy_ops exynos5_usbdrd_phy_ops = { Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20200708133811eucas1p1df7b92d7e0ba512c5a7ecdb948edbfcf@eucas1p1.samsung.com>]
* [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY [not found] <CGME20200708133811eucas1p1df7b92d7e0ba512c5a7ecdb948edbfcf@eucas1p1.samsung.com> @ 2020-07-08 13:38 ` Marek Szyprowski 2020-07-08 13:47 ` Krzysztof Kozlowski 2020-07-13 5:13 ` Vinod Koul 0 siblings, 2 replies; 5+ messages in thread From: Marek Szyprowski @ 2020-07-08 13:38 UTC (permalink / raw) To: linux-usb, linux-samsung-soc Cc: linux-kernel, Vinod Koul, Kishon Vijay Abraham I, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 646259bee909..f07edd80d2f3 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -714,7 +714,9 @@ static int exynos5_usbdrd_phy_calibrate(struct phy *phy) struct phy_usb_instance *inst = phy_get_drvdata(phy); struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); - return exynos5420_usbdrd_phy_calibrate(phy_drd); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) + return exynos5420_usbdrd_phy_calibrate(phy_drd); + return 0; } static const struct phy_ops exynos5_usbdrd_phy_ops = { -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY 2020-07-08 13:38 ` Marek Szyprowski @ 2020-07-08 13:47 ` Krzysztof Kozlowski 2020-07-13 5:13 ` Vinod Koul 1 sibling, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2020-07-08 13:47 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-usb, linux-samsung-soc, linux-kernel, Vinod Koul, Kishon Vijay Abraham I, Bartlomiej Zolnierkiewicz On Wed, Jul 08, 2020 at 03:38:00PM +0200, Marek Szyprowski wrote: > PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling > calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. > > Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY 2020-07-08 13:38 ` Marek Szyprowski 2020-07-08 13:47 ` Krzysztof Kozlowski @ 2020-07-13 5:13 ` Vinod Koul 1 sibling, 0 replies; 5+ messages in thread From: Vinod Koul @ 2020-07-13 5:13 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-usb, linux-samsung-soc, linux-kernel, Kishon Vijay Abraham I, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski On 08-07-20, 15:38, Marek Szyprowski wrote: > PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling > calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY. Applied, thanks -- ~Vinod ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-13 5:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191213083209eucas1p1459831639297fc7c37089c8fef4e0248@eucas1p1.samsung.com>
2019-12-13 8:31 ` [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY Marek Szyprowski
2020-01-13 14:02 ` Marek Szyprowski
[not found] <CGME20200708133811eucas1p1df7b92d7e0ba512c5a7ecdb948edbfcf@eucas1p1.samsung.com>
2020-07-08 13:38 ` Marek Szyprowski
2020-07-08 13:47 ` Krzysztof Kozlowski
2020-07-13 5:13 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).