Linux-Samsung-soc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
@ 2019-12-24 21:11 Hyunki Koo
  2019-12-29 16:32 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Hyunki Koo @ 2019-12-24 21:11 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Hyunki Koo, Russell King, Kukjin Kim, Krzysztof Kozlowski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

From: Hyunki Koo <hyunki00.koo@samsung.com>

This patch is written to clean up dependency of ARCH_EXYNOS
Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
but it is built for all exynos devices.
Thus add the config for EXYNOS_IRQ_COMBINER
remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
and only selected on the aarch32 devices

Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
---
 arch/arm/mach-exynos/Kconfig | 1 +
 drivers/irqchip/Kconfig      | 7 +++++++
 drivers/irqchip/Makefile     | 2 +-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4ef56571145b..6e7f10c8098a 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -12,6 +12,7 @@ menuconfig ARCH_EXYNOS
 	select ARCH_SUPPORTS_BIG_ENDIAN
 	select ARM_AMBA
 	select ARM_GIC
+	select EXYNOS_IRQ_COMBINER
 	select COMMON_CLK_SAMSUNG
 	select EXYNOS_ASV
 	select EXYNOS_CHIPID
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index ba152954324b..4c774d85375b 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -499,4 +499,11 @@ config SIFIVE_PLIC
 
 	   If you don't know what to do here, say Y.
 
+config EXYNOS_IRQ_COMBINER
+	bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
+	depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
+	help
+	  Say yes here to add support for the IRQ combiner devices embedded
+	  in Samsung Exynos chips.
+
 endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index e806dda690ea..60d7c7260fc3 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835)		+= irq-bcm2835.o
 obj-$(CONFIG_ARCH_BCM2835)		+= irq-bcm2836.o
 obj-$(CONFIG_DAVINCI_AINTC)		+= irq-davinci-aintc.o
 obj-$(CONFIG_DAVINCI_CP_INTC)		+= irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS)		+= exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER)	+= exynos-combiner.o
 obj-$(CONFIG_FARADAY_FTINTC010)		+= irq-ftintc010.o
 obj-$(CONFIG_ARCH_HIP04)		+= irq-hip04.o
 obj-$(CONFIG_ARCH_LPC32XX)		+= irq-lpc32xx.o
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
  2019-12-24 21:11 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
@ 2019-12-29 16:32 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-29 16:32 UTC (permalink / raw)
  To: Hyunki Koo
  Cc: Hyunki Koo, Russell King, Kukjin Kim, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, linux-arm-kernel, linux-samsung-soc,
	linux-kernel

On Wed, Dec 25, 2019 at 06:11:07AM +0900, Hyunki Koo wrote:
> From: Hyunki Koo <hyunki00.koo@samsung.com>
> 
> This patch is written to clean up dependency of ARCH_EXYNOS
> Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
> but it is built for all exynos devices.
> Thus add the config for EXYNOS_IRQ_COMBINER
> remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
> and only selected on the aarch32 devices
> 
> Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> ---
>  arch/arm/mach-exynos/Kconfig | 1 +
>  drivers/irqchip/Kconfig      | 7 +++++++
>  drivers/irqchip/Makefile     | 2 +-
>  3 files changed, 9 insertions(+), 1 deletion(-)

I assume it will go through irqchip tree:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

If not, let me know, so I could take it via samsung-soc.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 21:11 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
2019-12-29 16:32 ` Krzysztof Kozlowski

Linux-Samsung-soc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-samsung-soc/0 linux-samsung-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-samsung-soc linux-samsung-soc/ https://lore.kernel.org/linux-samsung-soc \
		linux-samsung-soc@vger.kernel.org
	public-inbox-index linux-samsung-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-samsung-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git