* [PATCH 2/9] memory: jz4780_nemc: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-23 11:44 ` Paul Cercueil
2019-12-22 18:50 ` [PATCH 3/9] memory: mvebu-devbus: " Yangtao Li
` (6 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/jz4780-nemc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c
index b232ed279fc3..857a9fa5cba5 100644
--- a/drivers/memory/jz4780-nemc.c
+++ b/drivers/memory/jz4780-nemc.c
@@ -269,7 +269,6 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct jz4780_nemc *nemc;
- struct resource *res;
struct device_node *child;
const __be32 *prop;
unsigned int bank;
@@ -287,8 +286,7 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
spin_lock_init(&nemc->lock);
nemc->dev = dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- nemc->base = devm_ioremap_resource(dev, res);
+ nemc->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(nemc->base)) {
dev_err(dev, "failed to get I/O memory\n");
return PTR_ERR(nemc->base);
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/9] memory: jz4780_nemc: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 2/9] memory: jz4780_nemc: " Yangtao Li
@ 2019-12-23 11:44 ` Paul Cercueil
0 siblings, 0 replies; 16+ messages in thread
From: Paul Cercueil @ 2019-12-23 11:44 UTC (permalink / raw)
To: Yangtao Li
Cc: ssantosh, matthias.bgg, rogerq, tony, lukasz.luba, kgene, krzk,
thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Hi,
Le dim., déc. 22, 2019 at 18:50, Yangtao Li <tiny.windzz@gmail.com> a
écrit :
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/memory/jz4780-nemc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/jz4780-nemc.c
> b/drivers/memory/jz4780-nemc.c
> index b232ed279fc3..857a9fa5cba5 100644
> --- a/drivers/memory/jz4780-nemc.c
> +++ b/drivers/memory/jz4780-nemc.c
> @@ -269,7 +269,6 @@ static int jz4780_nemc_probe(struct
> platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct jz4780_nemc *nemc;
> - struct resource *res;
> struct device_node *child;
> const __be32 *prop;
> unsigned int bank;
> @@ -287,8 +286,7 @@ static int jz4780_nemc_probe(struct
> platform_device *pdev)
> spin_lock_init(&nemc->lock);
> nemc->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - nemc->base = devm_ioremap_resource(dev, res);
> + nemc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(nemc->base)) {
> dev_err(dev, "failed to get I/O memory\n");
> return PTR_ERR(nemc->base);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/9] memory: mvebu-devbus: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-22 18:50 ` [PATCH 2/9] memory: jz4780_nemc: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2020-01-08 9:41 ` Gregory CLEMENT
2019-12-22 18:50 ` [PATCH 4/9] memory: tegra: " Yangtao Li
` (5 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/mvebu-devbus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/mvebu-devbus.c b/drivers/memory/mvebu-devbus.c
index 095f8a3b2cfc..886aea587276 100644
--- a/drivers/memory/mvebu-devbus.c
+++ b/drivers/memory/mvebu-devbus.c
@@ -267,7 +267,6 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
struct devbus_read_params r;
struct devbus_write_params w;
struct devbus *devbus;
- struct resource *res;
struct clk *clk;
unsigned long rate;
int err;
@@ -277,8 +276,7 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
return -ENOMEM;
devbus->dev = dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- devbus->base = devm_ioremap_resource(&pdev->dev, res);
+ devbus->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(devbus->base))
return PTR_ERR(devbus->base);
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 3/9] memory: mvebu-devbus: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 3/9] memory: mvebu-devbus: " Yangtao Li
@ 2020-01-08 9:41 ` Gregory CLEMENT
0 siblings, 0 replies; 16+ messages in thread
From: Gregory CLEMENT @ 2020-01-08 9:41 UTC (permalink / raw)
To: Yangtao Li, ssantosh, paul, matthias.bgg, rogerq, tony,
lukasz.luba, kgene, krzk, thierry.reding, jonathanh, allison,
tglx, yong.wu, jroedel, evgreen, rfontana, digetx, pdeschrijver,
john, alexios.zavras, sboyd, kstewart, info, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-omap, linux-pm,
linux-samsung-soc, linux-tegra
Cc: Yangtao Li
Hi Yangtao Li,
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied on mvebu/drivers
Thanks,
Gregory
> ---
> drivers/memory/mvebu-devbus.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/mvebu-devbus.c b/drivers/memory/mvebu-devbus.c
> index 095f8a3b2cfc..886aea587276 100644
> --- a/drivers/memory/mvebu-devbus.c
> +++ b/drivers/memory/mvebu-devbus.c
> @@ -267,7 +267,6 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
> struct devbus_read_params r;
> struct devbus_write_params w;
> struct devbus *devbus;
> - struct resource *res;
> struct clk *clk;
> unsigned long rate;
> int err;
> @@ -277,8 +276,7 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> devbus->dev = dev;
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - devbus->base = devm_ioremap_resource(&pdev->dev, res);
> + devbus->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(devbus->base))
> return PTR_ERR(devbus->base);
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 4/9] memory: tegra: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-22 18:50 ` [PATCH 2/9] memory: jz4780_nemc: " Yangtao Li
2019-12-22 18:50 ` [PATCH 3/9] memory: mvebu-devbus: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-23 15:42 ` Dmitry Osipenko
2019-12-22 18:50 ` [PATCH 5/9] memory: fsl-corenet-cf: " Yangtao Li
` (4 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/tegra/mc.c | 4 +---
drivers/memory/tegra/tegra124-emc.c | 4 +---
drivers/memory/tegra/tegra186.c | 4 +---
drivers/memory/tegra/tegra20-emc.c | 4 +---
4 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index ec8403557ed4..71390d4ad809 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -593,7 +593,6 @@ static __maybe_unused irqreturn_t tegra20_mc_irq(int irq, void *data)
static int tegra_mc_probe(struct platform_device *pdev)
{
- struct resource *res;
struct tegra_mc *mc;
void *isr;
u64 mask;
@@ -619,8 +618,7 @@ static int tegra_mc_probe(struct platform_device *pdev)
/* length of MC tick in nanoseconds */
mc->tick = 30;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mc->regs = devm_ioremap_resource(&pdev->dev, res);
+ mc->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mc->regs))
return PTR_ERR(mc->regs);
diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
index 464f0ceaee63..2c73260654ba 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -1085,7 +1085,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
struct platform_device *mc;
struct device_node *np;
struct tegra_emc *emc;
- struct resource *res;
u32 ram_code;
int err;
@@ -1095,8 +1094,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
emc->dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- emc->regs = devm_ioremap_resource(&pdev->dev, res);
+ emc->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(emc->regs))
return PTR_ERR(emc->regs);
diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
index 441213a35930..226d2b16036d 100644
--- a/drivers/memory/tegra/tegra186.c
+++ b/drivers/memory/tegra/tegra186.c
@@ -534,7 +534,6 @@ static const struct tegra_mc_client tegra186_mc_clients[] = {
static int tegra186_mc_probe(struct platform_device *pdev)
{
- struct resource *res;
struct tegra_mc *mc;
unsigned int i;
int err = 0;
@@ -543,8 +542,7 @@ static int tegra186_mc_probe(struct platform_device *pdev)
if (!mc)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mc->regs = devm_ioremap_resource(&pdev->dev, res);
+ mc->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mc->regs))
return PTR_ERR(mc->regs);
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 1b23b1c34476..d2efd0c658c0 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -482,7 +482,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
{
struct device_node *np;
struct tegra_emc *emc;
- struct resource *res;
int irq, err;
/* driver has nothing to do in a case of memory timing absence */
@@ -518,8 +517,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
if (err)
return err;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- emc->regs = devm_ioremap_resource(&pdev->dev, res);
+ emc->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(emc->regs))
return PTR_ERR(emc->regs);
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 4/9] memory: tegra: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 4/9] memory: tegra: " Yangtao Li
@ 2019-12-23 15:42 ` Dmitry Osipenko
0 siblings, 0 replies; 16+ messages in thread
From: Dmitry Osipenko @ 2019-12-23 15:42 UTC (permalink / raw)
To: Yangtao Li, ssantosh, paul, matthias.bgg, rogerq, tony,
lukasz.luba, kgene, krzk, thierry.reding, jonathanh, allison,
tglx, yong.wu, jroedel, evgreen, rfontana, pdeschrijver, john,
alexios.zavras, sboyd, kstewart, info, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-omap, linux-pm,
linux-samsung-soc, linux-tegra
22.12.2019 21:50, Yangtao Li пишет:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/memory/tegra/mc.c | 4 +---
> drivers/memory/tegra/tegra124-emc.c | 4 +---
> drivers/memory/tegra/tegra186.c | 4 +---
> drivers/memory/tegra/tegra20-emc.c | 4 +---
> 4 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec8403557ed4..71390d4ad809 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -593,7 +593,6 @@ static __maybe_unused irqreturn_t tegra20_mc_irq(int irq, void *data)
>
> static int tegra_mc_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct tegra_mc *mc;
> void *isr;
> u64 mask;
> @@ -619,8 +618,7 @@ static int tegra_mc_probe(struct platform_device *pdev)
> /* length of MC tick in nanoseconds */
> mc->tick = 30;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mc->regs = devm_ioremap_resource(&pdev->dev, res);
> + mc->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mc->regs))
> return PTR_ERR(mc->regs);
>
> diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
> index 464f0ceaee63..2c73260654ba 100644
> --- a/drivers/memory/tegra/tegra124-emc.c
> +++ b/drivers/memory/tegra/tegra124-emc.c
> @@ -1085,7 +1085,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
> struct platform_device *mc;
> struct device_node *np;
> struct tegra_emc *emc;
> - struct resource *res;
> u32 ram_code;
> int err;
>
> @@ -1095,8 +1094,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
>
> emc->dev = &pdev->dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - emc->regs = devm_ioremap_resource(&pdev->dev, res);
> + emc->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(emc->regs))
> return PTR_ERR(emc->regs);
>
> diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
> index 441213a35930..226d2b16036d 100644
> --- a/drivers/memory/tegra/tegra186.c
> +++ b/drivers/memory/tegra/tegra186.c
> @@ -534,7 +534,6 @@ static const struct tegra_mc_client tegra186_mc_clients[] = {
>
> static int tegra186_mc_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct tegra_mc *mc;
> unsigned int i;
> int err = 0;
> @@ -543,8 +542,7 @@ static int tegra186_mc_probe(struct platform_device *pdev)
> if (!mc)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mc->regs = devm_ioremap_resource(&pdev->dev, res);
> + mc->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mc->regs))
> return PTR_ERR(mc->regs);
>
> diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> index 1b23b1c34476..d2efd0c658c0 100644
> --- a/drivers/memory/tegra/tegra20-emc.c
> +++ b/drivers/memory/tegra/tegra20-emc.c
> @@ -482,7 +482,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
> {
> struct device_node *np;
> struct tegra_emc *emc;
> - struct resource *res;
> int irq, err;
>
> /* driver has nothing to do in a case of memory timing absence */
> @@ -518,8 +517,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - emc->regs = devm_ioremap_resource(&pdev->dev, res);
> + emc->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(emc->regs))
> return PTR_ERR(emc->regs);
>
>
Looks good, thanks!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/9] memory: fsl-corenet-cf: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
` (2 preceding siblings ...)
2019-12-22 18:50 ` [PATCH 4/9] memory: tegra: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-22 18:50 ` [PATCH 6/9] memory: ti-aemif: " Yangtao Li
` (3 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/fsl-corenet-cf.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c
index 0b0ed72016da..2c62312ea513 100644
--- a/drivers/memory/fsl-corenet-cf.c
+++ b/drivers/memory/fsl-corenet-cf.c
@@ -172,7 +172,6 @@ static irqreturn_t ccf_irq(int irq, void *dev_id)
static int ccf_probe(struct platform_device *pdev)
{
struct ccf_private *ccf;
- struct resource *r;
const struct of_device_id *match;
u32 errinten;
int ret, irq;
@@ -185,13 +184,7 @@ static int ccf_probe(struct platform_device *pdev)
if (!ccf)
return -ENOMEM;
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!r) {
- dev_err(&pdev->dev, "%s: no mem resource\n", __func__);
- return -ENXIO;
- }
-
- ccf->regs = devm_ioremap_resource(&pdev->dev, r);
+ ccf->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ccf->regs)) {
dev_err(&pdev->dev, "%s: can't map mem resource\n", __func__);
return PTR_ERR(ccf->regs);
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6/9] memory: ti-aemif: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
` (3 preceding siblings ...)
2019-12-22 18:50 ` [PATCH 5/9] memory: fsl-corenet-cf: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-22 18:50 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Yangtao Li
` (2 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/ti-aemif.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c
index db526dbf71ee..6524229f634a 100644
--- a/drivers/memory/ti-aemif.c
+++ b/drivers/memory/ti-aemif.c
@@ -328,7 +328,6 @@ static int aemif_probe(struct platform_device *pdev)
{
int i;
int ret = -ENODEV;
- struct resource *res;
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct device_node *child_np;
@@ -362,8 +361,7 @@ static int aemif_probe(struct platform_device *pdev)
else if (pdata)
aemif->cs_offset = pdata->cs_offset;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- aemif->base = devm_ioremap_resource(dev, res);
+ aemif->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(aemif->base)) {
ret = PTR_ERR(aemif->base);
goto error;
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 7/9] memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
` (4 preceding siblings ...)
2019-12-22 18:50 ` [PATCH 6/9] memory: ti-aemif: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-30 9:13 ` Lukasz Luba
2019-12-30 17:56 ` Krzysztof Kozlowski
2019-12-22 18:50 ` [PATCH 8/9] memory: mtk-smi: " Yangtao Li
2019-12-22 18:50 ` [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq Yangtao Li
7 siblings, 2 replies; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 47dbf6d1789f..81a1b1d01683 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -1374,7 +1374,6 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct exynos5_dmc *dmc;
- struct resource *res;
int irq[2];
dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);
@@ -1386,13 +1385,11 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
dmc->dev = dev;
platform_set_drvdata(pdev, dmc);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- dmc->base_drexi0 = devm_ioremap_resource(dev, res);
+ dmc->base_drexi0 = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(dmc->base_drexi0))
return PTR_ERR(dmc->base_drexi0);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- dmc->base_drexi1 = devm_ioremap_resource(dev, res);
+ dmc->base_drexi1 = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(dmc->base_drexi1))
return PTR_ERR(dmc->base_drexi1);
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Yangtao Li
@ 2019-12-30 9:13 ` Lukasz Luba
2019-12-30 17:56 ` Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Lukasz Luba @ 2019-12-30 9:13 UTC (permalink / raw)
To: Yangtao Li, ssantosh, paul, matthias.bgg, rogerq, tony, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Hi,
On 12/22/19 6:50 PM, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 47dbf6d1789f..81a1b1d01683 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -1374,7 +1374,6 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> struct exynos5_dmc *dmc;
> - struct resource *res;
> int irq[2];
>
> dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);
> @@ -1386,13 +1385,11 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
> dmc->dev = dev;
> platform_set_drvdata(pdev, dmc);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dmc->base_drexi0 = devm_ioremap_resource(dev, res);
> + dmc->base_drexi0 = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dmc->base_drexi0))
> return PTR_ERR(dmc->base_drexi0);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - dmc->base_drexi1 = devm_ioremap_resource(dev, res);
> + dmc->base_drexi1 = devm_platform_ioremap_resource(pdev, 1);
> if (IS_ERR(dmc->base_drexi1))
> return PTR_ERR(dmc->base_drexi1);
>
>
Acked-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Yangtao Li
2019-12-30 9:13 ` Lukasz Luba
@ 2019-12-30 17:56 ` Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-30 17:56 UTC (permalink / raw)
To: Yangtao Li
Cc: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
On Sun, Dec 22, 2019 at 06:50:32PM +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 8/9] memory: mtk-smi: convert to devm_platform_ioremap_resource
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
` (5 preceding siblings ...)
2019-12-22 18:50 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-27 7:24 ` Yong Wu
2019-12-22 18:50 ` [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq Yangtao Li
7 siblings, 1 reply; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/mtk-smi.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index a113e811faab..1cc5d94036a2 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -269,7 +269,6 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = {
static int mtk_smi_larb_probe(struct platform_device *pdev)
{
struct mtk_smi_larb *larb;
- struct resource *res;
struct device *dev = &pdev->dev;
struct device_node *smi_node;
struct platform_device *smi_pdev;
@@ -279,8 +278,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
return -ENOMEM;
larb->larb_gen = of_device_get_match_data(dev);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- larb->base = devm_ioremap_resource(dev, res);
+ larb->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(larb->base))
return PTR_ERR(larb->base);
@@ -419,7 +417,6 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct mtk_smi *common;
- struct resource *res;
int ret;
common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
@@ -453,8 +450,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
* base.
*/
if (common->plat->gen == MTK_SMI_GEN1) {
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- common->smi_ao_base = devm_ioremap_resource(dev, res);
+ common->smi_ao_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(common->smi_ao_base))
return PTR_ERR(common->smi_ao_base);
@@ -466,8 +462,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
if (ret)
return ret;
} else {
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- common->base = devm_ioremap_resource(dev, res);
+ common->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(common->base))
return PTR_ERR(common->base);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 8/9] memory: mtk-smi: convert to devm_platform_ioremap_resource
2019-12-22 18:50 ` [PATCH 8/9] memory: mtk-smi: " Yangtao Li
@ 2019-12-27 7:24 ` Yong Wu
0 siblings, 0 replies; 16+ messages in thread
From: Yong Wu @ 2019-12-27 7:24 UTC (permalink / raw)
To: Yangtao Li
Cc: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, jroedel, evgreen,
rfontana, digetx, pdeschrijver, john, alexios.zavras, sboyd,
kstewart, info, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-omap, linux-pm, linux-samsung-soc, linux-tegra
On Sun, 2019-12-22 at 18:50 +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/memory/mtk-smi.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq
2019-12-22 18:50 [PATCH 1/9] memory: emif: convert to devm_platform_ioremap_resource Yangtao Li
` (6 preceding siblings ...)
2019-12-22 18:50 ` [PATCH 8/9] memory: mtk-smi: " Yangtao Li
@ 2019-12-22 18:50 ` Yangtao Li
2019-12-23 7:25 ` Roger Quadros
7 siblings, 1 reply; 16+ messages in thread
From: Yangtao Li @ 2019-12-22 18:50 UTC (permalink / raw)
To: ssantosh, paul, matthias.bgg, rogerq, tony, lukasz.luba, kgene,
krzk, thierry.reding, jonathanh, allison, tglx, yong.wu, jroedel,
evgreen, rfontana, digetx, pdeschrijver, john, alexios.zavras,
sboyd, kstewart, info, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-omap, linux-pm, linux-samsung-soc,
linux-tegra
Cc: Yangtao Li
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/omap-gpmc.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index eff26c1b1394..6dd19d168f75 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev)
if (IS_ERR(gpmc_base))
return PTR_ERR(gpmc_base);
- res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!res) {
- dev_err(&pdev->dev, "Failed to get resource: irq\n");
- return -ENOENT;
- }
-
- gpmc->irq = res->start;
+ gpmc->irq = platform_get_irq(pdev, 0);
+ if (gpmc->irq < 0)
+ return gpmc->irq;
gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck");
if (IS_ERR(gpmc_l3_clk)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq
2019-12-22 18:50 ` [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq Yangtao Li
@ 2019-12-23 7:25 ` Roger Quadros
0 siblings, 0 replies; 16+ messages in thread
From: Roger Quadros @ 2019-12-23 7:25 UTC (permalink / raw)
To: Yangtao Li, ssantosh, paul, matthias.bgg, tony, lukasz.luba,
kgene, krzk, thierry.reding, jonathanh, allison, tglx, yong.wu,
jroedel, evgreen, rfontana, digetx, pdeschrijver, john,
alexios.zavras, sboyd, kstewart, info, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-omap, linux-pm,
linux-samsung-soc, linux-tegra
On 22/12/2019 20:50, Yangtao Li wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/memory/omap-gpmc.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index eff26c1b1394..6dd19d168f75 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev)
> if (IS_ERR(gpmc_base))
> return PTR_ERR(gpmc_base);
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "Failed to get resource: irq\n");
> - return -ENOENT;
> - }
> -
> - gpmc->irq = res->start;
> + gpmc->irq = platform_get_irq(pdev, 0);
> + if (gpmc->irq < 0)
> + return gpmc->irq;
>
> gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck");
> if (IS_ERR(gpmc_l3_clk)) {
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 16+ messages in thread