Linux-Samsung-soc Archive on
 help / color / Atom feed
From: Dinghao Liu <>
Cc: Sylwester Nawrocki <>,
	Mauro Carvalho Chehab <>,,,
Subject: [PATCH] media: platform: s3c-camif: Fix runtime PM imbalance in s3c_camif_open
Date: Fri, 22 May 2020 16:29:15 +0800
Message-ID: <> (raw)

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Also, call pm_runtime_put() and v4l2_fh_release() when sensor_set_power()
returns an error code.

Signed-off-by: Dinghao Liu <>
 drivers/media/platform/s3c-camif/camif-capture.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c
index 9ca49af29542..d42d9cfaf674 100644
--- a/drivers/media/platform/s3c-camif/camif-capture.c
+++ b/drivers/media/platform/s3c-camif/camif-capture.c
@@ -552,11 +552,9 @@ static int s3c_camif_open(struct file *file)
 		goto err_pm;
 	ret = sensor_set_power(camif, 1);
-	if (!ret)
-		goto unlock;
-	pm_runtime_put(camif->dev);
+	pm_runtime_put(camif->dev);

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Samsung-soc Archive on

Archives are clonable:
	git clone --mirror linux-samsung-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-samsung-soc linux-samsung-soc/ \
	public-inbox-index linux-samsung-soc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone