linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alim Akhtar <alim.akhtar@samsung.com>
To: robh@kernel.org
Cc: devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
	krzk@kernel.org, avri.altman@wdc.com, martin.petersen@oracle.com,
	kwmad.kim@samsung.com, stanley.chu@mediatek.com,
	cang@codeaurora.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kishon@ti.com,
	Alim Akhtar <alim.akhtar@samsung.com>
Subject: [RESEND PATCH v10 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error
Date: Sat, 13 Jun 2020 08:17:01 +0530	[thread overview]
Message-ID: <20200613024706.27975-6-alim.akhtar@samsung.com> (raw)
In-Reply-To: <20200613024706.27975-1-alim.akhtar@samsung.com>

From: Kiwoong Kim <kwmad.kim@samsung.com>

Some controller like Exynos determines if FATAL ERROR (0x7)
in OCS field in UTRD occurs for values other than GOOD (0x0)
in STATUS field in response upiu as well as errors that a
host controller can't cover.
This patch is to prevent from reporting command results in
those cases.

Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/scsi/ufs/ufshcd.c | 6 ++++++
 drivers/scsi/ufs/ufshcd.h | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index ba093d0d0942..33ebffa8257d 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4794,6 +4794,12 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 	/* overall command status of utrd */
 	ocs = ufshcd_get_tr_ocs(lrbp);
 
+	if (hba->quirks & UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR) {
+		if (be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_1) &
+					MASK_RSP_UPIU_RESULT)
+			ocs = OCS_SUCCESS;
+	}
+
 	switch (ocs) {
 	case OCS_SUCCESS:
 		result = ufshcd_get_req_rsp(lrbp->ucd_rsp_ptr);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index a9b9ace9fc72..e1d09c2c4302 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -541,6 +541,12 @@ enum ufshcd_quirks {
 	 * resolution of the values of PRDTO and PRDTL in UTRD as byte.
 	 */
 	UFSHCD_QUIRK_PRDT_BYTE_GRAN			= 1 << 9,
+
+	/*
+	 * This quirk needs to be enabled if the host controller reports
+	 * OCS FATAL ERROR with device error through sense data
+	 */
+	UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR		= 1 << 10,
 };
 
 enum ufshcd_caps {
-- 
2.17.1


  parent reply	other threads:[~2020-06-13  3:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200613030436epcas5p38137bcaddd80ec5eed746a80a1fe31f5@epcas5p3.samsung.com>
2020-06-13  2:46 ` [RESEND PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
     [not found]   ` <CGME20200613030438epcas5p337ed074612a2a1e8b4d6ecb3dda30b5c@epcas5p3.samsung.com>
2020-06-13  2:46     ` [RESEND PATCH v10 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
     [not found]   ` <CGME20200613030440epcas5p121247d520b30ddca1a31b2d57bfc6b91@epcas5p1.samsung.com>
2020-06-13  2:46     ` [RESEND PATCH v10 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar
     [not found]   ` <CGME20200613030443epcas5p3596ed8c2f56f3aa6bee7d72cb104363a@epcas5p3.samsung.com>
2020-06-13  2:46     ` [RESEND PATCH v10 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
     [not found]   ` <CGME20200613030445epcas5p4428da322cd9527d1075ff0f1ccc75d23@epcas5p4.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar
2020-08-12  0:29       ` Eric Biggers
2020-08-13  1:21         ` Alim Akhtar
2020-08-13  1:25           ` Eric Biggers
     [not found]   ` <CGME20200613030447epcas5p4ef2db2121851bdd251d2fd19b3532bb1@epcas5p4.samsung.com>
2020-06-13  2:47     ` Alim Akhtar [this message]
     [not found]   ` <CGME20200613030449epcas5p3cb1139c47ed1c9055c22facf2f5a933b@epcas5p3.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
     [not found]   ` <CGME20200613030451epcas5p101ab5aa635668f68b88f302c25b32a6d@epcas5p1.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
2020-06-13  4:40       ` kernel test robot
     [not found]       ` <CGME20200613052521epcas5p140d979df19fae20c858c485409596a7a@epcas5p1.samsung.com>
     [not found]         ` <202006131334.EEnoEaXS%lkp@intel.com>
2020-06-15 16:24           ` Alim Akhtar
     [not found]   ` <CGME20200613030454epcas5p400f76485ddb34ce6293f0c8fa94332b8@epcas5p4.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 08/10] dt-bindings: ufs: Add bindings for Samsung ufs host Alim Akhtar
2021-07-13  7:05       ` Alim Akhtar
2021-07-13 12:45         ` Krzysztof Kozlowski
2021-07-13 23:34           ` Chanho Park
2021-07-19  2:07             ` Martin K. Petersen
2021-07-19  3:02               ` Chanho Park
     [not found]   ` <CGME20200613030456epcas5p2e8c8518fbff9bac830c2a5ffec6109d7@epcas5p2.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
     [not found]   ` <CGME20200613030458epcas5p3f9667bab202d99fb332d5bf5aad63c85@epcas5p3.samsung.com>
2020-06-13  2:47     ` [RESEND PATCH v10 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-06-14 11:02       ` Krzysztof Kozlowski
2020-06-15 16:15         ` Alim Akhtar
2020-06-16  3:59   ` [RESEND PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200613024706.27975-6-alim.akhtar@samsung.com \
    --to=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=krzk@kernel.org \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robh@kernel.org \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).