Linux-Samsung-soc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1 1/2] arm64: dts: exynos: Fix silent hang after boot
       [not found] <CGME20200705072937epcas5p1b6c9a25770451bcb9d8bc5b14b8a8b53@epcas5p1.samsung.com>
@ 2020-07-05  7:09 ` Alim Akhtar
       [not found]   ` <CGME20200705072938epcas5p479f0d040ca34fd44b2ba893a199efb79@epcas5p4.samsung.com>
  0 siblings, 1 reply; 5+ messages in thread
From: Alim Akhtar @ 2020-07-05  7:09 UTC (permalink / raw)
  To: krzk
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	robh+dt, Alim Akhtar

Once regulators are disabled after kernel boot, on espresso
board silent hang observed because of LDO7 being disabled.
LDO7 actually provide power to CPU cores and non-cpu blocks
circuitries.
Keep this regulator always-on to fix this hang.

Fixes: 9589f7721e16 ("arm64: dts: Add S2MPS15 PMIC node on exynos7-espresso")
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 - 
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index 790f12ca8981..bb86950032d3 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -157,6 +157,7 @@
 				regulator-min-microvolt = <700000>;
 				regulator-max-microvolt = <1150000>;
 				regulator-enable-ramp-delay = <125>;
+				regulator-always-on;
 			};
 
 			ldo8_reg: LDO8 {

base-commit: 9e50b94b3eb0d859a2586b5a40d7fd6e5afd9210
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
       [not found]   ` <CGME20200705072938epcas5p479f0d040ca34fd44b2ba893a199efb79@epcas5p4.samsung.com>
@ 2020-07-05  7:09     ` Alim Akhtar
  2020-07-05 18:23       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Alim Akhtar @ 2020-07-05  7:09 UTC (permalink / raw)
  To: krzk
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	robh+dt, Alim Akhtar

LDO12 on exynos7 supply power to VDDQ_UFS20_RESET,
in case this regulator is OFF, UFS host controller
can not send command to UFS device. To keep this supply
ON, set regulator-always-on property for this ldo.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index bb86950032d3..92fecc539c6c 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -194,6 +194,7 @@
 				regulator-min-microvolt = <1000000>;
 				regulator-max-microvolt = <1300000>;
 				regulator-enable-ramp-delay = <125>;
+				regulator-always-on;
 			};
 
 			ldo13_reg: LDO13 {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
  2020-07-05  7:09     ` [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on Alim Akhtar
@ 2020-07-05 18:23       ` Krzysztof Kozlowski
  2020-07-06 15:53         ` Alim Akhtar
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-05 18:23 UTC (permalink / raw)
  To: Alim Akhtar
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel, robh+dt

On Sun, Jul 05, 2020 at 12:39:18PM +0530, Alim Akhtar wrote:
> LDO12 on exynos7 supply power to VDDQ_UFS20_RESET,
> in case this regulator is OFF, UFS host controller
> can not send command to UFS device. To keep this supply
> ON, set regulator-always-on property for this ldo.

Why UFS does not take any supplies? This looks like a workaround for the
case of not implementing any consumer.

Best regards,
Krzysztof


> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index bb86950032d3..92fecc539c6c 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -194,6 +194,7 @@
>  				regulator-min-microvolt = <1000000>;
>  				regulator-max-microvolt = <1300000>;
>  				regulator-enable-ramp-delay = <125>;
> +				regulator-always-on;
>  			};
>  
>  			ldo13_reg: LDO13 {
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
  2020-07-05 18:23       ` Krzysztof Kozlowski
@ 2020-07-06 15:53         ` Alim Akhtar
  2020-07-07  6:40           ` 'Krzysztof Kozlowski'
  0 siblings, 1 reply; 5+ messages in thread
From: Alim Akhtar @ 2020-07-06 15:53 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski'
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel, robh+dt

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 05 July 2020 23:53
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> robh+dt@kernel.org
> Subject: Re: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
> 
> On Sun, Jul 05, 2020 at 12:39:18PM +0530, Alim Akhtar wrote:
> > LDO12 on exynos7 supply power to VDDQ_UFS20_RESET, in case this
> > regulator is OFF, UFS host controller can not send command to UFS
> > device. To keep this supply ON, set regulator-always-on property for
> > this ldo.
> 
> Why UFS does not take any supplies? This looks like a workaround for the case
> of not implementing any consumer.
> 
This particular supply is not part of UFS HCI spec and binding documentation, as per binding only one supply for host controller and three others for UFS device are needed. My best guess is, VDDQ_UFS20_RESET supply to reset logic block inside HCI, which might be specific to this controller version (I did not find any such supply in the latest host controller though).

> Best regards,
> Krzysztof
> 
> 
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> >  arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > index bb86950032d3..92fecc539c6c 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > @@ -194,6 +194,7 @@
> >  				regulator-min-microvolt = <1000000>;
> >  				regulator-max-microvolt = <1300000>;
> >  				regulator-enable-ramp-delay = <125>;
> > +				regulator-always-on;
> >  			};
> >
> >  			ldo13_reg: LDO13 {
> > --
> > 2.17.1
> >


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
  2020-07-06 15:53         ` Alim Akhtar
@ 2020-07-07  6:40           ` 'Krzysztof Kozlowski'
  0 siblings, 0 replies; 5+ messages in thread
From: 'Krzysztof Kozlowski' @ 2020-07-07  6:40 UTC (permalink / raw)
  To: Alim Akhtar
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel, robh+dt

On Mon, Jul 06, 2020 at 09:23:49PM +0530, Alim Akhtar wrote:
> Hi Krzysztof,
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 05 July 2020 23:53
> > To: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> > robh+dt@kernel.org
> > Subject: Re: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
> > 
> > On Sun, Jul 05, 2020 at 12:39:18PM +0530, Alim Akhtar wrote:
> > > LDO12 on exynos7 supply power to VDDQ_UFS20_RESET, in case this
> > > regulator is OFF, UFS host controller can not send command to UFS
> > > device. To keep this supply ON, set regulator-always-on property for
> > > this ldo.
> > 
> > Why UFS does not take any supplies? This looks like a workaround for the case
> > of not implementing any consumer.
> > 
> This particular supply is not part of UFS HCI spec and binding documentation, as per binding only one supply for host controller and three others for UFS device are needed. My best guess is, VDDQ_UFS20_RESET supply to reset logic block inside HCI, which might be specific to this controller version (I did not find any such supply in the latest host controller though).

The bindings specific to Exynos7 UFS are then incomplete.  Anyway it's
nothing worth revisiting so I applied both patches.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200705072937epcas5p1b6c9a25770451bcb9d8bc5b14b8a8b53@epcas5p1.samsung.com>
2020-07-05  7:09 ` [PATCH v1 1/2] arm64: dts: exynos: Fix silent hang after boot Alim Akhtar
     [not found]   ` <CGME20200705072938epcas5p479f0d040ca34fd44b2ba893a199efb79@epcas5p4.samsung.com>
2020-07-05  7:09     ` [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on Alim Akhtar
2020-07-05 18:23       ` Krzysztof Kozlowski
2020-07-06 15:53         ` Alim Akhtar
2020-07-07  6:40           ` 'Krzysztof Kozlowski'

Linux-Samsung-soc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-samsung-soc/0 linux-samsung-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-samsung-soc linux-samsung-soc/ https://lore.kernel.org/linux-samsung-soc \
		linux-samsung-soc@vger.kernel.org
	public-inbox-index linux-samsung-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-samsung-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git