From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3] phy: samsung: Use readl_poll_timeout function
Date: Wed, 8 Jul 2020 14:31:26 +0200 [thread overview]
Message-ID: <20200708123126.GA29033@kozik-lap> (raw)
In-Reply-To: <CANAwSgQ_LXx=oHuu1dcHBZqo0zr-mHYWKnVPFJn+_G44JRarPA@mail.gmail.com>
On Wed, Jul 08, 2020 at 01:59:46PM +0530, Anand Moon wrote:
> > Still you did not mention that you convert the function to use sleeping
> > primitive. You also did not mention whether it is actually allowed in
> > this context and I am not sure if you investigated it.
> >
> OK, I am not sure how to resolve your query.
> I learned some new things.
>
> So here are some points.
> -- Yes read_poll_timeout internally used might_sleep if sleep_us != 0
> under some condition.
> -- None of the code in phy-exynos5-usbdrd.c is called using kernel
> synchronization
> methods like spinlock / mutex.
More important is rather the call to calibrare() as this is the place
where affected code is used.
It is not only about synchronisation primitives used in the driver but
also in the phy core. I guess there should not be a problem. I just
stated the fact that you did not mention anything about it.
> -- I have checked this function is called non atomic context.
Great!
Best regards,
Krzysztof
prev parent reply other threads:[~2020-07-08 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:59 [PATCH v3] phy: samsung: Use readl_poll_timeout function Anand Moon
2020-07-07 11:36 ` Krzysztof Kozlowski
2020-07-08 8:29 ` Anand Moon
2020-07-08 12:31 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708123126.GA29033@kozik-lap \
--to=krzk@kernel.org \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).