From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975FFC433E3 for ; Mon, 3 Aug 2020 02:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B633207FB for ; Mon, 3 Aug 2020 02:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596420115; bh=csMPgTESK/931j1qG9MTrwDhZCVihaWAMQqTAqfKW5M=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=IAr8FX++W6TLErtCE/RPbjnoxp3g7KFHXLdy4GueYHyIbRISQwt46YrGm3uMgLdee bXZ9MnFgigqxkcN5mnUtexFv6xUcUXR2zVyrJNSq0ZQIakjLW/vBPpfEOhzAWlCa/v XTugHd7XpMx0dXVujt9dXMJOfQXOvFddOmmk4xxY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725840AbgHCCBy (ORCPT ); Sun, 2 Aug 2020 22:01:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:44006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgHCCBy (ORCPT ); Sun, 2 Aug 2020 22:01:54 -0400 Received: from localhost (mobile-166-175-186-42.mycingular.net [166.175.186.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFC3E206F6; Mon, 3 Aug 2020 02:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596420113; bh=csMPgTESK/931j1qG9MTrwDhZCVihaWAMQqTAqfKW5M=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nyW5nORSo5AtXim4lBz+2DzUBjRfuE320k9hfbNcGttTulZKBCWQoOXThtYwq7rjm +NaG3GTmr6LRKqkBym0sSCMo1r7L1VApW8ABtHbKv/yrrUTQHXn0QhEP38Hrcd876z DFuz1+WsHOhnHgx+wZ7POJRqpoNccEWEgoInOQKU= Date: Sun, 2 Aug 2020 21:01:51 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Bjorn Helgaas , Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan , Shawn Lin , Heiko Stuebner , linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, rfi@lists.rocketboards.org Subject: Re: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Message-ID: <20200803020151.GA291575@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200802142601.1635926-1-kw@linux.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Sun, Aug 02, 2020 at 02:25:52PM +0000, Krzysztof Wilczyński wrote: > At the moment a lot of error handling code would print a duplicated > error message should either the platform_get_irq() or > platform_get_irq_byname() function fails to obtain an IRQ for a device. > > There is no need to call the dev_err() function directly to print > a custom message when handling an error from either of these functions > as both are going to display an appropriate error message in case of > a failure. > > This series aims to remove surplus call to dev_err() when handing an > error originating from either platform_get_irq() or > platform_get_irq_byname() function as per suggestion from Coccinelle. > > Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an > error message to platform_get_irq*()") and commit 98051ba2b28b > ("coccinelle: Add script to check for platform_get_irq() excessive > prints"). > > Krzysztof Wilczyński (10): > PCI: dwc: Remove dev_err() when handing an error from > platform_get_irq() > PCI: mobiveil: Remove dev_err() when handing an error from > platform_get_irq() > PCI: tegra: Remove dev_err() when handing an error from > platform_get_irq() > PCI: altera: Remove dev_err() when handing an error from > platform_get_irq() > PCI: host-generic: Remove dev_err() when handing an error from > platform_get_irq() > PCI: v3-semi: Remove dev_err() when handing an error from > platform_get_irq() > PCI: altera-msi: Remove dev_err() when handing an error from > platform_get_irq() > PCI: xgene-msi: Remove dev_err() when handing an error from > platform_get_irq() > PCI: rockchip: Remove dev_err() when handing an error from > platform_get_irq() > PCI: xilinx-nwl: Remove dev_err() when handing an error from > platform_get_irq() > > drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ > drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ > drivers/pci/controller/dwc/pci-imx6.c | 4 +--- > drivers/pci/controller/dwc/pci-keystone.c | 4 +--- > drivers/pci/controller/dwc/pci-meson.c | 4 +--- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- > drivers/pci/controller/dwc/pcie-histb.c | 4 +--- > drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- > drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- > drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- > .../pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 ++--- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 4 +--- > drivers/pci/controller/pci-tegra.c | 8 ++------ > drivers/pci/controller/pci-v3-semi.c | 5 ++--- > drivers/pci/controller/pci-xgene-msi.c | 2 -- > drivers/pci/controller/pcie-altera-msi.c | 1 - > drivers/pci/controller/pcie-altera.c | 4 +--- > drivers/pci/controller/pcie-rockchip-host.c | 12 +++--------- > drivers/pci/controller/pcie-tango.c | 4 +--- > drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- > 21 files changed, 29 insertions(+), 82 deletions(-) I squashed these together and applied them to pci/irq-error for v5.9, thanks! The cover letter claims there should be 10 patches, but I only got 9. Just FYI.