linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Lee Jones <lee.jones@linaro.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	alsa-devel@alsa-project.org,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
Date: Wed, 16 Sep 2020 09:59:07 +0200	[thread overview]
Message-ID: <20200916075907.GA10270@kozik-lap> (raw)
In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com>

On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote:
> 
> On 31.08.2020 14:50, Marek Szyprowski wrote:
> > Hi Krzysztof,
> >
> > On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> >> The USB-C connector bindings require port@0.  Such port was already
> >> described in DTS but outside of the connector itself.  Put it into
> >> proper place to fix dtbs_check warnings like:
> >>
> >>     arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > I'm not sure if topic should be about USB-C, I will call it simply USB
> > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector,
> > which has nothing in common with USB Type-C.
> >
> > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation,
> > so something has to be somehow adjusted or fixed. Added CC Andrzej
> > Hajda, who actually worked on this.
> >
> >> ---
> >>
> >> Not tested on HQ. Please kindly review and test.
> >>
> >> Best regards,
> >> Krzysztof
> >> ---
> >>    .../boot/dts/exynos/exynos5433-tm2-common.dtsi    | 15 +++++++--------
> >>    1 file changed, 7 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> index 6246cce2a15e..bab6c1addd5f 100644
> >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> @@ -871,6 +871,13 @@
> >>    					#address-cells = <1>;
> >>    					#size-cells = <0>;
> >>    
> >> +					port@0 {
> >> +						reg = <0>;
> >> +						muic_to_usb: endpoint {
> >> +							remote-endpoint = <&usb_to_muic>;
> >> +						};
> >> +					};
> >> +
> 
> 
> According to not-yet-yaml documentation of dt-bindings (patch 05/10):
> > -Required nodes:
> > -- any data bus to the connector should be modeled using the OF graph bindings
> > -  specified in bindings/graph.txt, unless the bus is between parent node and
> > -  the connector.
> 
> This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary.
> 
> 
> >>    					port@3 {
> >>    						reg = <3>;
> >>    						musb_con_to_mhl: endpoint {
> >> @@ -879,14 +886,6 @@
> >>    					};
> >>    				};
> >>    			};
> >> -
> >> -			ports {
> >> -				port {
> >> -					muic_to_usb: endpoint {
> >> -						remote-endpoint = <&usb_to_muic>;
> >> -					};
> >> -				};
> 
> 
> And this port belongs to MUIC - it describes connection between USB-HOST 
> and MUIC, it has nothing to do with the connector, and is necessary.

Thanks for checking this. It's really appreciated!

I'll work on v2 later to address the schema warning, hopefully without
breaking things...

Best regards,
Krzysztof


  reply	other threads:[~2020-09-16  7:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200829142522eucas1p2ecc9517be9060d7291b27deba1be8fe4@eucas1p2.samsung.com>
2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
2020-08-31 12:15     ` Sylwester Nawrocki
2020-09-03 16:42     ` Rob Herring
2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
2020-08-31 12:16     ` Sylwester Nawrocki
2020-09-03 16:42     ` Rob Herring
2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
2020-08-31 12:30     ` Sylwester Nawrocki
2020-08-31 12:34       ` Krzysztof Kozlowski
2020-09-02 16:06     ` Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
2020-09-14 18:15     ` Rob Herring
2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-31 12:31     ` Sylwester Nawrocki
2020-09-01 11:02     ` Mark Brown
2020-09-03 16:43     ` Rob Herring
2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
2020-08-31 12:52     ` Marek Szyprowski
2020-08-31 12:58     ` Sylwester Nawrocki
2020-09-01 10:12     ` Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
2020-08-31 13:00     ` Sylwester Nawrocki
2020-09-01 10:13     ` Krzysztof Kozlowski
2020-08-29 14:25   ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
2020-08-31 12:50     ` Marek Szyprowski
2020-09-02 11:23       ` Andrzej Hajda
2020-09-16  7:59         ` Krzysztof Kozlowski [this message]
2020-08-29 14:25   ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
2020-08-31 13:11     ` Marek Szyprowski
2020-08-31 13:49       ` Krzysztof Kozlowski
2020-08-31 12:14   ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Sylwester Nawrocki
2020-09-01 10:11   ` Krzysztof Kozlowski
2020-09-01 14:50   ` Mark Brown
2020-09-03 16:45     ` Rob Herring
2020-09-03 16:41   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916075907.GA10270@kozik-lap \
    --to=krzk@kernel.org \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kgene@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=snawrocki@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).