From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF27C388F7 for ; Thu, 29 Oct 2020 00:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD173207DE for ; Thu, 29 Oct 2020 00:18:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="orPttfCJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725826AbgJ2ASu (ORCPT ); Wed, 28 Oct 2020 20:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731856AbgJ1Wpu (ORCPT ); Wed, 28 Oct 2020 18:45:50 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB238C0613CF for ; Wed, 28 Oct 2020 15:45:50 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id y186so1294272oia.3 for ; Wed, 28 Oct 2020 15:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KfnjVkSYavUZpAOuFxYL10A68Gk+riZcuOkpLm+UKsQ=; b=orPttfCJNvUzyey7uOGV6qbycVKTL/tawKuMW0R4tXOU76W3N/0abqCNmDOmSmvRKN L2JU10SN8to5CTiFxG5wFlRZ+x6UlUgMbOG7N/pua3fxvZBZCJS+EYHvE8FzLHr3047a IusQdNKndPmJTL/Pn2PASNVNzQizL4HKrr9h8Sa4s9vTWSzUv1vWxJlLWL7qBwiNZZH0 NL3jimF1eAupDw4lp9obwTBpfo4tAMxacCG2xG9Ai03ir7HEjMODGsb6q1L4ESlUir48 MW4RzbQapeOS637/B5YLbaa26ZNLRjDyIkCnrRdrCVaqLf/6SiGLh23zR+zTIGWZ/xQI LDIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KfnjVkSYavUZpAOuFxYL10A68Gk+riZcuOkpLm+UKsQ=; b=Qk9fD8npGHPlJa/uRmMvnOJpvLisgpGIZ3DwuMUMTlP+pzzNr3KGreSicAOQYuo6/g xi8aXHTypiEQgAAoNXvE+AhuMNanxOxv8OBx6fnHZoGOnwuvr/VCcgDqSlhdCTq9Jgp/ wjayaoTj6jY3Ft/wLoqunFQSMyKVB9cJA2d76YyzDGAn8xpxDE6dZKf17t7ZvXcm8dXU ZW7GXWU26lE3J8l2+xzuzhkHEf+QKGmdcQdnwTqNTZ4JY3191x58zQrCMVrCEhfT33av Plf22nUhsdeb5G47dinndtOKCJxgHXbAzaRe1maDcATi6USgI261LF3h8yQoMgEMXgsv mtPA== X-Gm-Message-State: AOAM530A2/95s+qA80EE5m31FcgeVDKOqnriqZ9eHh3mkHsEfQ1ymhvb TFZHdTznfbLPw6SPhQHW0J+NJ3xScvRkFg== X-Google-Smtp-Source: ABdhPJyMbjsKNL+0AaYE+74jjeyJZn6dVKEnUKfModkHmF8ww8t+Tpr9o99iUojODmy3PW8gk7wIdw== X-Received: by 2002:a17:90a:2c41:: with SMTP id p1mr4749376pjm.129.1603857999683; Tue, 27 Oct 2020 21:06:39 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id q35sm3548111pja.28.2020.10.27.21.06.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 21:06:38 -0700 (PDT) Date: Wed, 28 Oct 2020 09:36:37 +0530 From: Viresh Kumar To: Guenter Roeck Cc: ulf.hansson@linaro.org, "Rafael J. Wysocki" , Kevin Hilman , Pavel Machek , Len Brown , Greg Kroah-Hartman , Viresh Kumar , Nishanth Menon , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Vincent Guittot , Stephan Gerhold , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nks@flawful.org, georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201028040637.26kw2qk7digel6yb@vireshk-i7> References: <24ff92dd1b0ee1b802b45698520f2937418f8094.1598260050.git.viresh.kumar@linaro.org> <20201027222428.GA125472@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027222428.GA125472@roeck-us.net> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 27-10-20, 15:24, Guenter Roeck wrote: > Trying again through different e-mail provider. My previous e-mail > got stuck in spam filters. Apologies if this is received multiple > times. I received only once :) > On Mon, Aug 24, 2020 at 02:39:32PM +0530, Viresh Kumar wrote: > > From: Stephan Gerhold > > > [ ... ] You removed way too much and this lost the context. Keeping the routine's prototype line would have been useful. > > > > opp_table = dev_pm_opp_get_opp_table(dev); > > - if (!opp_table) > > - return ERR_PTR(-ENOMEM); > > + if (!IS_ERR(opp_table)) > > + return opp_table; > > This should have been > > if (IS_ERR(opp_table)) > return opp_table; I believe this is the delta from dev_pm_opp_register_set_opp_helper() ? A proper fix is already pushed in linux-next for this yesterday. -- viresh