From: Martin Juecker <martin.juecker@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards
Date: Thu, 29 Oct 2020 22:40:30 +0100 [thread overview]
Message-ID: <20201029214030.GA72802@adroid> (raw)
In-Reply-To: <20201027081751.GA4244@kozik-lap>
On Tue, Oct 27, 2020 at 09:17:51AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Oct 27, 2020 at 12:27:09AM +0100, Martin Juecker wrote:
> > > > +
> > > > + max77686: max77686_pmic@9 {
> > > > + compatible = "maxim,max77686";
> > > > + interrupt-parent = <&gpx0>;
> > > > + interrupts = <7 IRQ_TYPE_NONE>;
> > > > + pinctrl-0 = <&max77686_irq>;
> > > > + pinctrl-names = "default";
> > > > + reg = <0x09>;
> > > > + #clock-cells = <1>;
> > > > +
> > > > + voltage-regulators {
> > >
> > > Just "regulators" and no empty line after this.
> > >
> > > You should define all regulators here. If some are unknown, keep the
> > > min-max the same as in driver.
> > >
> >
> > I used the driver to read all the voltages, it also reads values for
> > the LDOs that are not defined in the DT, so I have values for all of
> > them setup by the bootloader. What I don't know is their name and what
> > they are used for. Interestingly apart from two LDOs, the voltages did
> > match exactly with those from the midas DT, so it could be very
> > similar. The two non-matching were only off by 0.1V. How should I go
> > about this?
>
> Actually, let's skip the constraints (min-max) for unknown regulators.
> Just add the entries with generic names, like:
> arch/arm/boot/dts/exynos5410-odroidxu.dts
>
> I would not put here min-max constraints from bootloader because pretty
> often it has only an initial setup for specific frequency - just to make
> it booting.
>
> If you have the constraints (min-max, always on) from vendor sources,
> you could add them.
>
> Best regards,
> Krzysztof
As all the missing regulators are not defined in the vendor sources, I
have no constraints to work with.
What I noticed when all the LDOs are defined, the device reboot
behaviour is different. Instead of the usual 1-2 seconds for screen off
and on again, it's now more like 10 seconds.
Cheers
Martin
next prev parent reply other threads:[~2020-10-29 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 14:44 [PATCH 0/5] add exynos4412-based p4note device family support Martin Jücker
2020-10-24 14:44 ` [PATCH 1/5] dt-bindings: samsung: document bindings for p4note family boards Martin Jücker
2020-10-30 18:28 ` Rob Herring
2020-10-24 14:44 ` [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Martin Jücker
2020-10-26 11:55 ` Marek Szyprowski
2020-10-26 14:48 ` Krzysztof Kozlowski
2020-10-26 16:00 ` Krzysztof Kozlowski
2020-10-26 23:27 ` Martin Juecker
2020-10-27 8:17 ` Krzysztof Kozlowski
2020-10-29 21:40 ` Martin Juecker [this message]
2020-10-30 7:41 ` Marek Szyprowski
2020-10-24 14:44 ` [PATCH 3/5] ARM: defconfig: add stmpe adc driver for p4note Martin Jücker
2020-10-24 14:44 ` [PATCH 4/5] ARM: defconfig: compile Atmel MXT touchscreeen as module Martin Jücker
2020-10-24 14:44 ` [PATCH 5/5] ARM: exynos: extend cpuidle support to p4note boards Martin Jücker
2020-10-31 17:58 [PATCH v2 0/5] add exynos4412-based p4note device family support Martin Jücker
2020-10-31 17:58 ` [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Martin Jücker
2020-11-02 19:18 ` Krzysztof Kozlowski
2020-11-02 21:21 ` Martin Juecker
2020-11-03 7:53 ` Krzysztof Kozlowski
2020-11-03 9:51 ` Marek Szyprowski
2020-11-03 10:38 ` Martin Juecker
2020-11-05 11:50 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029214030.GA72802@adroid \
--to=martin.juecker@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).