From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Willy Wolff <willy.mh.wolff.ml@gmail.com>,
Marian Mihailescu <mihailescu2m@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible
Date: Tue, 29 Dec 2020 16:31:58 +0100 [thread overview]
Message-ID: <20201229153158.GA11658@kozik-lap> (raw)
In-Reply-To: <14102bab-33a1-45e0-0faf-883c7b1133a5@samsung.com>
On Fri, Nov 20, 2020 at 12:07:44PM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 20.11.2020 12:05, Krzysztof Kozlowski wrote:
> > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote:
> >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the
> >> recently introduced dedicated compatible for Exynos5420.
> >>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos54xx.dtsi | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
> >> index fe9d34c23374..2ddb7a5f12b3 100644
> >> --- a/arch/arm/boot/dts/exynos54xx.dtsi
> >> +++ b/arch/arm/boot/dts/exynos54xx.dtsi
> >> @@ -188,7 +188,7 @@
> >> compatible = "samsung,exynos4210-ehci";
> >> reg = <0x12110000 0x100>;
> >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> >> - phys = <&usb2_phy 1>;
> >> + phys = <&usb2_phy 0>;
> >> phy-names = "host";
> >> };
> >>
> >> @@ -196,12 +196,12 @@
> >> compatible = "samsung,exynos4210-ohci";
> >> reg = <0x12120000 0x100>;
> >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> >> - phys = <&usb2_phy 1>;
> >> + phys = <&usb2_phy 0>;
> >> phy-names = "host";
> >> };
> >>
> >> usb2_phy: phy@12130000 {
> >> - compatible = "samsung,exynos5250-usb2-phy";
> >> + compatible = "samsung,exynos5420-usb2-phy";
> > The DTS change will wait till PHY driver adjustements get merged... or
> > if the difference is not critical, maybe using both compatibles (5420
> > and 5250) would have sense?
>
> It won't work easily with both compatibles, because in the 5420 variant
> I've also changed the PHY indices (5420 has no device and second hsic
> phy). IMHO the dts change can wait for the next release.
Thanks, applied.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-29 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201120085651eucas1p1382e2677b29af0fc94a0b6c1f8d7da12@eucas1p1.samsung.com>
2020-11-20 8:56 ` [PATCH 0/2] Fix USB2 PHY operation on Exynos542x Marek Szyprowski
[not found] ` <CGME20201120085651eucas1p1d30223968745e93e6177892b400a7773@eucas1p1.samsung.com>
2020-11-20 8:56 ` [PATCH 1/2] phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY Marek Szyprowski
2020-11-20 11:00 ` Krzysztof Kozlowski
2020-11-30 10:59 ` Vinod Koul
[not found] ` <CGME20201120085652eucas1p1da360ab03f5b5b02a197d0f1ee435737@eucas1p1.samsung.com>
2020-11-20 8:56 ` [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible Marek Szyprowski
2020-11-20 11:05 ` Krzysztof Kozlowski
2020-11-20 11:07 ` Marek Szyprowski
2020-12-29 15:31 ` Krzysztof Kozlowski [this message]
2021-01-26 22:44 ` Arnd Bergmann
2021-01-27 7:59 ` Krzysztof Kozlowski
2021-01-30 14:14 ` Arnd Bergmann
2021-01-30 14:39 ` Krzysztof Kozlowski
2020-12-29 15:50 ` (subset) [PATCH 0/2] Fix USB2 PHY operation on Exynos542x Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229153158.GA11658@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mihailescu2m@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=vkoul@kernel.org \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).