linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Timon Baetz <timon.baetz@protonmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes
Date: Mon, 4 Jan 2021 19:18:25 +0100	[thread overview]
Message-ID: <20210104181825.GB27043@kozik-lap> (raw)
In-Reply-To: <20210104135156.GB5645@sirena.org.uk>

On Mon, Jan 04, 2021 at 01:51:56PM +0000, Mark Brown wrote:
> On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote:
> 
> > +- charger: Node for configuring the charger driver.
> > +  Required properties:
> > +  - compatible: "maxim,max8997-battery"
> > +  Optional properties:
> > +  - extcon: extcon specifier for charging events
> > +  - charger-supply: regulator node for charging current
> > +
> > +- muic: Node used only by extcon consumers.
> > +  Required properties:
> > +  - compatible: "maxim,max8997-muic"
> 
> Why do these need to appear in the DT binding?  We know these features
> are there simply from knowing this is a max8997.

If you refer to children nodes, then we do not know these entirely
because the features could be disabled (pins not connected).  In such
case these subnodes can be disabled and MFD framework will not
instantiate children devices.

If you mean "the properties" like extcon or charger, then indeed it's a
good question. In theory, wires still could be routed differently, e.g.
different charging regulator used as a charger.
In practice this is highly unlikely, however such DT design allows
easier hooking up of different devices and even potential re-usage of
kernel drivers (also unlikely...).

Best regards,
Krzysztof


  reply	other threads:[~2021-01-04 18:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 20:51 [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Timon Baetz
2020-12-30 20:52 ` [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Timon Baetz
2021-01-04 13:51   ` Mark Brown
2021-01-04 18:18     ` Krzysztof Kozlowski [this message]
2021-01-04 18:27       ` Mark Brown
2021-01-04 18:38         ` Krzysztof Kozlowski
2021-01-04 21:24           ` Mark Brown
2021-01-05 16:55             ` Krzysztof Kozlowski
2021-01-06 14:59               ` Mark Brown
2021-01-08 15:16                 ` Timon Baetz
2021-01-08 16:16                   ` Mark Brown
2021-01-15  6:19                     ` Timon Baetz
2021-01-15 13:42                       ` Mark Brown
2021-01-16  8:03                         ` Timon Baetz
2021-01-18 12:45                           ` Mark Brown
2021-01-11 21:50   ` Rob Herring
2020-12-30 20:52 ` [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit Timon Baetz
2020-12-31  8:55   ` Krzysztof Kozlowski
2021-01-03  1:53   ` Sebastian Reichel
2020-12-30 20:52 ` [PATCH v6 4/8] ARM: dts: exynos: Add muic and charger nodes for I9100 Timon Baetz
2020-12-30 20:52 ` [PATCH v6 5/8] ARM: dts: exynos: Add muic and charger nodes for Origen Timon Baetz
2020-12-30 20:52 ` [PATCH v6 6/8] ARM: dts: exynos: Add muic and charger nodes for Trats Timon Baetz
2020-12-30 20:53 ` [PATCH v6 7/8] ARM: dts: exynos: Fix charging regulator voltage and current for I9100 Timon Baetz
2020-12-30 20:53 ` [PATCH v6 8/8] ARM: dts: exynos: Add top-off charging regulator node " Timon Baetz
2021-01-03 16:32 ` (subset) [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Krzysztof Kozlowski
2021-01-03 16:34 ` Krzysztof Kozlowski
2021-01-04 10:26 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104181825.GB27043@kozik-lap \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=timon.baetz@protonmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).