From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chanho Park <chanho61.park@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: samsung: use raw_spinlock for locking
Date: Fri, 22 Jan 2021 14:21:39 +0100 [thread overview]
Message-ID: <20210122132139.cowdrtjhdoicdsvv@kozik-lap> (raw)
In-Reply-To: <CACRpkdZ26sNR+oZy_f6JR4ZuNWS9PoVAm-OuNwgzCAuhEBGTeQ@mail.gmail.com>
On Fri, Jan 22, 2021 at 02:15:18PM +0100, Linus Walleij wrote:
> On Thu, Jan 21, 2021 at 4:00 AM Chanho Park <chanho61.park@samsung.com> wrote:
>
> > This patch converts spin_[lock|unlock] functions of pin bank to
> > raw_spinlock to support preempt-rt. This can avoid BUG() assertion when
> > irqchip callbacks are triggerred. Spinlocks can be converted rt_mutex
> > which is preemptible when we apply preempt-rt patches.
> >
> > According to "Documentation/driver-api/gpio/driver.rst",
> >
> > "Realtime considerations: a realtime compliant GPIO driver should not
> > use spinlock_t or any sleepable APIs (like PM runtime) as part of its
> > irqchip implementation.
> >
> > - spinlock_t should be replaced with raw_spinlock_t.[1]
> > "
> >
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>
> Looks correct to me.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Krzysztof, will you collect Samsung patches for this merge window or
> shall I apply it directly?
I don't have anything in the queue so far and I don't see any patches
incomming, so maybe take it directly?
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-01-22 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210121030006epcas2p40fd4e30ae5bf514b7891a464462db7be@epcas2p4.samsung.com>
2021-01-21 3:00 ` [PATCH] pinctrl: samsung: use raw_spinlock for locking Chanho Park
2021-01-22 13:15 ` Linus Walleij
2021-01-22 13:21 ` Krzysztof Kozlowski [this message]
2021-01-23 22:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122132139.cowdrtjhdoicdsvv@kozik-lap \
--to=krzk@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).