From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4CAC433E9 for ; Mon, 1 Feb 2021 10:06:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 239BF64DAD for ; Mon, 1 Feb 2021 10:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232924AbhBAKFx (ORCPT ); Mon, 1 Feb 2021 05:05:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232894AbhBAKFv (ORCPT ); Mon, 1 Feb 2021 05:05:51 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9561C061573 for ; Mon, 1 Feb 2021 02:05:05 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id y205so11244201pfc.5 for ; Mon, 01 Feb 2021 02:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=frVr/xCUvbYcgOOMMYBu0rOoutvXVeUOoguRH3Tfir4=; b=KwK6870QDpRjaQinp8V2YB7qTqptw0NUC4QQzI6GlaPFwXhH4XhywUDn/dr3sbz6Gy OC4dJlWbmACnp5g0iaHf7r2ef2MJMzVA4SX9JzX0tQzX3dH9LjJrJmtGptQfM2hAb75z UwUleW6xFmNJZ+WzH6n/lRLf7noLT5jz5vNrR3OyxLR8GSEIHs3YpR9lunUV5AVQaJ5e xUsgx/9Q29q66NefdOejr8sBM9dmVUXClEIPnF5lvzGZDfQAj90Vfg6rzlDhsmHnyaIj BgQ6zroUKfsLkQfJtGCrRgiUkguq9n6eaDLq/9bX4KdNIES/ladpVGwk5SF3htHMTj4K ukHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=frVr/xCUvbYcgOOMMYBu0rOoutvXVeUOoguRH3Tfir4=; b=gekQVAXoL4162bCkfiXDOvXFD/+IIXQxvzCmSn6FffYxB8jlIwZYKSwxkh2cSsn9aW 4tqzIqIgXs6scNlucjjjYLH5Zu2aqaIFrf7ii6du0xK6ub2ZkYS3U50UY8YL/nijng7K 9PYlCcUheQ1z8khzh6LzrC6Vk/bPStNdL7OoSeIGHXVnmUfldex4iTA9ZBERbPJUgAam UWqMUn/W00P/f777Y/6KFY7R2qoo+F+kGeQd26iH20TRq7htSsz6249qmprRCU6EA+eJ 5EZOnKh787ezJUOq0sV1WXlL3mi/H74eCw2YN1InvhIdc6Um3+z+8iAM9V4noYaFAdxs gnPw== X-Gm-Message-State: AOAM533/d6IzK97eSgY1RzJKVWwO2PCFs1nTPpk+b9qK45y7IJsuK7To N8KYBqGQiXTsuPWyyx6nJiJwnw== X-Google-Smtp-Source: ABdhPJyxP1XDmrI0MqAUO7EnoKcwJKb1624sQpyrFq75F363UpbEny2r9jczdiB/yEeu8ohEE5Gqfw== X-Received: by 2002:aa7:8698:0:b029:1be:aef7:449d with SMTP id d24-20020aa786980000b02901beaef7449dmr15532020pfo.60.1612173905191; Mon, 01 Feb 2021 02:05:05 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id c11sm15454066pfl.185.2021.02.01.02.05.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2021 02:05:04 -0800 (PST) Date: Mon, 1 Feb 2021 15:35:02 +0530 From: Viresh Kumar To: Dominik Brodowski Cc: Rafael Wysocki , Keguang Zhang , Kevin Hilman , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Sudeep Holla , Thierry Reding , Jonathan Hunter , Matthias Brugger , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] cpufreq: Remove CPUFREQ_STICKY flag Message-ID: <20210201100502.xluaj5rpqosqsq7b@vireshk-i7> References: <377d2e2d328276070ae2f26c65daa1497bb3c3cf.1612166647.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 01-02-21, 10:44, Dominik Brodowski wrote: > IIRC, it was required on various ARM systems,[*] as CPUs were registered as > subsys_initcall(), while cpufreq used to be initialized only later, as an s/later/earlier ? arch happens before subsys not at least and that is the only way we can break cpufreq here, i.e. when the driver comes up before the CPUs are registered. > arch_initcall(). If the ordering is opposite now on all architectures (it > wasn't on ARM back then), we should be fine. > > [*] https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/arch/arm/mach-sa1100/cpu-sa1100.c?id=f59d3bbe35f6268d729f51be82af8325d62f20f5 Thanks for your reply, it made me look at that aspect in some more detail to confirm I don't end up breaking anything. Unless I am making a mistake in reading the code, this is the code flow that we have right now: start_kernel() -> kernel_init() -> kernel_init_freeable() -> do_basic_setup() -> driver_init() -> cpu_dev_init() -> subsys_system_register(for-CPUs) -> do_initcalls() -> register-cpufreq-driver from any level And so CPUs should always be there for a cpufreq driver. Makes sense ? -- viresh