linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250
@ 2021-07-31  9:24 Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 2/8] ARM: dts: exynos: add CPU topology to Exynos4210 Krzysztof Kozlowski
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos3250 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos3250.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 77ab7193b903..a10b789d8acf 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -50,6 +50,17 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+			};
+		};
+
 		cpu0: cpu@0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/8] ARM: dts: exynos: add CPU topology to Exynos4210
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 3/8] ARM: dts: exynos: add CPU topology to Exynos4412 Krzysztof Kozlowski
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos4210 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos4210.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 70baad9b11f0..7e7d65ce6585 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -32,6 +32,17 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+			};
+		};
+
 		cpu0: cpu@900 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/8] ARM: dts: exynos: add CPU topology to Exynos4412
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 2/8] ARM: dts: exynos: add CPU topology to Exynos4210 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 4/8] ARM: dts: exynos: add CPU topology to Exynos5250 Krzysztof Kozlowski
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos4412 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos4412.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index a142fe84010b..d3802046c8b8 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -35,6 +35,23 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+				core2 {
+					cpu = <&cpu2>;
+				};
+				core3 {
+					cpu = <&cpu3>;
+				};
+			};
+		};
+
 		cpu0: cpu@a00 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/8] ARM: dts: exynos: add CPU topology to Exynos5250
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 2/8] ARM: dts: exynos: add CPU topology to Exynos4210 Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 3/8] ARM: dts: exynos: add CPU topology to Exynos4412 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 5/8] ARM: dts: exynos: add CPU topology to Exynos5260 Krzysztof Kozlowski
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos5250 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5250.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 2ea2caaca4e2..4ffa9253b566 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -50,6 +50,17 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+			};
+		};
+
 		cpu0: cpu@0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 5/8] ARM: dts: exynos: add CPU topology to Exynos5260
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2021-07-31  9:24 ` [PATCH 4/8] ARM: dts: exynos: add CPU topology to Exynos5250 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 6/8] ARM: dts: exynos: add CPU topology to Exynos5420 Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos5260 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5260.dtsi | 38 ++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exynos5260.dtsi
index 973448c4ad93..52fa211525ce 100644
--- a/arch/arm/boot/dts/exynos5260.dtsi
+++ b/arch/arm/boot/dts/exynos5260.dtsi
@@ -34,42 +34,68 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu@0 {
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+			};
+
+			cluster1 {
+				core0 {
+					cpu = <&cpu2>;
+				};
+				core1 {
+					cpu = <&cpu3>;
+				};
+				core2 {
+					cpu = <&cpu4>;
+				};
+				core3 {
+					cpu = <&cpu5>;
+				};
+			};
+		};
+
+		cpu0: cpu@0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x0>;
 			cci-control-port = <&cci_control1>;
 		};
 
-		cpu@1 {
+		cpu1: cpu@1 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x1>;
 			cci-control-port = <&cci_control1>;
 		};
 
-		cpu@100 {
+		cpu2: cpu@100 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
 			reg = <0x100>;
 			cci-control-port = <&cci_control0>;
 		};
 
-		cpu@101 {
+		cpu3: cpu@101 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
 			reg = <0x101>;
 			cci-control-port = <&cci_control0>;
 		};
 
-		cpu@102 {
+		cpu4: cpu@102 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
 			reg = <0x102>;
 			cci-control-port = <&cci_control0>;
 		};
 
-		cpu@103 {
+		cpu5: cpu@103 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
 			reg = <0x103>;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 6/8] ARM: dts: exynos: add CPU topology to Exynos5420
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2021-07-31  9:24 ` [PATCH 5/8] ARM: dts: exynos: add CPU topology to Exynos5260 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 7/8] ARM: dts: exynos: add CPU topology to Exynos5422 Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos5420 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5420-cpus.dtsi | 32 ++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
index 58d1c54cf925..e9f4eb75b50f 100644
--- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
@@ -22,6 +22,38 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+				core2 {
+					cpu = <&cpu2>;
+				};
+				core3 {
+					cpu = <&cpu3>;
+				};
+			};
+
+			cluster1 {
+				core0 {
+					cpu = <&cpu4>;
+				};
+				core1 {
+					cpu = <&cpu5>;
+				};
+				core2 {
+					cpu = <&cpu6>;
+				};
+				core3 {
+					cpu = <&cpu7>;
+				};
+			};
+		};
+
 		cpu0: cpu@0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 7/8] ARM: dts: exynos: add CPU topology to Exynos5422
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
                   ` (4 preceding siblings ...)
  2021-07-31  9:24 ` [PATCH 6/8] ARM: dts: exynos: add CPU topology to Exynos5420 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-07-31  9:24 ` [PATCH 8/8] arm64: dts: exynos: add CPU topology to Exynos5433 Krzysztof Kozlowski
  2021-08-05  7:25 ` [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos5422 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos5422-cpus.dtsi | 32 ++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-cpus.dtsi b/arch/arm/boot/dts/exynos5422-cpus.dtsi
index 4b641b9b8179..412a0bb4b988 100644
--- a/arch/arm/boot/dts/exynos5422-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5422-cpus.dtsi
@@ -21,6 +21,38 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+				core2 {
+					cpu = <&cpu2>;
+				};
+				core3 {
+					cpu = <&cpu3>;
+				};
+			};
+
+			cluster1 {
+				core0 {
+					cpu = <&cpu4>;
+				};
+				core1 {
+					cpu = <&cpu5>;
+				};
+				core2 {
+					cpu = <&cpu6>;
+				};
+				core3 {
+					cpu = <&cpu7>;
+				};
+			};
+		};
+
 		cpu0: cpu@100 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 8/8] arm64: dts: exynos: add CPU topology to Exynos5433
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
                   ` (5 preceding siblings ...)
  2021-07-31  9:24 ` [PATCH 7/8] ARM: dts: exynos: add CPU topology to Exynos5422 Krzysztof Kozlowski
@ 2021-07-31  9:24 ` Krzysztof Kozlowski
  2021-08-05  7:25 ` [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-31  9:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Marek Szyprowski, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Alim Akhtar

Describe Exynos5433 CPU topology.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 73aa0fa9b778..6a6f7dd1d65c 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -52,6 +52,38 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+				core2 {
+					cpu = <&cpu2>;
+				};
+				core3 {
+					cpu = <&cpu3>;
+				};
+			};
+
+			cluster1 {
+				core0 {
+					cpu = <&cpu4>;
+				};
+				core1 {
+					cpu = <&cpu5>;
+				};
+				core2 {
+					cpu = <&cpu6>;
+				};
+				core3 {
+					cpu = <&cpu7>;
+				};
+			};
+		};
+
 		cpu0: cpu@100 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a53";
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250
  2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
                   ` (6 preceding siblings ...)
  2021-07-31  9:24 ` [PATCH 8/8] arm64: dts: exynos: add CPU topology to Exynos5433 Krzysztof Kozlowski
@ 2021-08-05  7:25 ` Krzysztof Kozlowski
  7 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-05  7:25 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel, devicetree, linux-kernel,
	Rob Herring, Krzysztof Kozlowski
  Cc: Alim Akhtar, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
	Chanwoo Choi, Marek Szyprowski

On Sat, 31 Jul 2021 11:24:02 +0200, Krzysztof Kozlowski wrote:
> Describe Exynos3250 CPU topology.

Applied, thanks!

[1/8] ARM: dts: exynos: add CPU topology to Exynos3250
      commit: a2798e309f3c67ab69073582dc4b8102a9013e25
[2/8] ARM: dts: exynos: add CPU topology to Exynos4210
      commit: 900dd07d13e46b2937522ac7cc46a9ceb49284b6
[3/8] ARM: dts: exynos: add CPU topology to Exynos4412
      commit: 1fb5b5b0dc491613eaa42bc39457589bfcb2b2b9
[4/8] ARM: dts: exynos: add CPU topology to Exynos5250
      commit: fc6d5c9953757c61042676db9bb32ecd7af958f3
[5/8] ARM: dts: exynos: add CPU topology to Exynos5260
      commit: fa0c56dbc3a1b116d280c3a3a97052ea38e4ea2b
[6/8] ARM: dts: exynos: add CPU topology to Exynos5420
      commit: a73d3069f6f7717bbd31a2fcfe8ddb3d98076b1d
[7/8] ARM: dts: exynos: add CPU topology to Exynos5422
      commit: 6cad6db75231a18f25dc7d610d5a0683160ac545
[8/8] arm64: dts: exynos: add CPU topology to Exynos5433
      commit: 0cdcca7ec37cfe54cd2f0668eddcf5aef87a05e3

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-08-05  7:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31  9:24 [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 2/8] ARM: dts: exynos: add CPU topology to Exynos4210 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 3/8] ARM: dts: exynos: add CPU topology to Exynos4412 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 4/8] ARM: dts: exynos: add CPU topology to Exynos5250 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 5/8] ARM: dts: exynos: add CPU topology to Exynos5260 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 6/8] ARM: dts: exynos: add CPU topology to Exynos5420 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 7/8] ARM: dts: exynos: add CPU topology to Exynos5422 Krzysztof Kozlowski
2021-07-31  9:24 ` [PATCH 8/8] arm64: dts: exynos: add CPU topology to Exynos5433 Krzysztof Kozlowski
2021-08-05  7:25 ` [PATCH 1/8] ARM: dts: exynos: add CPU topology to Exynos3250 Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).