From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch
Date: Mon, 4 Oct 2021 11:43:28 +0530 [thread overview]
Message-ID: <20211004061328.nmvjuyloitd7bswz@vireshk-i7> (raw)
In-Reply-To: <20210927095150.944127-1-arnd@kernel.org>
On 27-09-21, 11:51, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Apparently nobody has so far caught this warning, I hit it in randconfig
> build testing:
>
> drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
> drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
> case 3:
> ^~~~
> drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
> case 4:
> ^~~~
>
> Both look like the fallthrough is intentional, so add the new
> "fallthrough;" keyword.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/s3c2440-cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c
> index 148e8aedefa9..2011fb9c03a4 100644
> --- a/drivers/cpufreq/s3c2440-cpufreq.c
> +++ b/drivers/cpufreq/s3c2440-cpufreq.c
> @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg)
>
> case 6:
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> + fallthrough;
> case 3:
> clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6;
> break;
>
> case 8:
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> + fallthrough;
> case 4:
> clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8;
> break;
Applied. Thanks.
--
viresh
prev parent reply other threads:[~2021-10-04 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 9:51 [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Arnd Bergmann
2021-09-27 9:55 ` Krzysztof Kozlowski
2021-10-04 6:13 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004061328.nmvjuyloitd7bswz@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).