From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACEDC433EF for ; Mon, 4 Oct 2021 06:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 238CD61373 for ; Mon, 4 Oct 2021 06:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232647AbhJDGPX (ORCPT ); Mon, 4 Oct 2021 02:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232630AbhJDGPW (ORCPT ); Mon, 4 Oct 2021 02:15:22 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D6A4C061783 for ; Sun, 3 Oct 2021 23:13:31 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 75so15553553pga.3 for ; Sun, 03 Oct 2021 23:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XntAjvkFhoJm9SfDhp1+lB9X4205W7jSFxUyPaX0NI0=; b=BqIm+OlXOqzyc2qOtX2n/5bPFvCL1WiiIVbXzmvOo1Mt30SKWqQCVCDOJFOFpgq46W 5rQ10P+CANIH+JKS2U9SwpP3Cvy5Iw3xaC93THsLYGhzQDlx1vZ6boB7y8ylIIJIb/cm 23Lu5IzAj6MG50JAYMxxjWs5oiPvxdnEe9iGlHJZoF2eh+Oc0A9Atj2VmmQxcMdI68kp OUxnqzF7/31Z76Iz8s72ZJ+elcj66Kg7kZNljptL1+zrU9hVtwcHPB67Dij6wmUJvIUT 6xXvdaNRQcQ71tNkCUrZo80mEBrBDN8JffG7whWWjYVOrdvj7/Sb+atASbmHtgGXtCYG O8lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XntAjvkFhoJm9SfDhp1+lB9X4205W7jSFxUyPaX0NI0=; b=SdNyPkJWPeaOHU+E0BEA8y6Zf0TTzCAgbMpUHcRcyGQDEhouWc2o08S5g30sPTZzO8 wxqpkf1sxvbgbbOg5pPIpY1wHgCSnOneTdzsNVYMJ3ibUZ67jhHbwr27OABMGIy5N90o +P4f86b48nexfUX1UTJrsaMEVEfI7hsYKxUuE9jLagCSsiKMwgbFghWxWiczs8yibNEQ y673ejY+FouFZRbEMn86+AqJAcHWhyXNSSm8LrB454X4zmCTBgNVoZXZTMAOEFfV/a+F cVwu9oERS/0VZYvoIPZulF7P6BiUTBbzt5R1KbElBvGZlI0joIC6miiUJ38Ie5rxws2a nO0A== X-Gm-Message-State: AOAM533wmTc+5ZIGdEEtrzRvVKy2ewmfEL5F2RuVpC9OTrZJ+UpfBTlV d3sfShoEOiWpe/ILOOFVbMGvjA== X-Google-Smtp-Source: ABdhPJzOwA4jj74rHcQAe47W8NOgh+6zNGEEZf04pBTvOzaM+XzcDfYKOSRDibbo4QX31//fu9OtTA== X-Received: by 2002:a63:d80c:: with SMTP id b12mr9337075pgh.331.1633328010891; Sun, 03 Oct 2021 23:13:30 -0700 (PDT) Received: from localhost ([122.171.247.18]) by smtp.gmail.com with ESMTPSA id s3sm998645pfw.2.2021.10.03.23.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 23:13:30 -0700 (PDT) Date: Mon, 4 Oct 2021 11:43:28 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: Krzysztof Kozlowski , "Rafael J. Wysocki" , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Message-ID: <20211004061328.nmvjuyloitd7bswz@vireshk-i7> References: <20210927095150.944127-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210927095150.944127-1-arnd@kernel.org> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 27-09-21, 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c > index 148e8aedefa9..2011fb9c03a4 100644 > --- a/drivers/cpufreq/s3c2440-cpufreq.c > +++ b/drivers/cpufreq/s3c2440-cpufreq.c > @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) > > case 6: > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > + fallthrough; > case 3: > clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; > break; > > case 8: > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > + fallthrough; > case 4: > clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; > break; Applied. Thanks. -- viresh