* [PATCH] cpufreq: s3c244x: add fallthrough comments for switch
@ 2021-09-27 9:51 Arnd Bergmann
2021-09-27 9:55 ` Krzysztof Kozlowski
2021-10-04 6:13 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-09-27 9:51 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rafael J. Wysocki, Viresh Kumar
Cc: Arnd Bergmann, linux-arm-kernel, linux-samsung-soc, linux-pm,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Apparently nobody has so far caught this warning, I hit it in randconfig
build testing:
drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
^
drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
case 3:
^~~~
drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
^
drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
case 4:
^~~~
Both look like the fallthrough is intentional, so add the new
"fallthrough;" keyword.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/s3c2440-cpufreq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c
index 148e8aedefa9..2011fb9c03a4 100644
--- a/drivers/cpufreq/s3c2440-cpufreq.c
+++ b/drivers/cpufreq/s3c2440-cpufreq.c
@@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg)
case 6:
camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
+ fallthrough;
case 3:
clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6;
break;
case 8:
camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
+ fallthrough;
case 4:
clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8;
break;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch
2021-09-27 9:51 [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Arnd Bergmann
@ 2021-09-27 9:55 ` Krzysztof Kozlowski
2021-10-04 6:13 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-27 9:55 UTC (permalink / raw)
To: Arnd Bergmann, Rafael J. Wysocki, Viresh Kumar
Cc: Arnd Bergmann, linux-arm-kernel, linux-samsung-soc, linux-pm,
linux-kernel
On 27/09/2021 11:51, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Apparently nobody has so far caught this warning, I hit it in randconfig
> build testing:
>
> drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
> drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
> case 3:
> ^~~~
> drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
> case 4:
> ^~~~
>
> Both look like the fallthrough is intentional, so add the new
> "fallthrough;" keyword.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/s3c2440-cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
I think I saw it but back then implicit-fallthrough was not an error :)
LGTM:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch
2021-09-27 9:51 [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Arnd Bergmann
2021-09-27 9:55 ` Krzysztof Kozlowski
@ 2021-10-04 6:13 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-10-04 6:13 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Krzysztof Kozlowski, Rafael J. Wysocki, Arnd Bergmann,
linux-arm-kernel, linux-samsung-soc, linux-pm, linux-kernel
On 27-09-21, 11:51, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Apparently nobody has so far caught this warning, I hit it in randconfig
> build testing:
>
> drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
> drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
> case 3:
> ^~~~
> drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
> case 4:
> ^~~~
>
> Both look like the fallthrough is intentional, so add the new
> "fallthrough;" keyword.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/s3c2440-cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c
> index 148e8aedefa9..2011fb9c03a4 100644
> --- a/drivers/cpufreq/s3c2440-cpufreq.c
> +++ b/drivers/cpufreq/s3c2440-cpufreq.c
> @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg)
>
> case 6:
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> + fallthrough;
> case 3:
> clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6;
> break;
>
> case 8:
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> + fallthrough;
> case 4:
> clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8;
> break;
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 9:51 [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Arnd Bergmann
2021-09-27 9:55 ` Krzysztof Kozlowski
2021-10-04 6:13 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).