linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge
@ 2022-08-29 18:40 Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order Jagan Teki
                   ` (11 more replies)
  0 siblings, 12 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

This series supports common bridge support for Samsung MIPI DSIM
which is used in Exynos and i.MX8MM SoC's.

Previous v2 can be available here [1].

The final bridge supports both the Exynos and i.MX8MM DSI devices.

On, summary this patch-set break the entire DSIM driver into
- platform specific glue code for platform ops, component_ops.
- common bridge driver which handle platform glue init and invoke.

Changes for v3:
* fix the mult-arch build
* fix dsi host init
* updated commit messages

Changes for v2:
* fix bridge handling
* fix dsi host init
* correct the commit messages

Patch 0001:	Restore proper bridge chain in exynos_dsi

Patch 0002: 	Samsung DSIM bridge

Patch 0003:	Common lookup code for OF-graph or child

Patch 0004: 	plat_data quirk flag via driver_data

Patch 0005/10:  bridge fixes, atomic API's

Patch 0011:	document fsl,imx8mm-mipi-dsim

Patch 0012:	add i.MX8MM DSIM support

Tested in Engicam i.Core MX8M Mini SoM.

Anyone interested, please have a look on this repo [2] and 
boot log [3].

[3] https://gist.github.com/openedev/22b2d63b30ade0ba55ab414a2f47aaf0
[2] https://github.com/openedev/kernel/tree/imx8mm-dsi-v4
[1] https://patchwork.kernel.org/project/dri-devel/cover/20220720155210.365977-1-jagan@amarulasolutions.com/

Any inputs?
Jagan.

Jagan Teki (11):
  drm: bridge: Add Samsung DSIM bridge driver
  drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices
  drm: bridge: samsung-dsim: Handle platform init via driver_data
  drm: bridge: samsung-dsim: Mark PHY as optional
  drm: bridge: samsung-dsim: Handle proper DSI host initialization
  drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset
  drm: bridge: samsung-dsim: Add atomic_check
  drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts
  drm: bridge: samsung-dsim: Add input_bus_flags
  dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
  drm: bridge: samsung-dsim: Add i.MX8MM support

Marek Szyprowski (1):
  drm: exynos: dsi: Restore proper bridge chain order

 .../bindings/display/exynos/exynos_dsim.txt   |    1 +
 MAINTAINERS                                   |    9 +
 drivers/gpu/drm/bridge/Kconfig                |   12 +
 drivers/gpu/drm/bridge/Makefile               |    1 +
 drivers/gpu/drm/bridge/samsung-dsim.c         | 1833 +++++++++++++++++
 drivers/gpu/drm/exynos/Kconfig                |    1 +
 drivers/gpu/drm/exynos/exynos_drm_drv.c       |    3 -
 drivers/gpu/drm/exynos/exynos_drm_drv.h       |    1 -
 drivers/gpu/drm/exynos/exynos_drm_dsi.c       | 1717 +--------------
 include/drm/bridge/samsung-dsim.h             |  107 +
 10 files changed, 2027 insertions(+), 1658 deletions(-)
 create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
 create mode 100644 include/drm/bridge/samsung-dsim.h

-- 
2.25.1


^ permalink raw reply	[flat|nested] 25+ messages in thread

* [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 03/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

From: Marek Szyprowski <m.szyprowski@samsung.com>

Restore the proper bridge chain by finding the previous bridge
in the chain instead of passing NULL.

This establishes a proper bridge chain while attaching downstream
bridges.

v4:
* none

v3:
* new patch

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index ec673223d6b7..e5b1540c4ae4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1428,7 +1428,8 @@ static int exynos_dsi_attach(struct drm_bridge *bridge,
 {
 	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
-	return drm_bridge_attach(bridge->encoder, dsi->out_bridge, NULL, flags);
+	return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge,
+				 flags);
 }
 
 static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
@@ -1474,7 +1475,10 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 
 	drm_bridge_add(&dsi->bridge);
 
-	drm_bridge_attach(encoder, &dsi->bridge, NULL, 0);
+	drm_bridge_attach(encoder, &dsi->bridge,
+			  list_first_entry_or_null(&encoder->bridge_chain,
+						   struct drm_bridge,
+						   chain_node), 0);
 
 	/*
 	 * This is a temporary solution and should be made by more generic way.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 03/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 04/12] drm: bridge: samsung-dsim: Handle platform init via driver_data Jagan Teki
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

The child devices in MIPI DSI can be binding with OF-graph
and also via child nodes.

The OF-graph interface represents the child devices via
remote and associated endpoint numbers like

dsi {
   compatible = "fsl,imx8mm-mipi-dsim";

   ports {
	port@0 {
	     reg = <0>;

	     dsi_in_lcdif: endpoint@0 {
		  reg = <0>;
		  remote-endpoint = <&lcdif_out_dsi>;
	     };
	};

	port@1 {
	     reg = <1>;

	     dsi_out_bridge: endpoint {
		  remote-endpoint = <&bridge_in_dsi>;
	     };
	};
};

The child node interface represents the child devices via
conventional child nodes on given DSI parent like

dsi {
   compatible = "samsung,exynos5433-mipi-dsi";

   ports {
        port@0 {
             reg = <0>;

             dsi_to_mic: endpoint {
                  remote-endpoint = <&mic_to_dsi>;
             };
        };
   };

   panel@0 {
        reg = <0>;
   };
};

As Samsung DSIM bridge is common DSI IP across all Exynos DSI
and NXP i.MX8M host controllers, this patch adds support to
lookup the child devices whether its bindings on the associated
host represent OF-graph or child node interfaces.

v4, v3:
* none

v2:
* new patch

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 38 +++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index ab2fa0f42f40..8130845750ac 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1357,18 +1357,52 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host,
 	struct samsung_dsim *dsi = host_to_dsi(host);
 	const struct samsung_dsim_plat_data *pdata = dsi->plat_data;
 	struct device *dev = dsi->dev;
+	struct device_node *np = dev->of_node;
+	struct device_node *remote;
 	struct drm_panel *panel;
 	int ret;
 
-	panel = of_drm_find_panel(device->dev.of_node);
+	/**
+	 * Devices can also be child nodes when we also control that device
+	 * through the upstream device (ie, MIPI-DCS for a MIPI-DSI device).
+	 *
+	 * Lookup for a child node of the given parent that isn't either port
+	 * or ports.
+	 */
+	for_each_available_child_of_node(np, remote) {
+		if (of_node_name_eq(remote, "port") ||
+		    of_node_name_eq(remote, "ports"))
+			continue;
+
+		goto of_find_panel_or_bridge;
+	}
+
+	/*
+	 * of_graph_get_remote_node() produces a noisy error message if port
+	 * node isn't found and the absence of the port is a legit case here,
+	 * so at first we silently check whether graph presents in the
+	 * device-tree node.
+	 */
+	if (!of_graph_is_present(np))
+		return -ENODEV;
+
+	remote = of_graph_get_remote_node(np, 1, 0);
+
+of_find_panel_or_bridge:
+	if (!remote)
+		return -ENODEV;
+
+	panel = of_drm_find_panel(remote);
 	if (!IS_ERR(panel)) {
 		dsi->out_bridge = devm_drm_panel_bridge_add(dev, panel);
 	} else {
-		dsi->out_bridge = of_drm_find_bridge(device->dev.of_node);
+		dsi->out_bridge = of_drm_find_bridge(remote);
 		if (!dsi->out_bridge)
 			dsi->out_bridge = ERR_PTR(-EINVAL);
 	}
 
+	of_node_put(remote);
+
 	if (IS_ERR(dsi->out_bridge)) {
 		ret = PTR_ERR(dsi->out_bridge);
 		DRM_DEV_ERROR(dev, "failed to find the bridge: %d\n", ret);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 04/12] drm: bridge: samsung-dsim: Handle platform init via driver_data
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 03/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 05/12] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

In order to make a common Samsung DSIM bridge driver some platform
specific glue code needs to maintain separately as it is hard to
maintain platform specific glue and conventional component_ops on
the drm bridge drivers side.

This patch is trying to support that glue code initialization based
on the DSIM_QUIRK_PLAT_DATA set from respective driver_data.

So, the platforms which enable DSIM_QUIRK_PLAT_DATA flags will handle
all platform specific initialization via samsung_dsim_plat_probe.

The platform probe is responsible to
- initialize samsung_dsim_plat_data and install hooks
- initialize component_ops
- preserve samsung_dsim structure pointer

v4:
* none

v3:
* update samsung_dsim_plat_probe return value
* add plat_data quirk to handle platform init

v2:
* fix samsung_dsim_plat_probe return pointer

v1:
* use platform_init instead of exynos_specific
* handle component_ops in glue code

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 16 ++++++++++++++--
 include/drm/bridge/samsung-dsim.h     |  5 +++++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 8130845750ac..76dc7687857a 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -369,6 +369,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
 	.reg_values = reg_values,
+	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
 static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
@@ -381,6 +382,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
 	.reg_values = reg_values,
+	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
 static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
@@ -391,6 +393,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
 	.reg_values = reg_values,
+	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
 static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
@@ -402,6 +405,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
 	.wait_for_reset = 0,
 	.num_bits_resol = 12,
 	.reg_values = exynos5433_reg_values,
+	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
 static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
@@ -413,6 +417,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
 	.wait_for_reset = 1,
 	.num_bits_resol = 12,
 	.reg_values = exynos5422_reg_values,
+	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
 static const struct of_device_id samsung_dsim_of_match[] = {
@@ -1609,7 +1614,11 @@ static int samsung_dsim_probe(struct platform_device *pdev)
 	dsi->bridge.of_node = dev->of_node;
 	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
 
-	ret = samsung_dsim_plat_probe(dsi);
+	if (dsi->driver_data->quirks & DSIM_QUIRK_PLAT_DATA)
+		ret = samsung_dsim_plat_probe(dsi);
+	else
+		ret = mipi_dsi_host_register(&dsi->dsi_host);
+
 	if (ret)
 		goto err_disable_runtime;
 
@@ -1627,7 +1636,10 @@ static int samsung_dsim_remove(struct platform_device *pdev)
 
 	pm_runtime_disable(&pdev->dev);
 
-	samsung_dsim_plat_remove(dsi);
+	if (dsi->driver_data->quirks & DSIM_QUIRK_PLAT_DATA)
+		samsung_dsim_plat_remove(dsi);
+	else
+		mipi_dsi_host_unregister(&dsi->dsi_host);
 
 	return 0;
 }
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index 2e245bffd1b6..97fdee5ef5df 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -33,6 +33,10 @@ struct samsung_dsim_transfer {
 	u16 rx_done;
 };
 
+enum samsung_dsim_quirks {
+	DSIM_QUIRK_PLAT_DATA		= BIT(0),
+};
+
 struct samsung_dsim_driver_data {
 	const unsigned int *reg_ofs;
 	unsigned int plltmr_reg;
@@ -43,6 +47,7 @@ struct samsung_dsim_driver_data {
 	unsigned int wait_for_reset;
 	unsigned int num_bits_resol;
 	const unsigned int *reg_values;
+	enum samsung_dsim_quirks quirks;
 };
 
 struct samsung_dsim_host_ops {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 05/12] drm: bridge: samsung-dsim: Mark PHY as optional
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (2 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 04/12] drm: bridge: samsung-dsim: Handle platform init via driver_data Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 06/12] drm: bridge: samsung-dsim: Handle proper DSI host initialization Jagan Teki
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

In i.MX8M Mini/Nano SoC the DSI Phy requires a MIPI DPHY bit
to reset in order to activate the PHY and that can be done via
upstream i.MX8M blk-ctrl driver.

So, mark the phy get as optional.

v4, v3, v2:
* none

v1:
* new patch

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 76dc7687857a..c3ed317996ad 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1583,7 +1583,7 @@ static int samsung_dsim_probe(struct platform_device *pdev)
 	if (IS_ERR(dsi->reg_base))
 		return PTR_ERR(dsi->reg_base);
 
-	dsi->phy = devm_phy_get(dev, "dsim");
+	dsi->phy = devm_phy_optional_get(dev, "dsim");
 	if (IS_ERR(dsi->phy)) {
 		dev_info(dev, "failed to get dsim phy\n");
 		return PTR_ERR(dsi->phy);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 06/12] drm: bridge: samsung-dsim: Handle proper DSI host initialization
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (3 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 05/12] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

DSI host initialization handling in previous exynos dsi driver has
some pitfalls. It initializes the host during host transfer() hook
that is indeed not the desired call flow for I2C and any other DSI
configured downstream bridges.

Host transfer() is usually triggered for downstream DSI panels or
bridges and I2C-configured-DSI bridges miss these host initialization
as these downstream bridges use bridge operations hooks like pre_enable,
and enable in order to initialize or set up the host.

This patch is trying to handle the host init handler to satisfy all
downstream panels and bridges. Added the DSIM_STATE_REINITIALIZED state
flag to ensure that host init is also done on first cmd transfer, this
helps existing DSI panels work on exynos platform (form Marek
Szyprowski).

v4:
* update init handling to ensure host init done on first cmd transfer

v3:
* none

v2:
* check initialized state in samsung_dsim_init

v1:
* keep DSI init in host transfer

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 25 +++++++++++++++++--------
 include/drm/bridge/samsung-dsim.h     |  5 +++--
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index c3ed317996ad..b6883a6d4681 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1254,12 +1254,17 @@ static void samsung_dsim_disable_irq(struct samsung_dsim *dsi)
 	disable_irq(dsi->irq);
 }
 
-static int samsung_dsim_init(struct samsung_dsim *dsi)
+static int samsung_dsim_init(struct samsung_dsim *dsi, unsigned int flag)
 {
 	const struct samsung_dsim_driver_data *driver_data = dsi->driver_data;
 
+	if (dsi->state & flag)
+		return 0;
+
 	samsung_dsim_reset(dsi);
-	samsung_dsim_enable_irq(dsi);
+
+	if (!(dsi->state & DSIM_STATE_INITIALIZED))
+		samsung_dsim_enable_irq(dsi);
 
 	if (driver_data->reg_values[RESET_TYPE] == DSIM_FUNCRST)
 		samsung_dsim_enable_lane(dsi, BIT(dsi->lanes) - 1);
@@ -1270,6 +1275,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 	samsung_dsim_set_phy_ctrl(dsi);
 	samsung_dsim_init_link(dsi);
 
+	dsi->state |= flag;
+
 	return 0;
 }
 
@@ -1289,6 +1296,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge,
 	}
 
 	dsi->state |= DSIM_STATE_ENABLED;
+
+	ret = samsung_dsim_init(dsi, DSIM_STATE_INITIALIZED);
+	if (ret)
+		return;
 }
 
 static void samsung_dsim_atomic_enable(struct drm_bridge *bridge,
@@ -1464,12 +1475,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host,
 	if (!(dsi->state & DSIM_STATE_ENABLED))
 		return -EINVAL;
 
-	if (!(dsi->state & DSIM_STATE_INITIALIZED)) {
-		ret = samsung_dsim_init(dsi);
-		if (ret)
-			return ret;
-		dsi->state |= DSIM_STATE_INITIALIZED;
-	}
+	ret = samsung_dsim_init(dsi, DSIM_STATE_REINITIALIZED);
+	if (ret)
+		return ret;
 
 	ret = mipi_dsi_create_packet(&xfer.packet, msg);
 	if (ret < 0)
@@ -1654,6 +1662,7 @@ static int __maybe_unused samsung_dsim_suspend(struct device *dev)
 
 	if (dsi->state & DSIM_STATE_INITIALIZED) {
 		dsi->state &= ~DSIM_STATE_INITIALIZED;
+		dsi->state &= ~DSIM_STATE_REINITIALIZED;
 
 		samsung_dsim_disable_clock(dsi);
 
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index 97fdee5ef5df..e15fbfd49efe 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -17,8 +17,9 @@ struct samsung_dsim;
 
 #define DSIM_STATE_ENABLED		BIT(0)
 #define DSIM_STATE_INITIALIZED		BIT(1)
-#define DSIM_STATE_CMD_LPM		BIT(2)
-#define DSIM_STATE_VIDOUT_AVAILABLE	BIT(3)
+#define DSIM_STATE_REINITIALIZED	BIT(2)
+#define DSIM_STATE_CMD_LPM		BIT(3)
+#define DSIM_STATE_VIDOUT_AVAILABLE	BIT(4)
 
 struct samsung_dsim_transfer {
 	struct list_head list;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (4 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 06/12] drm: bridge: samsung-dsim: Handle proper DSI host initialization Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 19:42   ` Adam Ford
  2022-08-29 18:40 ` [PATCH v4 08/12] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
                   ` (5 subsequent siblings)
  11 siblings, 1 reply; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

The i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
with 13.7.10.1 Master PLL PMS Value setting Register mentioned PMS_P offset
range from BIT[18-13] and the upstream driver is using the same offset.

However, offset 13 is not working on i.MX8M Mini platforms but downstream
NXP driver is using 14 [1] and it is working with i.MX8M Mini SoC.

Not sure about whether it is reference manual documentation or something
else but this patch trusts the downstream code and fixes the PLL_P offset.

[1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211

v4, v3, v2:
* none

v1:
* updated commit message
* add downstream driver link

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++++--
 include/drm/bridge/samsung-dsim.h     |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index b6883a6d4681..b6d17c0c9e58 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -168,7 +168,7 @@
 /* DSIM_PLLCTRL */
 #define DSIM_FREQ_BAND(x)		((x) << 24)
 #define DSIM_PLL_EN			(1 << 23)
-#define DSIM_PLL_P(x)			((x) << 13)
+#define DSIM_PLL_P(x, offset)		((x) << (offset))
 #define DSIM_PLL_M(x)			((x) << 4)
 #define DSIM_PLL_S(x)			((x) << 1)
 
@@ -368,6 +368,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
 	.max_freq = 1000,
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
+	.pll_p_offset = 13,
 	.reg_values = reg_values,
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
@@ -381,6 +382,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
 	.max_freq = 1000,
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
+	.pll_p_offset = 13,
 	.reg_values = reg_values,
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
@@ -392,6 +394,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
 	.max_freq = 1000,
 	.wait_for_reset = 1,
 	.num_bits_resol = 11,
+	.pll_p_offset = 13,
 	.reg_values = reg_values,
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
@@ -404,6 +407,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
 	.max_freq = 1500,
 	.wait_for_reset = 0,
 	.num_bits_resol = 12,
+	.pll_p_offset = 13,
 	.reg_values = exynos5433_reg_values,
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
@@ -416,6 +420,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
 	.max_freq = 1500,
 	.wait_for_reset = 1,
 	.num_bits_resol = 12,
+	.pll_p_offset = 13,
 	.reg_values = exynos5422_reg_values,
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
@@ -563,7 +568,8 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi,
 	writel(driver_data->reg_values[PLL_TIMER],
 			dsi->reg_base + driver_data->plltmr_reg);
 
-	reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s);
+	reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) |
+	      DSIM_PLL_M(m) | DSIM_PLL_S(s);
 
 	if (driver_data->has_freqband) {
 		static const unsigned long freq_bands[] = {
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index e15fbfd49efe..95d3f89aec4f 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -47,6 +47,7 @@ struct samsung_dsim_driver_data {
 	unsigned int max_freq;
 	unsigned int wait_for_reset;
 	unsigned int num_bits_resol;
+	unsigned int pll_p_offset;
 	const unsigned int *reg_values;
 	enum samsung_dsim_quirks quirks;
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 08/12] drm: bridge: samsung-dsim: Add atomic_check
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (5 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

Explicit fixing up of mode_flags is required for DSIM present
in i.MX8M SoC.

At least the LCDIF + DSIM needs active low sync polarities in
order to correlate the correct sync flags of the surrounding
components in the chain to make sure the whole pipeline can
work properly.

So, add DSIM_QUIRK_FIXUP_SYNC_POL to handle this fixup via bridge
atomic_check.

v4:
* none

v3:
* add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup

v2:
* none

v1:
* fix mode flags in atomic_check instead of mode_fixup

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 18 ++++++++++++++++++
 include/drm/bridge/samsung-dsim.h     |  1 +
 2 files changed, 19 insertions(+)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index b6d17c0c9e58..724fd76435c6 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1341,6 +1341,23 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge,
 	pm_runtime_put_sync(dsi->dev);
 }
 
+static int samsung_dsim_atomic_check(struct drm_bridge *bridge,
+				     struct drm_bridge_state *bridge_state,
+				     struct drm_crtc_state *crtc_state,
+				     struct drm_connector_state *conn_state)
+{
+	struct samsung_dsim *dsi = bridge_to_dsi(bridge);
+	struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;
+
+	if (dsi->driver_data->quirks & DSIM_QUIRK_FIXUP_SYNC_POL) {
+		/* At least LCDIF + DSIM needs active low sync */
+		adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC);
+		adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC);
+	}
+
+	return 0;
+}
+
 static void samsung_dsim_mode_set(struct drm_bridge *bridge,
 				  const struct drm_display_mode *mode,
 				  const struct drm_display_mode *adjusted_mode)
@@ -1363,6 +1380,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = {
 	.atomic_duplicate_state		= drm_atomic_helper_bridge_duplicate_state,
 	.atomic_destroy_state		= drm_atomic_helper_bridge_destroy_state,
 	.atomic_reset			= drm_atomic_helper_bridge_reset,
+	.atomic_check			= samsung_dsim_atomic_check,
 	.atomic_pre_enable		= samsung_dsim_atomic_pre_enable,
 	.atomic_enable			= samsung_dsim_atomic_enable,
 	.atomic_disable			= samsung_dsim_atomic_disable,
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index 95d3f89aec4f..62e1078f43cc 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -36,6 +36,7 @@ struct samsung_dsim_transfer {
 
 enum samsung_dsim_quirks {
 	DSIM_QUIRK_PLAT_DATA		= BIT(0),
+	DSIM_QUIRK_FIXUP_SYNC_POL	= BIT(1),
 };
 
 struct samsung_dsim_driver_data {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (6 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 08/12] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 10/12] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

Finding the right input bus format throughout the pipeline is hard
so add atomic_get_input_bus_fmts callback and initialize with the
default RGB888_1X24 bus format on DSI-end.

This format can be used in pipeline for negotiating bus format between
the DSI-end of this bridge and the other component closer to pipeline
components.

v4:
* none

v3:
* include media-bus-format.h

v2:
* none

v1:
* new patch

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 28 +++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 724fd76435c6..871cc8cc5352 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -15,6 +15,7 @@
 #include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/irq.h>
+#include <linux/media-bus-format.h>
 #include <linux/of_device.h>
 #include <linux/phy/phy.h>
 
@@ -1341,6 +1342,32 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge,
 	pm_runtime_put_sync(dsi->dev);
 }
 
+#define MAX_INPUT_SEL_FORMATS	1
+
+static u32 *
+samsung_dsim_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
+				       struct drm_bridge_state *bridge_state,
+				       struct drm_crtc_state *crtc_state,
+				       struct drm_connector_state *conn_state,
+				       u32 output_fmt,
+				       unsigned int *num_input_fmts)
+{
+	u32 *input_fmts;
+
+	*num_input_fmts = 0;
+
+	input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
+			     GFP_KERNEL);
+	if (!input_fmts)
+		return NULL;
+
+	/* This is the DSI-end bus format */
+	input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
+	*num_input_fmts = 1;
+
+	return input_fmts;
+}
+
 static int samsung_dsim_atomic_check(struct drm_bridge *bridge,
 				     struct drm_bridge_state *bridge_state,
 				     struct drm_crtc_state *crtc_state,
@@ -1380,6 +1407,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = {
 	.atomic_duplicate_state		= drm_atomic_helper_bridge_duplicate_state,
 	.atomic_destroy_state		= drm_atomic_helper_bridge_destroy_state,
 	.atomic_reset			= drm_atomic_helper_bridge_reset,
+	.atomic_get_input_bus_fmts	= samsung_dsim_atomic_get_input_bus_fmts,
 	.atomic_check			= samsung_dsim_atomic_check,
 	.atomic_pre_enable		= samsung_dsim_atomic_pre_enable,
 	.atomic_enable			= samsung_dsim_atomic_enable,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 10/12] drm: bridge: samsung-dsim: Add input_bus_flags
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (7 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki

eLCDIF is expecting to have input_bus_flags as DE_LOW in order to
set active low during valid data transfer on each horizontal line.

Add DE_LOW flag via drm bridge timings.

v4, v3, v2:
* none

v1:
* none

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 871cc8cc5352..f3b5e265b027 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1593,6 +1593,10 @@ __weak void samsung_dsim_plat_remove(struct samsung_dsim *priv)
 {
 }
 
+static const struct drm_bridge_timings samsung_dsim_bridge_timings = {
+	.input_bus_flags = DRM_BUS_FLAG_DE_LOW,
+};
+
 static int samsung_dsim_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -1672,6 +1676,7 @@ static int samsung_dsim_probe(struct platform_device *pdev)
 
 	dsi->bridge.funcs = &samsung_dsim_bridge_funcs;
 	dsi->bridge.of_node = dev->of_node;
+	dsi->bridge.timings = &samsung_dsim_bridge_timings;
 	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
 
 	if (dsi->driver_data->quirks & DSIM_QUIRK_PLAT_DATA)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (8 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 10/12] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
  2022-08-29 18:40 ` [PATCH v4 12/12] drm: bridge: samsung-dsim: Add " Jagan Teki
       [not found] ` <CGME20220829184118eucas1p2cda47fa166cafcb904800a55a5f66180@eucas1p2.samsung.com>
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki, Rob Herring

Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC.

Add dt-bingings for it.

v4:
* none

v3:
* collect Rob Acked-by

v2:
* updated comments

v1:
* new patch

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt
index be377786e8cd..8efcf4728e0b 100644
--- a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt
+++ b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt
@@ -7,6 +7,7 @@ Required properties:
 		"samsung,exynos5410-mipi-dsi" /* for Exynos5410/5420/5440 SoCs */
 		"samsung,exynos5422-mipi-dsi" /* for Exynos5422/5800 SoCs */
 		"samsung,exynos5433-mipi-dsi" /* for Exynos5433 SoCs */
+		"fsl,imx8mm-mipi-dsim" /* for i.MX8M Mini SoCs */
   - reg: physical base address and length of the registers set for the device
   - interrupts: should contain DSI interrupt
   - clocks: list of clock specifiers, must contain an entry for each required
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v4 12/12] drm: bridge: samsung-dsim: Add i.MX8MM support
  2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
                   ` (9 preceding siblings ...)
  2022-08-29 18:40 ` [PATCH v4 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
@ 2022-08-29 18:40 ` Jagan Teki
       [not found] ` <CGME20220829184118eucas1p2cda47fa166cafcb904800a55a5f66180@eucas1p2.samsung.com>
  11 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-08-29 18:40 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula, Jagan Teki, Laurent Pinchart

Samsung MIPI DSIM master can also be found in i.MX8MM SoC.

Add compatible and associated driver_data for it.

v4:
* none

v3:
* enable DSIM_QUIRK_FIXUP_SYNC_POL quirk

v2:
* collect Laurent r-b

v1:
* none

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 35 +++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index f3b5e265b027..749b11e19217 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -360,6 +360,24 @@ static const unsigned int exynos5433_reg_values[] = {
 	[PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c),
 };
 
+static const unsigned int imx8mm_dsim_reg_values[] = {
+	[RESET_TYPE] = DSIM_SWRST,
+	[PLL_TIMER] = 500,
+	[STOP_STATE_CNT] = 0xf,
+	[PHYCTRL_ULPS_EXIT] = 0,
+	[PHYCTRL_VREG_LP] = 0,
+	[PHYCTRL_SLEW_UP] = 0,
+	[PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06),
+	[PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b),
+	[PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07),
+	[PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26),
+	[PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d),
+	[PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08),
+	[PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08),
+	[PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d),
+	[PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b),
+};
+
 static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
 	.reg_ofs = exynos_reg_ofs,
 	.plltmr_reg = 0x50,
@@ -426,6 +444,19 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
 	.quirks = DSIM_QUIRK_PLAT_DATA,
 };
 
+static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = {
+	.reg_ofs = exynos5433_reg_ofs,
+	.plltmr_reg = 0xa0,
+	.has_clklane_stop = 1,
+	.num_clks = 2,
+	.max_freq = 2100,
+	.wait_for_reset = 0,
+	.num_bits_resol = 12,
+	.pll_p_offset = 14,
+	.reg_values = imx8mm_dsim_reg_values,
+	.quirks = DSIM_QUIRK_FIXUP_SYNC_POL,
+};
+
 static const struct of_device_id samsung_dsim_of_match[] = {
 	{
 		.compatible = "samsung,exynos3250-mipi-dsi",
@@ -447,6 +478,10 @@ static const struct of_device_id samsung_dsim_of_match[] = {
 		.compatible = "samsung,exynos5433-mipi-dsi",
 		.data = &exynos5433_dsi_driver_data
 	},
+	{
+		.compatible = "fsl,imx8mm-mipi-dsim",
+		.data = &imx8mm_dsi_driver_data
+	},
 	{ /* sentinel. */ }
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset
  2022-08-29 18:40 ` [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
@ 2022-08-29 19:42   ` Adam Ford
  2022-09-14  8:22     ` Jagan Teki
  0 siblings, 1 reply; 25+ messages in thread
From: Adam Ford @ 2022-08-29 19:42 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Neil Armstrong,
	Robert Foss, Laurent Pinchart, Tommaso Merciai, Marek Vasut,
	Matteo Lisi, dri-devel, linux-samsung-soc, arm-soc,
	NXP Linux Team, linux-amarula

On Mon, Aug 29, 2022 at 1:41 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> The i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> with 13.7.10.1 Master PLL PMS Value setting Register mentioned PMS_P offset
> range from BIT[18-13] and the upstream driver is using the same offset.
>
> However, offset 13 is not working on i.MX8M Mini platforms but downstream
> NXP driver is using 14 [1] and it is working with i.MX8M Mini SoC.

From the line you highlighted in the link, the downstream NXP ones
shows 13 if I'm reading it correctly.

#define PLLCTRL_SET_P(x) REG_PUT(x, 18, 13)

From what I can tell the PMS calculation here needs to be updated for
the Mini because the ranges of the FCO calculator are different.  Took
your series and tweaked it a bit [2] which changes a few settings, and
the PMS calculator appears to more closely match the values I get from
the NXP one.  I think it could be further tweaked because p min and
p_max also have changed.

>
> Not sure about whether it is reference manual documentation or something
> else but this patch trusts the downstream code and fixes the PLL_P offset.
>
> [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211
>

[2] -https://github.com/aford173/linux/commit/a5fa184160ec9ea45a7546eaa0d8b8fc760cf3d9

> v4, v3, v2:
> * none
>
> v1:
> * updated commit message
> * add downstream driver link
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++++--
>  include/drm/bridge/samsung-dsim.h     |  1 +
>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index b6883a6d4681..b6d17c0c9e58 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -168,7 +168,7 @@
>  /* DSIM_PLLCTRL */
>  #define DSIM_FREQ_BAND(x)              ((x) << 24)
>  #define DSIM_PLL_EN                    (1 << 23)
> -#define DSIM_PLL_P(x)                  ((x) << 13)
> +#define DSIM_PLL_P(x, offset)          ((x) << (offset))
>  #define DSIM_PLL_M(x)                  ((x) << 4)
>  #define DSIM_PLL_S(x)                  ((x) << 1)
>
> @@ -368,6 +368,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
>         .max_freq = 1000,
>         .wait_for_reset = 1,
>         .num_bits_resol = 11,
> +       .pll_p_offset = 13,
>         .reg_values = reg_values,
>         .quirks = DSIM_QUIRK_PLAT_DATA,
>  };
> @@ -381,6 +382,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
>         .max_freq = 1000,
>         .wait_for_reset = 1,
>         .num_bits_resol = 11,
> +       .pll_p_offset = 13,
>         .reg_values = reg_values,
>         .quirks = DSIM_QUIRK_PLAT_DATA,
>  };
> @@ -392,6 +394,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
>         .max_freq = 1000,
>         .wait_for_reset = 1,
>         .num_bits_resol = 11,
> +       .pll_p_offset = 13,
>         .reg_values = reg_values,
>         .quirks = DSIM_QUIRK_PLAT_DATA,
>  };
> @@ -404,6 +407,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
>         .max_freq = 1500,
>         .wait_for_reset = 0,
>         .num_bits_resol = 12,
> +       .pll_p_offset = 13,
>         .reg_values = exynos5433_reg_values,
>         .quirks = DSIM_QUIRK_PLAT_DATA,
>  };
> @@ -416,6 +420,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
>         .max_freq = 1500,
>         .wait_for_reset = 1,
>         .num_bits_resol = 12,
> +       .pll_p_offset = 13,
>         .reg_values = exynos5422_reg_values,
>         .quirks = DSIM_QUIRK_PLAT_DATA,
>  };
> @@ -563,7 +568,8 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi,
>         writel(driver_data->reg_values[PLL_TIMER],
>                         dsi->reg_base + driver_data->plltmr_reg);
>
> -       reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s);
> +       reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) |
> +             DSIM_PLL_M(m) | DSIM_PLL_S(s);
>
>         if (driver_data->has_freqband) {
>                 static const unsigned long freq_bands[] = {
> diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
> index e15fbfd49efe..95d3f89aec4f 100644
> --- a/include/drm/bridge/samsung-dsim.h
> +++ b/include/drm/bridge/samsung-dsim.h
> @@ -47,6 +47,7 @@ struct samsung_dsim_driver_data {
>         unsigned int max_freq;
>         unsigned int wait_for_reset;
>         unsigned int num_bits_resol;
> +       unsigned int pll_p_offset;
>         const unsigned int *reg_values;
>         enum samsung_dsim_quirks quirks;
>  };
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
       [not found]   ` <20220829184031.1863663-3-jagan@amarulasolutions.com>
@ 2022-09-02 10:47     ` Marek Szyprowski
  2022-09-05 11:24       ` Marek Szyprowski
  0 siblings, 1 reply; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-02 10:47 UTC (permalink / raw)
  To: Jagan Teki, Andrzej Hajda, Inki Dae, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula

On 29.08.2022 20:40, Jagan Teki wrote:
> Samsung MIPI DSIM controller is common DSI IP that can be used in various
> SoCs like Exynos, i.MX8M Mini/Nano.
>
> In order to access this DSI controller between various platform SoCs,
> the ideal way to incorporate this in the drm stack is via the drm bridge
> driver.
>
> This patch is trying to differentiate platform-specific and bridge driver
> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
> glue code and samsung-dsim.c as a common bridge driver code.
>
> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>    detach code along with conventional component_ops.
>
> - Samsung DSIM is a bridge driver which is common across all platforms and
>    the respective platform-specific glue will initialize at the end of the
>    probe. The platform-specific operations and other glue calls will invoke
>    on associate code areas.
>
> v4:
> * include Inki Dae in MAINTAINERS
> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build

This breaks Exynos DRM completely as the Exynos DRM driver is not able 
to wait until the DSI driver is probed and registered as component.

I will show how to rework this the way it is done in 
drivers/gpu/drm/exynos/exynos_dp.c and 
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...

> v3:
> * restore gpio related fixes
> * restore proper bridge chain
> * rework initialization issue
> * fix header includes in proper way
>
> v2:
> * fixed exynos dsi driver conversion (Marek Szyprowski)
> * updated commit message
> * updated MAINTAINERS file
>
> v1:
> * don't maintain component_ops in bridge driver
> * don't maintain platform glue code in bridge driver
> * add platform-specific glue code and make a common bridge
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>   MAINTAINERS                             |    9 +
>   drivers/gpu/drm/bridge/Kconfig          |   12 +
>   drivers/gpu/drm/bridge/Makefile         |    1 +
>   drivers/gpu/drm/bridge/samsung-dsim.c   | 1686 ++++++++++++++++++++++
>   drivers/gpu/drm/exynos/Kconfig          |    1 +
>   drivers/gpu/drm/exynos/exynos_drm_drv.c |    3 -
>   drivers/gpu/drm/exynos/exynos_drm_drv.h |    1 -
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1715 +----------------------
>   include/drm/bridge/samsung-dsim.h       |   99 ++
>   9 files changed, 1868 insertions(+), 1659 deletions(-)
>   create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
>   create mode 100644 include/drm/bridge/samsung-dsim.h
>
> ...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-02 10:47     ` [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver Marek Szyprowski
@ 2022-09-05 11:24       ` Marek Szyprowski
  2022-09-06 19:07         ` Jagan Teki
  0 siblings, 1 reply; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-05 11:24 UTC (permalink / raw)
  To: Jagan Teki, Andrzej Hajda, Inki Dae, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Adam Ford,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Tommaso Merciai,
	Marek Vasut
  Cc: Matteo Lisi, dri-devel, linux-samsung-soc, linux-arm-kernel,
	NXP Linux Team, linux-amarula

Hi All,

On 02.09.2022 12:47, Marek Szyprowski wrote:
> On 29.08.2022 20:40, Jagan Teki wrote:
>> Samsung MIPI DSIM controller is common DSI IP that can be used in 
>> various
>> SoCs like Exynos, i.MX8M Mini/Nano.
>>
>> In order to access this DSI controller between various platform SoCs,
>> the ideal way to incorporate this in the drm stack is via the drm bridge
>> driver.
>>
>> This patch is trying to differentiate platform-specific and bridge 
>> driver
>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>> glue code and samsung-dsim.c as a common bridge driver code.
>>
>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>    detach code along with conventional component_ops.
>>
>> - Samsung DSIM is a bridge driver which is common across all 
>> platforms and
>>    the respective platform-specific glue will initialize at the end 
>> of the
>>    probe. The platform-specific operations and other glue calls will 
>> invoke
>>    on associate code areas.
>>
>> v4:
>> * include Inki Dae in MAINTAINERS
>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>
> This breaks Exynos DRM completely as the Exynos DRM driver is not able 
> to wait until the DSI driver is probed and registered as component.
>
> I will show how to rework this the way it is done in 
> drivers/gpu/drm/exynos/exynos_dp.c and 
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...

I've finally had some time to implement such approach, see 
https://github.com/mszyprow/linux/tree/v6.0-dsi-v4-reworked

If you want me to send the patches against your v4 patchset, let me 
know, but imho my changes are much more readable after squashing to the 
original patches.

Now the driver is fully multi-arch safe and ready for further 
extensions. I've removed the weak functions, reworked the way the 
plat_data is used (dropped the patch related to it) and restored 
exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel 
free to resend the above as v5 after testing on your hardware. At least 
it properly works now on all Exynos boards I have, both compiled into 
the kernel or as modules.

>
>> v3:
>> * restore gpio related fixes
>> * restore proper bridge chain
>> * rework initialization issue
>> * fix header includes in proper way
>>
>> v2:
>> * fixed exynos dsi driver conversion (Marek Szyprowski)
>> * updated commit message
>> * updated MAINTAINERS file
>>
>> v1:
>> * don't maintain component_ops in bridge driver
>> * don't maintain platform glue code in bridge driver
>> * add platform-specific glue code and make a common bridge
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>>   MAINTAINERS                             |    9 +
>>   drivers/gpu/drm/bridge/Kconfig          |   12 +
>>   drivers/gpu/drm/bridge/Makefile         |    1 +
>>   drivers/gpu/drm/bridge/samsung-dsim.c   | 1686 ++++++++++++++++++++++
>>   drivers/gpu/drm/exynos/Kconfig          |    1 +
>>   drivers/gpu/drm/exynos/exynos_drm_drv.c |    3 -
>>   drivers/gpu/drm/exynos/exynos_drm_drv.h |    1 -
>>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1715 +----------------------
>>   include/drm/bridge/samsung-dsim.h       |   99 ++
>>   9 files changed, 1868 insertions(+), 1659 deletions(-)
>>   create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
>>   create mode 100644 include/drm/bridge/samsung-dsim.h
>>
>> ...
>
> Best regards

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-05 11:24       ` Marek Szyprowski
@ 2022-09-06 19:07         ` Jagan Teki
  2022-09-07 10:04           ` Marek Szyprowski
  0 siblings, 1 reply; 25+ messages in thread
From: Jagan Teki @ 2022-09-06 19:07 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Andrzej Hajda, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, Frieder Schrempf, Fancy Fang, Tim Harvey,
	Michael Nazzareno Trimarchi, Adam Ford, Neil Armstrong,
	Robert Foss, Laurent Pinchart, Tommaso Merciai, Marek Vasut,
	linux-samsung-soc, Matteo Lisi, dri-devel, NXP Linux Team,
	linux-amarula, linux-arm-kernel

On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Hi All,
>
> On 02.09.2022 12:47, Marek Szyprowski wrote:
> > On 29.08.2022 20:40, Jagan Teki wrote:
> >> Samsung MIPI DSIM controller is common DSI IP that can be used in
> >> various
> >> SoCs like Exynos, i.MX8M Mini/Nano.
> >>
> >> In order to access this DSI controller between various platform SoCs,
> >> the ideal way to incorporate this in the drm stack is via the drm bridge
> >> driver.
> >>
> >> This patch is trying to differentiate platform-specific and bridge
> >> driver
> >> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
> >> glue code and samsung-dsim.c as a common bridge driver code.
> >>
> >> - Exynos specific glue code is exynos specific te_irq, host_attach, and
> >>    detach code along with conventional component_ops.
> >>
> >> - Samsung DSIM is a bridge driver which is common across all
> >> platforms and
> >>    the respective platform-specific glue will initialize at the end
> >> of the
> >>    probe. The platform-specific operations and other glue calls will
> >> invoke
> >>    on associate code areas.
> >>
> >> v4:
> >> * include Inki Dae in MAINTAINERS
> >> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> >
> > This breaks Exynos DRM completely as the Exynos DRM driver is not able
> > to wait until the DSI driver is probed and registered as component.
> >
> > I will show how to rework this the way it is done in
> > drivers/gpu/drm/exynos/exynos_dp.c and
> > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>
> I've finally had some time to implement such approach, see
> https://github.com/mszyprow/linux/tree/v6.0-dsi-v4-reworked
>
> If you want me to send the patches against your v4 patchset, let me
> know, but imho my changes are much more readable after squashing to the
> original patches.
>
> Now the driver is fully multi-arch safe and ready for further
> extensions. I've removed the weak functions, reworked the way the
> plat_data is used (dropped the patch related to it) and restored
> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
> free to resend the above as v5 after testing on your hardware. At least
> it properly works now on all Exynos boards I have, both compiled into
> the kernel or as modules.

Thanks. I've seen the repo added on top of Dave patches - does it mean
these depends on Dave changes as well?

Jagan.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-06 19:07         ` Jagan Teki
@ 2022-09-07 10:04           ` Marek Szyprowski
  2022-09-12 14:52             ` Frieder Schrempf
  2022-09-13 17:29             ` Jagan Teki
  0 siblings, 2 replies; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-07 10:04 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Andrzej Hajda, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, Frieder Schrempf, Fancy Fang, Tim Harvey,
	Michael Nazzareno Trimarchi, Adam Ford, Neil Armstrong,
	Robert Foss, Laurent Pinchart, Tommaso Merciai, Marek Vasut,
	linux-samsung-soc, Matteo Lisi, dri-devel, NXP Linux Team,
	linux-amarula, linux-arm-kernel

Hi Jagan,

On 06.09.2022 21:07, Jagan Teki wrote:
> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>>>> various
>>>> SoCs like Exynos, i.MX8M Mini/Nano.
>>>>
>>>> In order to access this DSI controller between various platform SoCs,
>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
>>>> driver.
>>>>
>>>> This patch is trying to differentiate platform-specific and bridge
>>>> driver
>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>>>> glue code and samsung-dsim.c as a common bridge driver code.
>>>>
>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>>>     detach code along with conventional component_ops.
>>>>
>>>> - Samsung DSIM is a bridge driver which is common across all
>>>> platforms and
>>>>     the respective platform-specific glue will initialize at the end
>>>> of the
>>>>     probe. The platform-specific operations and other glue calls will
>>>> invoke
>>>>     on associate code areas.
>>>>
>>>> v4:
>>>> * include Inki Dae in MAINTAINERS
>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
>>> to wait until the DSI driver is probed and registered as component.
>>>
>>> I will show how to rework this the way it is done in
>>> drivers/gpu/drm/exynos/exynos_dp.c and
>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>> I've finally had some time to implement such approach, see
>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
>>
>> If you want me to send the patches against your v4 patchset, let me
>> know, but imho my changes are much more readable after squashing to the
>> original patches.
>>
>> Now the driver is fully multi-arch safe and ready for further
>> extensions. I've removed the weak functions, reworked the way the
>> plat_data is used (dropped the patch related to it) and restored
>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
>> free to resend the above as v5 after testing on your hardware. At least
>> it properly works now on all Exynos boards I have, both compiled into
>> the kernel or as modules.
> Thanks. I've seen the repo added on top of Dave patches - does it mean
> these depends on Dave changes as well?

Yes and no. My rework doesn't change anything with this dependency. It 
comes from my patch "drm: exynos: dsi: Restore proper bridge chain 
order" already included in your series (patch #1). Without it exynos-dsi 
driver hacks the list of bridges to ensure the order of pre_enable calls 
needed for proper operation. This works somehow with DSI panels on my 
test systems, but it has been reported that it doesn't work with a bit 
more complex display pipelines. Only that patch depends on the Dave's 
patches. If you remove it, you would need to adjust the code in the 
exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be 
better to keep it and merge Dave's patches together with dsi changes, as 
they are the first real client of it.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-07 10:04           ` Marek Szyprowski
@ 2022-09-12 14:52             ` Frieder Schrempf
  2022-09-13 17:29             ` Jagan Teki
  1 sibling, 0 replies; 25+ messages in thread
From: Frieder Schrempf @ 2022-09-12 14:52 UTC (permalink / raw)
  To: Marek Szyprowski, Jagan Teki
  Cc: Andrzej Hajda, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, Fancy Fang, Tim Harvey,
	Michael Nazzareno Trimarchi, Adam Ford, Neil Armstrong,
	Robert Foss, Laurent Pinchart, Tommaso Merciai, Marek Vasut,
	linux-samsung-soc, Matteo Lisi, dri-devel, NXP Linux Team,
	linux-amarula, linux-arm-kernel

Hi Jagan, Marek,

Am 07.09.22 um 12:04 schrieb Marek Szyprowski:
> Hi Jagan,
> 
> On 06.09.2022 21:07, Jagan Teki wrote:
>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
>> <m.szyprowski@samsung.com> wrote:
>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>>>>> various
>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
>>>>>
>>>>> In order to access this DSI controller between various platform SoCs,
>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
>>>>> driver.
>>>>>
>>>>> This patch is trying to differentiate platform-specific and bridge
>>>>> driver
>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>>>>> glue code and samsung-dsim.c as a common bridge driver code.
>>>>>
>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>>>>     detach code along with conventional component_ops.
>>>>>
>>>>> - Samsung DSIM is a bridge driver which is common across all
>>>>> platforms and
>>>>>     the respective platform-specific glue will initialize at the end
>>>>> of the
>>>>>     probe. The platform-specific operations and other glue calls will
>>>>> invoke
>>>>>     on associate code areas.
>>>>>
>>>>> v4:
>>>>> * include Inki Dae in MAINTAINERS
>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
>>>> to wait until the DSI driver is probed and registered as component.
>>>>
>>>> I will show how to rework this the way it is done in
>>>> drivers/gpu/drm/exynos/exynos_dp.c and
>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>>> I've finally had some time to implement such approach, see
>>> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprotect2.fireeye.com%2Fv1%2Furl%3Fk%3Dc5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375%26q%3D1%26e%3D489b94d4-84fb-408e-b679-a8d27acf2930%26u%3Dhttps%253A%252F%252Fgithub.com%252Fmszyprow%252Flinux%252Ftree%252Fv6.0-dsi-v4-reworked&amp;data=05%7C01%7Cfrieder.schrempf%40kontron.de%7C8ed9bd90703b48c9d43708da90b86876%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C637981418959345104%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=vLwOMBbdNo1C5x%2BESY3SU%2FwaYKBmAgIyafLOLmd3BlM%3D&amp;reserved=0
>>>
>>> If you want me to send the patches against your v4 patchset, let me
>>> know, but imho my changes are much more readable after squashing to the
>>> original patches.
>>>
>>> Now the driver is fully multi-arch safe and ready for further
>>> extensions. I've removed the weak functions, reworked the way the
>>> plat_data is used (dropped the patch related to it) and restored
>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
>>> free to resend the above as v5 after testing on your hardware. At least
>>> it properly works now on all Exynos boards I have, both compiled into
>>> the kernel or as modules.
>> Thanks. I've seen the repo added on top of Dave patches - does it mean
>> these depends on Dave changes as well?
> 
> Yes and no. My rework doesn't change anything with this dependency. It 
> comes from my patch "drm: exynos: dsi: Restore proper bridge chain 
> order" already included in your series (patch #1). Without it exynos-dsi 
> driver hacks the list of bridges to ensure the order of pre_enable calls 
> needed for proper operation. This works somehow with DSI panels on my 
> test systems, but it has been reported that it doesn't work with a bit 
> more complex display pipelines. Only that patch depends on the Dave's 
> patches. If you remove it, you would need to adjust the code in the 
> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be 
> better to keep it and merge Dave's patches together with dsi changes, as 
> they are the first real client of it.

I tried to test Jagan's v4 on our Kontron BL i.MX8MM with SN65DSI84 LVDS
bridge and it didn't work due to driver dependency issues.

Instead trying Marek's branch rebased to 6.0-rc4 and including the
necessary DT changes from Jagan's v4 looks good and produces an image on
the display.

Only one thing caused problems: In Jagan's patch for the LCDIF node [1]
there's a typo (missing 's') in the assigned-clock-rates property.
Without fixing this the display doesn't work.

Jagan, can you come up with a v5 including Marek's fixes?
And if you like, I think you could also start sending the DT changes for
i.MX8MM, so we can start reviewing/testing them?

Thanks
Frieder

[1]:
https://github.com/openedev/kernel/commit/89a6252cec47f3593d4f2b7ea3132f4745c4fdb3

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-07 10:04           ` Marek Szyprowski
  2022-09-12 14:52             ` Frieder Schrempf
@ 2022-09-13 17:29             ` Jagan Teki
  2022-09-14  9:21               ` Marek Szyprowski
  1 sibling, 1 reply; 25+ messages in thread
From: Jagan Teki @ 2022-09-13 17:29 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Hi Jagan,
>
> On 06.09.2022 21:07, Jagan Teki wrote:
> > On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
> > <m.szyprowski@samsung.com> wrote:
> >> On 02.09.2022 12:47, Marek Szyprowski wrote:
> >>> On 29.08.2022 20:40, Jagan Teki wrote:
> >>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
> >>>> various
> >>>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>>
> >>>> In order to access this DSI controller between various platform SoCs,
> >>>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>>> driver.
> >>>>
> >>>> This patch is trying to differentiate platform-specific and bridge
> >>>> driver
> >>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
> >>>> glue code and samsung-dsim.c as a common bridge driver code.
> >>>>
> >>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
> >>>>     detach code along with conventional component_ops.
> >>>>
> >>>> - Samsung DSIM is a bridge driver which is common across all
> >>>> platforms and
> >>>>     the respective platform-specific glue will initialize at the end
> >>>> of the
> >>>>     probe. The platform-specific operations and other glue calls will
> >>>> invoke
> >>>>     on associate code areas.
> >>>>
> >>>> v4:
> >>>> * include Inki Dae in MAINTAINERS
> >>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> >>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
> >>> to wait until the DSI driver is probed and registered as component.
> >>>
> >>> I will show how to rework this the way it is done in
> >>> drivers/gpu/drm/exynos/exynos_dp.c and
> >>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
> >> I've finally had some time to implement such approach, see
> >> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
> >>
> >> If you want me to send the patches against your v4 patchset, let me
> >> know, but imho my changes are much more readable after squashing to the
> >> original patches.
> >>
> >> Now the driver is fully multi-arch safe and ready for further
> >> extensions. I've removed the weak functions, reworked the way the
> >> plat_data is used (dropped the patch related to it) and restored
> >> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
> >> free to resend the above as v5 after testing on your hardware. At least
> >> it properly works now on all Exynos boards I have, both compiled into
> >> the kernel or as modules.
> > Thanks. I've seen the repo added on top of Dave patches - does it mean
> > these depends on Dave changes as well?
>
> Yes and no. My rework doesn't change anything with this dependency. It
> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
> order" already included in your series (patch #1). Without it exynos-dsi
> driver hacks the list of bridges to ensure the order of pre_enable calls
> needed for proper operation. This works somehow with DSI panels on my
> test systems, but it has been reported that it doesn't work with a bit
> more complex display pipelines. Only that patch depends on the Dave's
> patches. If you remove it, you would need to adjust the code in the
> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
> better to keep it and merge Dave's patches together with dsi changes, as
> they are the first real client of it.

I think the Dave patches especially "drm/bridge: Introduce
pre_enable_upstream_first to alter bridge init order" seems not 100%
relevant to this series as they affect bridge chain call flow
globally. Having a separate series for that makes sense to me. I'm
sending v5 by excluding those parts.

Jagan.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset
  2022-08-29 19:42   ` Adam Ford
@ 2022-09-14  8:22     ` Jagan Teki
  0 siblings, 0 replies; 25+ messages in thread
From: Jagan Teki @ 2022-09-14  8:22 UTC (permalink / raw)
  To: Adam Ford
  Cc: Andrzej Hajda, Inki Dae, Marek Szyprowski, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, Frieder Schrempf, Fancy Fang,
	Tim Harvey, Michael Nazzareno Trimarchi, Neil Armstrong,
	Robert Foss, Laurent Pinchart, Tommaso Merciai, Marek Vasut,
	Matteo Lisi, dri-devel, linux-samsung-soc, arm-soc,
	NXP Linux Team, linux-amarula

On Tue, Aug 30, 2022 at 1:12 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Mon, Aug 29, 2022 at 1:41 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > The i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> > with 13.7.10.1 Master PLL PMS Value setting Register mentioned PMS_P offset
> > range from BIT[18-13] and the upstream driver is using the same offset.
> >
> > However, offset 13 is not working on i.MX8M Mini platforms but downstream
> > NXP driver is using 14 [1] and it is working with i.MX8M Mini SoC.
>
> From the line you highlighted in the link, the downstream NXP ones
> shows 13 if I'm reading it correctly.
>
> #define PLLCTRL_SET_P(x) REG_PUT(x, 18, 13)

PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P()
with offset 13 and then an additional offset of one bit added in
sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS().

Please check this for additional information
https://github.com/fschrempf/linux/commit/bbb3549a99e162ef6ad4c83d5fd4d39a6daa6d56

I'll update the additional information in commit messages in v5.

Thanks,
Jagan.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-13 17:29             ` Jagan Teki
@ 2022-09-14  9:21               ` Marek Szyprowski
  2022-09-14  9:39                 ` Jagan Teki
  0 siblings, 1 reply; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-14  9:21 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

Hi Jagan,

On 13.09.2022 19:29, Jagan Teki wrote:
> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> On 06.09.2022 21:07, Jagan Teki wrote:
>>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
>>> <m.szyprowski@samsung.com> wrote:
>>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>>>>>> various
>>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
>>>>>>
>>>>>> In order to access this DSI controller between various platform SoCs,
>>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
>>>>>> driver.
>>>>>>
>>>>>> This patch is trying to differentiate platform-specific and bridge
>>>>>> driver
>>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>>>>>> glue code and samsung-dsim.c as a common bridge driver code.
>>>>>>
>>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>>>>>      detach code along with conventional component_ops.
>>>>>>
>>>>>> - Samsung DSIM is a bridge driver which is common across all
>>>>>> platforms and
>>>>>>      the respective platform-specific glue will initialize at the end
>>>>>> of the
>>>>>>      probe. The platform-specific operations and other glue calls will
>>>>>> invoke
>>>>>>      on associate code areas.
>>>>>>
>>>>>> v4:
>>>>>> * include Inki Dae in MAINTAINERS
>>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
>>>>> to wait until the DSI driver is probed and registered as component.
>>>>>
>>>>> I will show how to rework this the way it is done in
>>>>> drivers/gpu/drm/exynos/exynos_dp.c and
>>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>>>> I've finally had some time to implement such approach, see
>>>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
>>>>
>>>> If you want me to send the patches against your v4 patchset, let me
>>>> know, but imho my changes are much more readable after squashing to the
>>>> original patches.
>>>>
>>>> Now the driver is fully multi-arch safe and ready for further
>>>> extensions. I've removed the weak functions, reworked the way the
>>>> plat_data is used (dropped the patch related to it) and restored
>>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
>>>> free to resend the above as v5 after testing on your hardware. At least
>>>> it properly works now on all Exynos boards I have, both compiled into
>>>> the kernel or as modules.
>>> Thanks. I've seen the repo added on top of Dave patches - does it mean
>>> these depends on Dave changes as well?
>> Yes and no. My rework doesn't change anything with this dependency. It
>> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
>> order" already included in your series (patch #1). Without it exynos-dsi
>> driver hacks the list of bridges to ensure the order of pre_enable calls
>> needed for proper operation. This works somehow with DSI panels on my
>> test systems, but it has been reported that it doesn't work with a bit
>> more complex display pipelines. Only that patch depends on the Dave's
>> patches. If you remove it, you would need to adjust the code in the
>> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
>> better to keep it and merge Dave's patches together with dsi changes, as
>> they are the first real client of it.
> I think the Dave patches especially "drm/bridge: Introduce
> pre_enable_upstream_first to alter bridge init order" seems not 100%
> relevant to this series as they affect bridge chain call flow
> globally. Having a separate series for that makes sense to me. I'm
> sending v5 by excluding those parts.

If so then drop the "drm: exynos: dsi: Restore proper bridge chain 
order" patch and adjust code respectively in samsung-dsim.c. Without the 
Dave's patches, that one doesn't make sense.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-14  9:21               ` Marek Szyprowski
@ 2022-09-14  9:39                 ` Jagan Teki
  2022-09-16  8:28                   ` Marek Szyprowski
  0 siblings, 1 reply; 25+ messages in thread
From: Jagan Teki @ 2022-09-14  9:39 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Hi Jagan,
>
> On 13.09.2022 19:29, Jagan Teki wrote:
> > On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
> > <m.szyprowski@samsung.com> wrote:
> >> On 06.09.2022 21:07, Jagan Teki wrote:
> >>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
> >>> <m.szyprowski@samsung.com> wrote:
> >>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
> >>>>> On 29.08.2022 20:40, Jagan Teki wrote:
> >>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
> >>>>>> various
> >>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>>>>
> >>>>>> In order to access this DSI controller between various platform SoCs,
> >>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>>>>> driver.
> >>>>>>
> >>>>>> This patch is trying to differentiate platform-specific and bridge
> >>>>>> driver
> >>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
> >>>>>> glue code and samsung-dsim.c as a common bridge driver code.
> >>>>>>
> >>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
> >>>>>>      detach code along with conventional component_ops.
> >>>>>>
> >>>>>> - Samsung DSIM is a bridge driver which is common across all
> >>>>>> platforms and
> >>>>>>      the respective platform-specific glue will initialize at the end
> >>>>>> of the
> >>>>>>      probe. The platform-specific operations and other glue calls will
> >>>>>> invoke
> >>>>>>      on associate code areas.
> >>>>>>
> >>>>>> v4:
> >>>>>> * include Inki Dae in MAINTAINERS
> >>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> >>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
> >>>>> to wait until the DSI driver is probed and registered as component.
> >>>>>
> >>>>> I will show how to rework this the way it is done in
> >>>>> drivers/gpu/drm/exynos/exynos_dp.c and
> >>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
> >>>> I've finally had some time to implement such approach, see
> >>>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
> >>>>
> >>>> If you want me to send the patches against your v4 patchset, let me
> >>>> know, but imho my changes are much more readable after squashing to the
> >>>> original patches.
> >>>>
> >>>> Now the driver is fully multi-arch safe and ready for further
> >>>> extensions. I've removed the weak functions, reworked the way the
> >>>> plat_data is used (dropped the patch related to it) and restored
> >>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
> >>>> free to resend the above as v5 after testing on your hardware. At least
> >>>> it properly works now on all Exynos boards I have, both compiled into
> >>>> the kernel or as modules.
> >>> Thanks. I've seen the repo added on top of Dave patches - does it mean
> >>> these depends on Dave changes as well?
> >> Yes and no. My rework doesn't change anything with this dependency. It
> >> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
> >> order" already included in your series (patch #1). Without it exynos-dsi
> >> driver hacks the list of bridges to ensure the order of pre_enable calls
> >> needed for proper operation. This works somehow with DSI panels on my
> >> test systems, but it has been reported that it doesn't work with a bit
> >> more complex display pipelines. Only that patch depends on the Dave's
> >> patches. If you remove it, you would need to adjust the code in the
> >> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
> >> better to keep it and merge Dave's patches together with dsi changes, as
> >> they are the first real client of it.
> > I think the Dave patches especially "drm/bridge: Introduce
> > pre_enable_upstream_first to alter bridge init order" seems not 100%
> > relevant to this series as they affect bridge chain call flow
> > globally. Having a separate series for that makes sense to me. I'm
> > sending v5 by excluding those parts.
>
> If so then drop the "drm: exynos: dsi: Restore proper bridge chain
> order" patch and adjust code respectively in samsung-dsim.c. Without the
> Dave's patches, that one doesn't make sense.

Doesn't it break Exynos?

Jagan.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-14  9:39                 ` Jagan Teki
@ 2022-09-16  8:28                   ` Marek Szyprowski
  2022-09-16 10:21                     ` Jagan Teki
  0 siblings, 1 reply; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-16  8:28 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

Hi Jagan,

On 14.09.2022 11:39, Jagan Teki wrote:
> On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> On 13.09.2022 19:29, Jagan Teki wrote:
>>> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
>>> <m.szyprowski@samsung.com> wrote:
>>>> On 06.09.2022 21:07, Jagan Teki wrote:
>>>>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
>>>>> <m.szyprowski@samsung.com> wrote:
>>>>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>>>>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>>>>>>>> various
>>>>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
>>>>>>>>
>>>>>>>> In order to access this DSI controller between various platform SoCs,
>>>>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
>>>>>>>> driver.
>>>>>>>>
>>>>>>>> This patch is trying to differentiate platform-specific and bridge
>>>>>>>> driver
>>>>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>>>>>>>> glue code and samsung-dsim.c as a common bridge driver code.
>>>>>>>>
>>>>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>>>>>>>       detach code along with conventional component_ops.
>>>>>>>>
>>>>>>>> - Samsung DSIM is a bridge driver which is common across all
>>>>>>>> platforms and
>>>>>>>>       the respective platform-specific glue will initialize at the end
>>>>>>>> of the
>>>>>>>>       probe. The platform-specific operations and other glue calls will
>>>>>>>> invoke
>>>>>>>>       on associate code areas.
>>>>>>>>
>>>>>>>> v4:
>>>>>>>> * include Inki Dae in MAINTAINERS
>>>>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>>>>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
>>>>>>> to wait until the DSI driver is probed and registered as component.
>>>>>>>
>>>>>>> I will show how to rework this the way it is done in
>>>>>>> drivers/gpu/drm/exynos/exynos_dp.c and
>>>>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>>>>>> I've finally had some time to implement such approach, see
>>>>>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
>>>>>>
>>>>>> If you want me to send the patches against your v4 patchset, let me
>>>>>> know, but imho my changes are much more readable after squashing to the
>>>>>> original patches.
>>>>>>
>>>>>> Now the driver is fully multi-arch safe and ready for further
>>>>>> extensions. I've removed the weak functions, reworked the way the
>>>>>> plat_data is used (dropped the patch related to it) and restored
>>>>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
>>>>>> free to resend the above as v5 after testing on your hardware. At least
>>>>>> it properly works now on all Exynos boards I have, both compiled into
>>>>>> the kernel or as modules.
>>>>> Thanks. I've seen the repo added on top of Dave patches - does it mean
>>>>> these depends on Dave changes as well?
>>>> Yes and no. My rework doesn't change anything with this dependency. It
>>>> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
>>>> order" already included in your series (patch #1). Without it exynos-dsi
>>>> driver hacks the list of bridges to ensure the order of pre_enable calls
>>>> needed for proper operation. This works somehow with DSI panels on my
>>>> test systems, but it has been reported that it doesn't work with a bit
>>>> more complex display pipelines. Only that patch depends on the Dave's
>>>> patches. If you remove it, you would need to adjust the code in the
>>>> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
>>>> better to keep it and merge Dave's patches together with dsi changes, as
>>>> they are the first real client of it.
>>> I think the Dave patches especially "drm/bridge: Introduce
>>> pre_enable_upstream_first to alter bridge init order" seems not 100%
>>> relevant to this series as they affect bridge chain call flow
>>> globally. Having a separate series for that makes sense to me. I'm
>>> sending v5 by excluding those parts.
>> If so then drop the "drm: exynos: dsi: Restore proper bridge chain
>> order" patch and adjust code respectively in samsung-dsim.c. Without the
>> Dave's patches, that one doesn't make sense.
> Doesn't it break Exynos?

No it won't. Lack of the "drm: exynos: dsi: Restore proper bridge chain 
order" patch doesn't change much against the current state of the driver.

Here is my rework of your v4 patchset without the mentioned patch and 
Dave's patches:

https://github.com/mszyprow/linux/tree/v6.0-dsi-v4-reworked-minimal

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-16  8:28                   ` Marek Szyprowski
@ 2022-09-16 10:21                     ` Jagan Teki
  2022-09-19  6:22                       ` Marek Szyprowski
  0 siblings, 1 reply; 25+ messages in thread
From: Jagan Teki @ 2022-09-16 10:21 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

On Fri, Sep 16, 2022 at 1:58 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Hi Jagan,
>
> On 14.09.2022 11:39, Jagan Teki wrote:
> > On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
> > <m.szyprowski@samsung.com> wrote:
> >> On 13.09.2022 19:29, Jagan Teki wrote:
> >>> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
> >>> <m.szyprowski@samsung.com> wrote:
> >>>> On 06.09.2022 21:07, Jagan Teki wrote:
> >>>>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
> >>>>> <m.szyprowski@samsung.com> wrote:
> >>>>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
> >>>>>>> On 29.08.2022 20:40, Jagan Teki wrote:
> >>>>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
> >>>>>>>> various
> >>>>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>>>>>>
> >>>>>>>> In order to access this DSI controller between various platform SoCs,
> >>>>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>>>>>>> driver.
> >>>>>>>>
> >>>>>>>> This patch is trying to differentiate platform-specific and bridge
> >>>>>>>> driver
> >>>>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
> >>>>>>>> glue code and samsung-dsim.c as a common bridge driver code.
> >>>>>>>>
> >>>>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
> >>>>>>>>       detach code along with conventional component_ops.
> >>>>>>>>
> >>>>>>>> - Samsung DSIM is a bridge driver which is common across all
> >>>>>>>> platforms and
> >>>>>>>>       the respective platform-specific glue will initialize at the end
> >>>>>>>> of the
> >>>>>>>>       probe. The platform-specific operations and other glue calls will
> >>>>>>>> invoke
> >>>>>>>>       on associate code areas.
> >>>>>>>>
> >>>>>>>> v4:
> >>>>>>>> * include Inki Dae in MAINTAINERS
> >>>>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> >>>>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
> >>>>>>> to wait until the DSI driver is probed and registered as component.
> >>>>>>>
> >>>>>>> I will show how to rework this the way it is done in
> >>>>>>> drivers/gpu/drm/exynos/exynos_dp.c and
> >>>>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
> >>>>>> I've finally had some time to implement such approach, see
> >>>>>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
> >>>>>>
> >>>>>> If you want me to send the patches against your v4 patchset, let me
> >>>>>> know, but imho my changes are much more readable after squashing to the
> >>>>>> original patches.
> >>>>>>
> >>>>>> Now the driver is fully multi-arch safe and ready for further
> >>>>>> extensions. I've removed the weak functions, reworked the way the
> >>>>>> plat_data is used (dropped the patch related to it) and restored
> >>>>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
> >>>>>> free to resend the above as v5 after testing on your hardware. At least
> >>>>>> it properly works now on all Exynos boards I have, both compiled into
> >>>>>> the kernel or as modules.
> >>>>> Thanks. I've seen the repo added on top of Dave patches - does it mean
> >>>>> these depends on Dave changes as well?
> >>>> Yes and no. My rework doesn't change anything with this dependency. It
> >>>> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
> >>>> order" already included in your series (patch #1). Without it exynos-dsi
> >>>> driver hacks the list of bridges to ensure the order of pre_enable calls
> >>>> needed for proper operation. This works somehow with DSI panels on my
> >>>> test systems, but it has been reported that it doesn't work with a bit
> >>>> more complex display pipelines. Only that patch depends on the Dave's
> >>>> patches. If you remove it, you would need to adjust the code in the
> >>>> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
> >>>> better to keep it and merge Dave's patches together with dsi changes, as
> >>>> they are the first real client of it.
> >>> I think the Dave patches especially "drm/bridge: Introduce
> >>> pre_enable_upstream_first to alter bridge init order" seems not 100%
> >>> relevant to this series as they affect bridge chain call flow
> >>> globally. Having a separate series for that makes sense to me. I'm
> >>> sending v5 by excluding those parts.
> >> If so then drop the "drm: exynos: dsi: Restore proper bridge chain
> >> order" patch and adjust code respectively in samsung-dsim.c. Without the
> >> Dave's patches, that one doesn't make sense.
> > Doesn't it break Exynos?
>
> No it won't. Lack of the "drm: exynos: dsi: Restore proper bridge chain
> order" patch doesn't change much against the current state of the driver.
>
> Here is my rework of your v4 patchset without the mentioned patch and
> Dave's patches:
>
> https://github.com/mszyprow/linux/tree/v6.0-dsi-v4-reworked-minimal

We have one problem with getting bus format from previous bridge if we
pass NULL in bridge_func.attach()
https://github.com/mszyprow/linux/commit/0fa57e33b3bf866efc4c17ab20eec28d6e07b3e9#diff-3fe873f1ada5f1dfcf2a50ac114bdab3ea7b026d12278648ca40809d3fa1a331R1321

Booting the video as it assigns default bus format if the previous bus
format is unknown.

[    1.635984] samsung-dsim 32e10000.dsi:
[drm:samsung_dsim_host_attach] Attached sn65dsi83 device
[    1.648067] [drm] Initialized mxsfb-drm 1.0.0 20160824 for
32e00000.lcdif on minor 0
[    1.658726] mmc0: SDHCI controller on 30b40000.mmc [30b40000.mmc]
using ADMA
[    1.681893] sn65dsi83 3-002c: Unsupported LVDS bus format 0x100a,
please check output bridge driver. Falling back to SPWG24.

Does passing the bridge to drm_bridge_attach is working on your platform?
return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, flags);

Thanks,
Jagan.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver
  2022-09-16 10:21                     ` Jagan Teki
@ 2022-09-19  6:22                       ` Marek Szyprowski
  0 siblings, 0 replies; 25+ messages in thread
From: Marek Szyprowski @ 2022-09-19  6:22 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Marek Vasut, linux-samsung-soc, Joonyoung Shim, dri-devel,
	Neil Armstrong, linux-amarula, Seung-Woo Kim, Tommaso Merciai,
	Frieder Schrempf, Kyungmin Park, Matteo Lisi, Robert Foss,
	Andrzej Hajda, NXP Linux Team, Fancy Fang,
	Michael Nazzareno Trimarchi, Adam Ford, linux-arm-kernel,
	Laurent Pinchart

Hi Jagan,

On 16.09.2022 12:21, Jagan Teki wrote:
> On Fri, Sep 16, 2022 at 1:58 PM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> On 14.09.2022 11:39, Jagan Teki wrote:
>>> On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
>>> <m.szyprowski@samsung.com> wrote:
>>>> On 13.09.2022 19:29, Jagan Teki wrote:
>>>>> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
>>>>> <m.szyprowski@samsung.com> wrote:
>>>>>> On 06.09.2022 21:07, Jagan Teki wrote:
>>>>>>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
>>>>>>> <m.szyprowski@samsung.com> wrote:
>>>>>>>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>>>>>>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>>>>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>>>>>>>>>> various
>>>>>>>>>> SoCs like Exynos, i.MX8M Mini/Nano.
>>>>>>>>>>
>>>>>>>>>> In order to access this DSI controller between various platform SoCs,
>>>>>>>>>> the ideal way to incorporate this in the drm stack is via the drm bridge
>>>>>>>>>> driver.
>>>>>>>>>>
>>>>>>>>>> This patch is trying to differentiate platform-specific and bridge
>>>>>>>>>> driver
>>>>>>>>>> code and keep maintaining the exynos_drm_dsi.c code as platform-specific
>>>>>>>>>> glue code and samsung-dsim.c as a common bridge driver code.
>>>>>>>>>>
>>>>>>>>>> - Exynos specific glue code is exynos specific te_irq, host_attach, and
>>>>>>>>>>        detach code along with conventional component_ops.
>>>>>>>>>>
>>>>>>>>>> - Samsung DSIM is a bridge driver which is common across all
>>>>>>>>>> platforms and
>>>>>>>>>>        the respective platform-specific glue will initialize at the end
>>>>>>>>>> of the
>>>>>>>>>>        probe. The platform-specific operations and other glue calls will
>>>>>>>>>> invoke
>>>>>>>>>>        on associate code areas.
>>>>>>>>>>
>>>>>>>>>> v4:
>>>>>>>>>> * include Inki Dae in MAINTAINERS
>>>>>>>>>> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
>>>>>>>>> This breaks Exynos DRM completely as the Exynos DRM driver is not able
>>>>>>>>> to wait until the DSI driver is probed and registered as component.
>>>>>>>>>
>>>>>>>>> I will show how to rework this the way it is done in
>>>>>>>>> drivers/gpu/drm/exynos/exynos_dp.c and
>>>>>>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c soon...
>>>>>>>> I've finally had some time to implement such approach, see
>>>>>>>> https://protect2.fireeye.com/v1/url?k=c5d024d9-a4ab8e4e-c5d1af96-74fe4860001d-625a8324a9797375&q=1&e=489b94d4-84fb-408e-b679-a8d27acf2930&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked
>>>>>>>>
>>>>>>>> If you want me to send the patches against your v4 patchset, let me
>>>>>>>> know, but imho my changes are much more readable after squashing to the
>>>>>>>> original patches.
>>>>>>>>
>>>>>>>> Now the driver is fully multi-arch safe and ready for further
>>>>>>>> extensions. I've removed the weak functions, reworked the way the
>>>>>>>> plat_data is used (dropped the patch related to it) and restored
>>>>>>>> exynos-dsi driver as a part of the Exynos DRM drivers/subsystem. Feel
>>>>>>>> free to resend the above as v5 after testing on your hardware. At least
>>>>>>>> it properly works now on all Exynos boards I have, both compiled into
>>>>>>>> the kernel or as modules.
>>>>>>> Thanks. I've seen the repo added on top of Dave patches - does it mean
>>>>>>> these depends on Dave changes as well?
>>>>>> Yes and no. My rework doesn't change anything with this dependency. It
>>>>>> comes from my patch "drm: exynos: dsi: Restore proper bridge chain
>>>>>> order" already included in your series (patch #1). Without it exynos-dsi
>>>>>> driver hacks the list of bridges to ensure the order of pre_enable calls
>>>>>> needed for proper operation. This works somehow with DSI panels on my
>>>>>> test systems, but it has been reported that it doesn't work with a bit
>>>>>> more complex display pipelines. Only that patch depends on the Dave's
>>>>>> patches. If you remove it, you would need to adjust the code in the
>>>>>> exynos_drm_dsi.c and samsung-dsim.c respectively. imho it would be
>>>>>> better to keep it and merge Dave's patches together with dsi changes, as
>>>>>> they are the first real client of it.
>>>>> I think the Dave patches especially "drm/bridge: Introduce
>>>>> pre_enable_upstream_first to alter bridge init order" seems not 100%
>>>>> relevant to this series as they affect bridge chain call flow
>>>>> globally. Having a separate series for that makes sense to me. I'm
>>>>> sending v5 by excluding those parts.
>>>> If so then drop the "drm: exynos: dsi: Restore proper bridge chain
>>>> order" patch and adjust code respectively in samsung-dsim.c. Without the
>>>> Dave's patches, that one doesn't make sense.
>>> Doesn't it break Exynos?
>> No it won't. Lack of the "drm: exynos: dsi: Restore proper bridge chain
>> order" patch doesn't change much against the current state of the driver.
>>
>> Here is my rework of your v4 patchset without the mentioned patch and
>> Dave's patches:
>>
>> https://protect2.fireeye.com/v1/url?k=6282936d-3d19aa74-62831822-000babff3793-9317af6e2b207460&q=1&e=cd36cc51-8faa-4812-880a-8242739a86bd&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Ftree%2Fv6.0-dsi-v4-reworked-minimal
> We have one problem with getting bus format from previous bridge if we
> pass NULL in bridge_func.attach()
> https://protect2.fireeye.com/v1/url?k=bdc3e18a-e258d893-bdc26ac5-000babff3793-1dd81e5acf9d7f83&q=1&e=cd36cc51-8faa-4812-880a-8242739a86bd&u=https%3A%2F%2Fgithub.com%2Fmszyprow%2Flinux%2Fcommit%2F0fa57e33b3bf866efc4c17ab20eec28d6e07b3e9%23diff-3fe873f1ada5f1dfcf2a50ac114bdab3ea7b026d12278648ca40809d3fa1a331R1321
>
> Booting the video as it assigns default bus format if the previous bus
> format is unknown.
>
> [    1.635984] samsung-dsim 32e10000.dsi:
> [drm:samsung_dsim_host_attach] Attached sn65dsi83 device
> [    1.648067] [drm] Initialized mxsfb-drm 1.0.0 20160824 for
> 32e00000.lcdif on minor 0
> [    1.658726] mmc0: SDHCI controller on 30b40000.mmc [30b40000.mmc]
> using ADMA
> [    1.681893] sn65dsi83 3-002c: Unsupported LVDS bus format 0x100a,
> please check output bridge driver. Falling back to SPWG24.
>
> Does passing the bridge to drm_bridge_attach is working on your platform?
> return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, flags);

Nope, it fails:

[drm] Initialized exynos 1.1.0 20180330 for exynos-drm on minor 0
exynos-dsi 11c80000.dsi: [drm:samsung_dsim_host_attach] Attached s6e8aa0 
device
panel-samsung-s6e8aa0 11c80000.dsi.0: error -22 setting maximum return 
packet size to 3
panel-samsung-s6e8aa0 11c80000.dsi.0: read id failed

I've already pointed that it makes sense only together with Dave's patches.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2022-09-19  6:22 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2022-08-29 18:40 ` [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order Jagan Teki
2022-08-29 18:40 ` [PATCH v4 03/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
2022-08-29 18:40 ` [PATCH v4 04/12] drm: bridge: samsung-dsim: Handle platform init via driver_data Jagan Teki
2022-08-29 18:40 ` [PATCH v4 05/12] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
2022-08-29 18:40 ` [PATCH v4 06/12] drm: bridge: samsung-dsim: Handle proper DSI host initialization Jagan Teki
2022-08-29 18:40 ` [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
2022-08-29 19:42   ` Adam Ford
2022-09-14  8:22     ` Jagan Teki
2022-08-29 18:40 ` [PATCH v4 08/12] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
2022-08-29 18:40 ` [PATCH v4 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
2022-08-29 18:40 ` [PATCH v4 10/12] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2022-08-29 18:40 ` [PATCH v4 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
2022-08-29 18:40 ` [PATCH v4 12/12] drm: bridge: samsung-dsim: Add " Jagan Teki
     [not found] ` <CGME20220829184118eucas1p2cda47fa166cafcb904800a55a5f66180@eucas1p2.samsung.com>
     [not found]   ` <20220829184031.1863663-3-jagan@amarulasolutions.com>
2022-09-02 10:47     ` [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver Marek Szyprowski
2022-09-05 11:24       ` Marek Szyprowski
2022-09-06 19:07         ` Jagan Teki
2022-09-07 10:04           ` Marek Szyprowski
2022-09-12 14:52             ` Frieder Schrempf
2022-09-13 17:29             ` Jagan Teki
2022-09-14  9:21               ` Marek Szyprowski
2022-09-14  9:39                 ` Jagan Teki
2022-09-16  8:28                   ` Marek Szyprowski
2022-09-16 10:21                     ` Jagan Teki
2022-09-19  6:22                       ` Marek Szyprowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).