linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes
@ 2022-08-23 14:56 Rob Herring
  2022-08-25  6:25 ` Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Rob Herring @ 2022-08-23 14:56 UTC (permalink / raw)
  To: James (Qian) Wang, Liviu Dudau, Mihail Atanassov, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Andrzej Hajda,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
	Sean Paul, Inki Dae, Seung-Woo Kim, Kyungmin Park, Alim Akhtar,
	Andre Przywara
  Cc: Liviu Dudau, Krzysztof Kozlowski, dri-devel, devicetree,
	linux-kernel, linux-arm-msm, freedreno, linux-arm-kernel,
	linux-samsung-soc

In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
 Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
 .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
 .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
 5 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml
index 9f4aade97f10..3ad3eef89ca8 100644
--- a/Documentation/devicetree/bindings/display/arm,komeda.yaml
+++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml
@@ -58,6 +58,7 @@ properties:
 patternProperties:
   '^pipeline@[01]$':
     type: object
+    additionalProperties: false
     description:
       clocks
 
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 3a8614e0f627..84aafcbf0919 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -51,6 +51,7 @@ properties:
     properties:
       port@0:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: |
           For LVDS encoders, port 0 is the parallel input
           For LVDS decoders, port 0 is the LVDS input
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
index 3397bc31d087..0179c816fa6d 100644
--- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
@@ -81,6 +81,7 @@ properties:
 
   zap-shader:
     type: object
+    additionalProperties: false
     description: |
       For a5xx and a6xx devices this node contains a memory-region that
       points to reserved memory to store the zap shader that can be used to
diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
index 969bd8c563a5..dec1c9058876 100644
--- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
+++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
@@ -37,6 +37,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: timing configuration for lcd i80 interface support
     properties:
       cs-setup:
diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
index 5d5cc220f78a..7593938601bb 100644
--- a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
+++ b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
@@ -40,6 +40,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: |
       Timing configuration for lcd i80 interface support.
       The parameters are defined as::
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
@ 2022-08-25  6:25 ` Krzysztof Kozlowski
  2022-08-25  8:51 ` Laurent Pinchart
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-25  6:25 UTC (permalink / raw)
  To: Rob Herring, James (Qian) Wang, Liviu Dudau, Mihail Atanassov,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Andrzej Hajda,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
	Sean Paul, Inki Dae, Seung-Woo Kim, Kyungmin Park, Alim Akhtar,
	Andre Przywara
  Cc: Krzysztof Kozlowski, dri-devel, devicetree, linux-kernel,
	linux-arm-msm, freedreno, linux-arm-kernel, linux-samsung-soc

On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
  2022-08-25  6:25 ` Krzysztof Kozlowski
@ 2022-08-25  8:51 ` Laurent Pinchart
  2022-08-26 10:10 ` Dmitry Baryshkov
  2022-08-29 19:55 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-08-25  8:51 UTC (permalink / raw)
  To: Rob Herring
  Cc: James (Qian) Wang, Liviu Dudau, Mihail Atanassov, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Andrzej Hajda,
	Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
	Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul, Inki Dae,
	Seung-Woo Kim, Kyungmin Park, Alim Akhtar, Andre Przywara,
	Krzysztof Kozlowski, dri-devel, devicetree, linux-kernel,
	linux-arm-msm, freedreno, linux-arm-kernel, linux-samsung-soc

Hi Rob,

Thank you for the patch.

On Tue, Aug 23, 2022 at 09:56:42AM -0500, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
>  Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
>  Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
>  .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
>  .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml
> index 9f4aade97f10..3ad3eef89ca8 100644
> --- a/Documentation/devicetree/bindings/display/arm,komeda.yaml
> +++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml
> @@ -58,6 +58,7 @@ properties:
>  patternProperties:
>    '^pipeline@[01]$':
>      type: object
> +    additionalProperties: false
>      description:
>        clocks
>  
> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> index 3a8614e0f627..84aafcbf0919 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> @@ -51,6 +51,7 @@ properties:
>      properties:
>        port@0:
>          $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
>          description: |
>            For LVDS encoders, port 0 is the parallel input
>            For LVDS decoders, port 0 is the LVDS input
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 3397bc31d087..0179c816fa6d 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -81,6 +81,7 @@ properties:
>  
>    zap-shader:
>      type: object
> +    additionalProperties: false
>      description: |
>        For a5xx and a6xx devices this node contains a memory-region that
>        points to reserved memory to store the zap shader that can be used to
> diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> index 969bd8c563a5..dec1c9058876 100644
> --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> @@ -37,6 +37,7 @@ properties:
>  
>    i80-if-timings:
>      type: object
> +    additionalProperties: false
>      description: timing configuration for lcd i80 interface support
>      properties:
>        cs-setup:
> diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
> index 5d5cc220f78a..7593938601bb 100644
> --- a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
> +++ b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml
> @@ -40,6 +40,7 @@ properties:
>  
>    i80-if-timings:
>      type: object
> +    additionalProperties: false
>      description: |
>        Timing configuration for lcd i80 interface support.
>        The parameters are defined as::

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
  2022-08-25  6:25 ` Krzysztof Kozlowski
  2022-08-25  8:51 ` Laurent Pinchart
@ 2022-08-26 10:10 ` Dmitry Baryshkov
  2022-08-29 19:55 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 10:10 UTC (permalink / raw)
  To: Rob Herring, James (Qian) Wang, Liviu Dudau, Mihail Atanassov,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Andrzej Hajda,
	Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, Rob Clark, Abhinav Kumar, Sean Paul, Inki Dae,
	Seung-Woo Kim, Kyungmin Park, Alim Akhtar, Andre Przywara
  Cc: Krzysztof Kozlowski, dri-devel, devicetree, linux-kernel,
	linux-arm-msm, freedreno, linux-arm-kernel, linux-samsung-soc

On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
>   Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
>   Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # msm

>   .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
>   .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
>   5 files changed, 5 insertions(+)


-- 
With best wishes
Dmitry


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
                   ` (2 preceding siblings ...)
  2022-08-26 10:10 ` Dmitry Baryshkov
@ 2022-08-29 19:55 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-08-29 19:55 UTC (permalink / raw)
  To: Rob Herring
  Cc: Abhinav Kumar, Liviu Dudau, Andrzej Hajda, Sean Paul,
	Andre Przywara, Jonas Karlman, linux-kernel, Liviu Dudau,
	Kyungmin Park, Krzysztof Kozlowski, Neil Armstrong,
	James (Qian) Wang, Seung-Woo Kim, freedreno, devicetree,
	David Airlie, Daniel Vetter, Dmitry Baryshkov, Jernej Skrabec,
	Laurent Pinchart, Inki Dae, Rob Clark, linux-arm-kernel,
	linux-arm-msm, Mihail Atanassov, linux-samsung-soc, Robert Foss,
	Alim Akhtar, dri-devel, Krzysztof Kozlowski

On Tue, 23 Aug 2022 09:56:42 -0500, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
>  Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
>  Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
>  .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
>  .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
>  5 files changed, 5 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-29 19:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 14:56 [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25  6:25 ` Krzysztof Kozlowski
2022-08-25  8:51 ` Laurent Pinchart
2022-08-26 10:10 ` Dmitry Baryshkov
2022-08-29 19:55 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).