From: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
To: <broonie@kernel.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>, <jic23@kernel.org>,
<tudor.ambarus@microchip.com>, <pratyush@kernel.org>,
<sanju.mehta@amd.com>, <chin-ting_kuo@aspeedtech.com>,
<clg@kaod.org>, <kdasu.kdev@gmail.com>, <f.fainelli@gmail.com>,
<rjui@broadcom.com>, <sbranden@broadcom.com>,
<eajames@linux.ibm.com>, <olteanv@gmail.com>, <han.xu@nxp.com>,
<john.garry@huawei.com>, <shawnguo@kernel.org>,
<s.hauer@pengutronix.de>, <narmstrong@baylibre.com>,
<khilman@baylibre.com>, <matthias.bgg@gmail.com>,
<haibo.chen@nxp.com>, <linus.walleij@linaro.org>,
<daniel@zonque.org>, <haojian.zhuang@gmail.com>,
<robert.jarzmik@free.fr>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <heiko@sntech.de>,
<krzysztof.kozlowski@linaro.org>, <andi@etezian.org>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<wens@csie.org>, <jernej.skrabec@gmail.com>,
<samuel@sholland.org>, <masahisa.kojima@linaro.org>,
<jaswinder.singh@linaro.org>, <rostedt@goodmis.org>,
<mingo@redhat.com>, <l.stelmach@samsung.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <alex.aring@gmail.com>,
<stefan@datenfreihafen.org>, <kvalo@kernel.org>,
<james.schulman@cirrus.com>, <david.rhodes@cirrus.com>,
<tanureal@opensource.cirrus.com>, <rf@opensource.cirrus.com>,
<perex@perex.cz>, <tiwai@suse.com>, <npiggin@gmail.com>,
<christophe.leroy@csgroup.eu>, <mpe@ellerman.id.au>,
<oss@buserror.net>, <windhl@126.com>, <yangyingliang@huawei.com>
Cc: <git@amd.com>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <joel@jms.id.au>,
<andrew@aj.id.au>, <radu_nicolae.pirea@upb.ro>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@microchip.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<fancer.lancer@gmail.com>, <kernel@pengutronix.de>,
<festevam@gmail.com>, <linux-imx@nxp.com>, <jbrunet@baylibre.com>,
<martin.blumenstingl@googlemail.com>, <avifishman70@gmail.com>,
<tmaimon77@gmail.com>, <tali.perry1@gmail.com>,
<venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <yogeshgaur.83@gmail.com>,
<konrad.dybcio@somainline.org>, <alim.akhtar@samsung.com>,
<ldewangan@nvidia.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <michal.simek@amd.com>,
<linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-sunxi@lists.linux.dev>, <linux-tegra@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
<libertas-dev@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<linux-iio@vger.kernel.org>, <michael@walle.cc>,
<palmer@dabbelt.com>, <linux-riscv@lists.infradead.org>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<linuxppc-dev@lists.ozlabs.org>, <amitrkcian2002@gmail.com>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Subject: [PATCH v4 04/15] mtd: devices: Replace all spi->chip_select and spi->cs_gpiod references with function call
Date: Sat, 11 Feb 2023 01:06:35 +0530 [thread overview]
Message-ID: <20230210193647.4159467-5-amit.kumar-mahapatra@amd.com> (raw)
In-Reply-To: <20230210193647.4159467-1-amit.kumar-mahapatra@amd.com>
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
members of struct spi_device to be an array. But changing the type of these
members to array would break the spi driver functionality. To make the
transition smoother introduced four new APIs to get/set the
spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
spi->cs_gpiod references with get or set API calls.
While adding multi-cs support in further patches the chip_select & cs_gpiod
members of the spi_device structure would be converted to arrays & the
"idx" parameter of the APIs would be used as array index i.e.,
spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
---
drivers/mtd/devices/mtd_dataflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 25bad4318305..34d7a0c4807b 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -646,7 +646,7 @@ static int add_dataflash_otp(struct spi_device *spi, char *name, int nr_pages,
/* name must be usable with cmdlinepart */
sprintf(priv->name, "spi%d.%d-%s",
- spi->master->bus_num, spi->chip_select,
+ spi->master->bus_num, spi_get_chipselect(spi, 0),
name);
device = &priv->mtd;
--
2.25.1
next prev parent reply other threads:[~2023-02-10 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 19:36 [PATCH v4 00/15] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 02/15] net: Replace all spi->chip_select and spi->cs_gpiod references with function call Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 03/15] iio: imu: " Amit Kumar Mahapatra
2023-02-10 19:36 ` Amit Kumar Mahapatra [this message]
2023-02-10 19:36 ` [PATCH v4 05/15] staging: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 06/15] platform/x86: serial-multi-instantiate: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 07/15] powerpc/83xx/mpc832x_rdb: Replace all spi->chip_select " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 08/15] ALSA: hda: cs35l41: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 09/15] spi: Add stacked and parallel memories support in SPI core Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 10/15] mtd: spi-nor: Convert macros with inline functions Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 11/15] mtd: spi-nor: Add APIs to set/get nor->params Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 12/15] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 13/15] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 14/15] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 15/15] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra
[not found] ` <20230210193647.4159467-2-amit.kumar-mahapatra@amd.com>
2023-02-15 14:19 ` [PATCH v4 01/15] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call Mark Brown
2023-03-11 21:16 ` (subset) [PATCH v4 00/15] spi: Add support for stacked/parallel memories Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210193647.4159467-5-amit.kumar-mahapatra@amd.com \
--to=amit.kumar-mahapatra@amd.com \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=alex.aring@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=amitrkcian2002@gmail.com \
--cc=andi@etezian.org \
--cc=andrew@aj.id.au \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=clg@kaod.org \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=david.rhodes@cirrus.com \
--cc=eajames@linux.ibm.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=festevam@gmail.com \
--cc=git@amd.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=haojian.zhuang@gmail.com \
--cc=heiko@sntech.de \
--cc=james.schulman@cirrus.com \
--cc=jaswinder.singh@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=kdasu.kdev@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=masahisa.kojima@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@walle.cc \
--cc=michal.simek@amd.com \
--cc=mingo@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=mpe@ellerman.id.au \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=npiggin@gmail.com \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pratyush@kernel.org \
--cc=radu_nicolae.pirea@upb.ro \
--cc=rf@opensource.cirrus.com \
--cc=richard@nod.at \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sanju.mehta@amd.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=tali.perry1@gmail.com \
--cc=tanureal@opensource.cirrus.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=tmaimon77@gmail.com \
--cc=tudor.ambarus@microchip.com \
--cc=venture@google.com \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
--cc=windhl@126.com \
--cc=yangyingliang@huawei.com \
--cc=yogeshgaur.83@gmail.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).