From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 4/4] phy: exynos: Use one define for enable bit Date: Tue, 14 Mar 2017 15:46:10 +0100 Message-ID: <2746282.jBJ7tRjldv@amdc3058> References: <20170311182534.13345-1-krzk@kernel.org> <20170311182534.13345-5-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <20170311182534.13345-5-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , Kukjin Kim , Javier Martinez Canillas , Lee Jones , Sylwester Nawrocki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org Hi, On Saturday, March 11, 2017 08:25:34 PM Krzysztof Kozlowski wrote: > There is no need for separate defines for Exynos4 and Exynos5 phy enable > bit and MIPI phy reset bits. In both cases there are the same so > simplify it. > > This reduces number of defines and allows removal of one header file. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Lee Jones > --- > drivers/phy/phy-exynos-dp-video.c | 5 ++-- > drivers/phy/phy-exynos-mipi-video.c | 39 ++++++++++++++--------------- > drivers/phy/phy-exynos5-usbdrd.c | 5 ++-- > include/linux/mfd/syscon/exynos5-pmu.h | 22 ---------------- > include/linux/soc/samsung/exynos-regs-pmu.h | 3 ++- > 5 files changed, 25 insertions(+), 49 deletions(-) > delete mode 100644 include/linux/mfd/syscon/exynos5-pmu.h [...] > --- a/include/linux/mfd/syscon/exynos5-pmu.h > +++ /dev/null > -#define EXYNOS5433_PAD_RETENTION_AUD_OPTION (0x3028) > -#define EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR BIT(28) EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR is not defined in and is still used by drivers/mfd/exynos-lpass.c (at least in next-20170310) Do I miss something or it needs to be fixed? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics