From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards
Date: Fri, 10 Feb 2017 11:04:50 -0300 [thread overview]
Message-ID: <287b5f0b-26b2-7811-9305-5194ebf0138a@osg.samsung.com> (raw)
In-Reply-To: <20170210022238.12401-1-andi.shyti@samsung.com>
Hello Andi,
On 02/09/2017 11:22 PM, Andi Shyti wrote:
> Add the device tree node for the ir-spi driver which enable the
> ir led for remote controlling.
>
> This patch sets first the GPR3[3] gpio line as a regulator-fixed
> for enabling an external regulator which powers the IR LED.
>
> Removes also the default assignment of GPG3[7] related to the
> MOSI line of the SPI3 bus.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> Changelog v1 -> v2
> ==================
> v1: https://marc.info/?l=linux-kernel&m=148645523229894&w=2
>
> - used 'GPIO_ACTIVE_HIGH' instead of '0'
> - added back the gpg3-5 gpio initialization related to the SPI3
> CS line that was erroneously removed
>
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 26 +++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 098ad557fee3..4df6b57a0a68 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -106,6 +106,13 @@
> };
> };
>
> + irda_regulator: irda-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpr3 3 GPIO_ACTIVE_HIGH>;
> + regulator-name = "irda_regulator";
How is this regulator named in the board schematics? My
understanding is that regulator-name should match this.
I don't have access to this so it may be "irda_regulator"
although I was expecting something more like "VDD_IRDA".
Patch looks good to me though:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2017-02-10 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170210022252epcas1p2cad2a32fb74a5ecc17ed73387579c6ab@epcas1p2.samsung.com>
2017-02-10 2:22 ` [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Andi Shyti
2017-02-10 13:43 ` Krzysztof Kozlowski
2017-02-10 14:04 ` Javier Martinez Canillas [this message]
2017-02-11 4:44 ` Andi Shyti
2017-02-13 11:55 ` Javier Martinez Canillas
2017-03-07 19:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=287b5f0b-26b2-7811-9305-5194ebf0138a@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).