From: Lukasz Luba <lukasz.luba@arm.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
heiko@sntech.de, leonard.crestez@nxp.com
Cc: a.swigon@samsung.com, m.szyprowski@samsung.com, kgene@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: Replace deprecated 'devfreq-events' property
Date: Tue, 17 Dec 2019 11:03:58 +0000 [thread overview]
Message-ID: <500aaeb0-85ca-c1f5-2f30-a7b1e95810b6@arm.com> (raw)
In-Reply-To: <20191217055738.28445-8-cw00.choi@samsung.com>
Hi Chanwoo,
On 12/17/19 5:57 AM, Chanwoo Choi wrote:
> In order to remove the deprecated 'devfreq-events' property, replace with
> new 'exynos,ppmu-device' property in order to get the devfreq-event device
> in devicetree file instead of 'devfreq-events' property. But, to guarantee
> the backward-compatibility, keep the support 'devfreq-events' property.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> .../memory-controllers/exynos5422-dmc.txt | 6 ++--
> drivers/memory/samsung/exynos5422-dmc.c | 29 +++++++++++++++----
> 2 files changed, 26 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> index 02e4a1f862f1..1e1b3702f045 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> @@ -17,14 +17,14 @@ Required properties for DMC device for Exynos5422:
> - clock-names : should include "fout_spll", "mout_sclk_spll", "ff_dout_spll2",
> "fout_bpll", "mout_bpll", "sclk_bpll", "mout_mx_mspll_ccore",
> "mout_mclk_cdrex" entries
> -- devfreq-events : phandles for PPMU devices connected to this DMC.
> +- exynos,ppmu-device : phandles for PPMU devices connected to this DMC.
> - vdd-supply : phandle for voltage regulator which is connected.
> - reg : registers of two CDREX controllers.
> - operating-points-v2 : phandle for OPPs described in v2 definition.
> - device-handle : phandle of the connected DRAM memory device. For more
> information please refer to documentation file:
> Documentation/devicetree/bindings/ddr/lpddr3.txt
> -- devfreq-events : phandles of the PPMU events used by the controller.
> +- exynos,ppmu-device : phandles of the PPMU events used by the controller.
> - samsung,syscon-clk : phandle of the clock register set used by the controller,
> these registers are used for enabling a 'pause' feature and are not
> exposed by clock framework but they must be used in a safe way.
> @@ -73,7 +73,7 @@ Example:
> "mout_mx_mspll_ccore",
> "mout_mclk_cdrex";
> operating-points-v2 = <&dmc_opp_table>;
> - devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>,
> + exynos,ppmu-device = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>,
> <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>;
> device-handle = <&samsung_K3QF2F20DB>;
> vdd-supply = <&buck1_reg>;
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index c3195111d646..96593f37a478 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -1270,10 +1270,17 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc)
> static struct devfreq_event_dev *get_edev_by_node(struct device_node *np,
> int index)
> {
> - struct device_node *node = of_parse_phandle(np, "devfreq-events",
> + struct device_node *node = of_parse_phandle(np, "exynos,ppmu-device",
> index);
> - if (!node)
> - return ERR_PTR(-ENODEV);
> + if (!node) {
> + /*
> + * Check the deprecated 'devfreq-events' property
> + * to support backward-compatibility.
> + */
> + node = of_parse_phandle(np, "devfreq-events", index);
> + if (!node)
> + return ERR_PTR(-ENODEV);
> + }
> return devfreq_event_get_edev_by_node(node);
> }
>
> @@ -1292,10 +1299,20 @@ static int exynos5_performance_counters_init(struct exynos5_dmc *dmc)
> int ret, i;
>
> dmc->num_counters = of_property_count_elems_of_size(dmc->dev->of_node,
> - "devfreq-events", sizeof(u32));
> + "exynos,ppmu-device", sizeof(u32));
> if (dmc->num_counters < 0) {
> - dev_err(dmc->dev, "could not get devfreq-event counters\n");
> - return dmc->num_counters;
> + /*
> + * Check the deprecated 'devfreq-events' property
> + * to support backward-compatibility.
> + */
> + dmc->num_counters = of_property_count_elems_of_size(
> + dmc->dev->of_node,
> + "devfreq-events", sizeof(u32));
> + if (dmc->num_counters < 0) {
> + dev_err(dmc->dev,
> + "could not get devfreq-event counters\n");
> + return dmc->num_counters;
> + }
> }
>
> counters_size = sizeof(struct devfreq_event_dev) * dmc->num_counters;
>
Looks good to me. The fallback with backward-compatibility is a good
idea in my opinion. Thank you for the change and feel free to and my:
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regarding the whole patch set, for the first glance it looks reasonable
and good. AIRC some developers were arguing for the "devfreq-events"
entry in DT. Now it should be fine. I will spend more time today for
reviewing the whole patch set.
Regards,
Lukasz
next prev parent reply other threads:[~2019-12-17 11:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191217055105epcas1p365e306f27fd53852b793155c929ee634@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 0/9] PM / devfreq: Remove deprecated 'devfreq' and 'devfreq-events' properties Chanwoo Choi
[not found] ` <CGME20191217055105epcas1p3bacbf54550c52979fe819ab33bb21d30@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 1/9] PM / devfreq: Add devfreq_get_devfreq_by_node function Chanwoo Choi
[not found] ` <CGME20191217055105epcas1p2d2930402a559e381a7854f515a683d15@epcas1p2.samsung.com>
2019-12-17 5:57 ` [PATCH 2/9] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function Chanwoo Choi
2019-12-17 14:33 ` Leonard Crestez
2019-12-18 2:59 ` Chanwoo Choi
2019-12-18 3:20 ` Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p3e77268d200006921dfa736b2c7550a04@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 3/9] PM / devfreq: event: Add devfreq_event_get_edev_by_node function Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p11f2bc81d6bb2db3fc4bc257d78c337b9@epcas1p1.samsung.com>
2019-12-17 5:57 ` [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property Chanwoo Choi
2019-12-26 21:01 ` Rob Herring
2019-12-27 0:09 ` Chanwoo Choi
2020-01-06 1:38 ` Chanwoo Choi
2020-01-14 18:57 ` Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p4b50ca647af9b54465e5c0a0bebb165b8@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 5/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq-events' property Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p156b1323f4ec9f7c35fed825d56e577ff@epcas1p1.samsung.com>
2019-12-17 5:57 ` [PATCH 6/9] PM / devfreq: rk3399_dmc: " Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p2c43a45e34983c1b3e60cc6fd842dd33e@epcas1p2.samsung.com>
2019-12-17 5:57 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Chanwoo Choi
2019-12-17 11:03 ` Lukasz Luba [this message]
2019-12-19 20:19 ` Krzysztof Kozlowski
[not found] ` <CGME20191217055106epcas1p4c0f65bec74e53b38d95e984e146bf8b6@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 8/9] ARM: dts: exynos: Replace deprecated property for Exynos bus and DMC Chanwoo Choi
2019-12-19 20:21 ` Krzysztof Kozlowski
[not found] ` <CGME20191217055107epcas1p44d46bdea7b326b86689f326742f5444a@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 9/9] arm64: dts: exynos: Replace deprecated property for Exynos bus Chanwoo Choi
2019-12-19 20:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500aaeb0-85ca-c1f5-2f30-a7b1e95810b6@arm.com \
--to=lukasz.luba@arm.com \
--cc=a.swigon@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).