From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: "Thomas Abraham" <thomas.abraham@linaro.org>,
"Heiko Stübner" <heiko@sntech.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
t.figa@samsung.com
Subject: Re: [PATCH 3/4] clk: samsung: always allocate the clk_table
Date: Tue, 12 Mar 2013 12:23:35 +0100 [thread overview]
Message-ID: <513F1037.3080107@samsung.com> (raw)
In-Reply-To: <CAJuYYwT183EcZZ20P8D7AP34CwXfKYLzsmZdoJz1ny7XznzyAg@mail.gmail.com>
Hi,
On 03/12/2013 10:54 AM, Thomas Abraham wrote:
> This change is fine but one point that should be considered is that on
> non-dt platforms, the memory allocation of clk_table cannot really be
> justified just because few clocks require two or more aliases.
>
> Instead, the optional alias passed for divider/mux register functions
> can actually be a list of alias names, the list being terminated by a
> zero-length string. The clock register helper functions can then loop
> through that list and register all the aliases.
Heiko's approach look much more clean to me and even for Exynos platform
which has currently about 350 clocks and is going to be dt-only starting
from 3.10 we are talking about 1.5kB of memory. Other (s3c64/24xx)
platforms have much less clocks (70...150).
IMHO all clocks aliases should be registered as it is done in Heiko's
patch series. And the clocks table could just be freed on non-dt
platforms if it is a real issue and anyone is concerned about it.
Regards,
Sylwester
next prev parent reply other threads:[~2013-03-12 11:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:42 [PATCH 0/4] clk: samsung: small fixes and enhancements Heiko Stübner
2013-03-11 23:43 ` [PATCH 1/4] clk: samsung: register clk_div_tables for divider clocks Heiko Stübner
2013-03-12 8:50 ` Thomas Abraham
2013-03-11 23:44 ` [PATCH 2/4] clk: samsung: remove np check in clock init Heiko Stübner
2013-03-12 8:53 ` Thomas Abraham
2013-03-12 9:02 ` Heiko Stübner
2013-03-12 9:17 ` Heiko Stübner
2013-03-12 9:36 ` Thomas Abraham
2013-03-12 9:54 ` Heiko Stübner
2013-03-11 23:44 ` [PATCH 3/4] clk: samsung: always allocate the clk_table Heiko Stübner
2013-03-12 9:54 ` Thomas Abraham
2013-03-12 10:50 ` Heiko Stübner
2013-03-12 11:26 ` Thomas Abraham
2013-03-12 11:23 ` Sylwester Nawrocki [this message]
2013-03-12 11:46 ` Thomas Abraham
2013-03-12 13:48 ` Sylwester Nawrocki
2013-03-12 14:24 ` Thomas Abraham
2013-03-13 3:00 ` Alim Akhtar
2013-03-13 3:35 ` Sachin Kamat
2013-03-13 5:13 ` Kyungmin Park
2013-03-11 23:45 ` [PATCH 4/4] clk: samsung: add infrastructure to add separate aliases Heiko Stübner
2013-03-12 9:57 ` Thomas Abraham
2013-03-12 10:04 ` Heiko Stübner
2013-03-12 10:48 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F1037.3080107@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).