From: Chanwoo Choi <cw00.choi@samsung.com>
To: Yangtao Li <tiny.windzz@gmail.com>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
kgene@kernel.org, krzk@kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PM / devfreq: exynos-bus: Disable devfreq-event device when fails
Date: Mon, 23 Dec 2019 09:50:46 +0900 [thread overview]
Message-ID: <52c458b0-cc85-fd2d-7c89-39f2bbd39bda@samsung.com> (raw)
In-Reply-To: <ca7f5eb8-d549-a170-f952-90e5882b233d@samsung.com>
On 12/23/19 9:47 AM, Chanwoo Choi wrote:
> On 12/23/19 2:41 AM, Yangtao Li wrote:
>> The exynos_bus_profile_init process may fail, but the devfreq event device
>> remains enabled. Call devfreq_event_disable_edev on the error return path.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> v2:
>> -change subject
>> -rename lable to err_edev
>> -add return value check
>> ---
>> drivers/devfreq/exynos-bus.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>> index 7f5917d59072..948e9340f91c 100644
>> --- a/drivers/devfreq/exynos-bus.c
>> +++ b/drivers/devfreq/exynos-bus.c
>> @@ -335,10 +335,17 @@ static int exynos_bus_profile_init(struct exynos_bus *bus,
>> ret = exynos_bus_set_event(bus);
>> if (ret < 0) {
>> dev_err(dev, "failed to set event to devfreq-event devices\n");
>> - return ret;
>> + goto err_edev;
>> }
>>
>> return 0;
>> +
>> +err_edev:
>> + ret = exynos_bus_disable_edev(bus);
>> + if (ret < 0)
>> + dev_warn(dev, "failed to disable the devfreq-event devices\n");
>> +
>> + return ret;
>> }
>>
>> static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>>
>
> Applied it.
>
I'm sorry. I applied the v3[1] patch instead of this.
[1] https://patchwork.kernel.org/patch/11307721/
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-12-23 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191222174139epcas5p2019ddf01d7c2d17020733eafa173508b@epcas5p2.samsung.com>
2019-12-22 17:41 ` [PATCH v2 1/2] PM / devfreq: rk3399_dmc: Disable devfreq-event device when fails Yangtao Li
2019-12-22 17:41 ` [PATCH v2 2/2] PM / devfreq: exynos-bus: " Yangtao Li
2019-12-23 0:47 ` Chanwoo Choi
2019-12-23 0:50 ` Chanwoo Choi [this message]
2019-12-23 0:51 ` [PATCH v2 1/2] PM / devfreq: rk3399_dmc: " Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c458b0-cc85-fd2d-7c89-39f2bbd39bda@samsung.com \
--to=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).