linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07  8:51 ` Cai Huoqing
  2021-09-07 12:28   ` Krzysztof Kozlowski
  2021-09-13 16:12   ` Sylwester Nawrocki
  0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-07  8:51 UTC (permalink / raw)
  To: caihuoqing
  Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
	Stephen Boyd, Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
	linux-arm-kernel, linux-kernel

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/clk/samsung/clk-exynos4412-isp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
index b69e381b8c0c..471a6fb82670 100644
--- a/drivers/clk/samsung/clk-exynos4412-isp.c
+++ b/drivers/clk/samsung/clk-exynos4412-isp.c
@@ -110,11 +110,9 @@ static int __init exynos4x12_isp_clk_probe(struct platform_device *pdev)
 	struct samsung_clk_provider *ctx;
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
-	struct resource *res;
 	void __iomem *reg_base;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(reg_base))
 		return PTR_ERR(reg_base);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource()
  2021-09-07  8:51 ` [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-07 12:28   ` Krzysztof Kozlowski
  2021-09-13 16:12   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-07 12:28 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
	Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
	linux-kernel

On 07/09/2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/clk/samsung/clk-exynos4412-isp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource()
  2021-09-07  8:51 ` [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
  2021-09-07 12:28   ` Krzysztof Kozlowski
@ 2021-09-13 16:12   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2021-09-13 16:12 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
	Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
	linux-arm-kernel, linux-kernel

On 07.09.2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately

Thanks for the patch. I have applied it with summary line changed to 
"clk: samsung: exynos4412-isp: Make use of devm_platform_ioremap_resource()"
so it doesn't exceed 75 characters.
-- 
Regards,
Sylwester

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-13 16:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210907085116eucas1p2774a348493c0eed6762352afeaae5c45@eucas1p2.samsung.com>
2021-09-07  8:51 ` [PATCH] clk: samsung: exynos4412-isp: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:28   ` Krzysztof Kozlowski
2021-09-13 16:12   ` Sylwester Nawrocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).