From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E5CC3F68F for ; Thu, 26 Dec 2019 01:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C25E21927 for ; Thu, 26 Dec 2019 01:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="XAPVSLRy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfLZBWJ (ORCPT ); Wed, 25 Dec 2019 20:22:09 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:31099 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbfLZBWJ (ORCPT ); Wed, 25 Dec 2019 20:22:09 -0500 Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20191226012204epoutp01057ee507dc0d0f4c3e032f11e9345e0e~jxzTr4egN3238232382epoutp016 for ; Thu, 26 Dec 2019 01:22:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20191226012204epoutp01057ee507dc0d0f4c3e032f11e9345e0e~jxzTr4egN3238232382epoutp016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1577323324; bh=A4Y74hU4stuVNxeQUffqt8qHn8nJgO4jOxqfu0/HH5Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=XAPVSLRyj8kRjJrGksf+vqkBxtr2fFfK5uKytEJwM7CCnxGFXGQyPMOGxgYIMGNuo hT8BSfTbAQ6x5gXMMqHwfrwmUUWgOosSDjcqyhQlrGxE/7rRlI/sK1aq66cxgwYgqH ugNvkIIelEajk7huVX91dQQpob0BOMo6bb0XFdjs= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20191226012203epcas1p48d589dd2b963a40ab84a01f0dd14b944~jxzTFXyQo2035320353epcas1p49; Thu, 26 Dec 2019 01:22:03 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.40.155]) by epsnrtp4.localdomain (Postfix) with ESMTP id 47jsck4bzCzMqYkn; Thu, 26 Dec 2019 01:21:58 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 17.FE.48019.33B040E5; Thu, 26 Dec 2019 10:21:55 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20191226012154epcas1p2edbed9b0b041607bc0d1d88eba93b973~jxzKLrWO-1488114881epcas1p2j; Thu, 26 Dec 2019 01:21:54 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20191226012154epsmtrp1c06d5ade9063e3531597b1a23c5f98dd~jxzKJKHA-2279122791epsmtrp1-; Thu, 26 Dec 2019 01:21:54 +0000 (GMT) X-AuditID: b6c32a38-257ff7000001bb93-a3-5e040b332ad8 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 68.A9.06569.23B040E5; Thu, 26 Dec 2019 10:21:54 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20191226012154epsmtip28ffab25f041e7a9971337debd09c038a~jxzJ_8Ogh0334903349epsmtip2X; Thu, 26 Dec 2019 01:21:54 +0000 (GMT) Subject: Re: [PATCH] PM / devfreq: exynos-bus: Add error log when get event fails To: Frank Lee Cc: MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Linux PM , linux-samsung-soc , Linux ARM , Linux Kernel Mailing List From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <583cb300-ec4a-0c94-d597-4efcdf9e31ee@samsung.com> Date: Thu, 26 Dec 2019 10:28:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUxNYRzHPfece+4pLo+r9JONOpZNUzrdLsdLDZldL7NM84dNObpH9+q+ uedmYYZILwspW1y1zMukFnWFimrSpjJCmHnZkJG3myG7W8I5nUz/fZ7v8/3u93yf56EJXQ0V SlvsbsFl560MFUhevTUrKko/lkyJye4P5I70fiK47u5aDXc3+7OG8/Y+UXM9TWUU9/1QO+KO d7eouOf7KimufLCIWhxgbPS81Bi9VfmU8fLZPcbD9VXI+N07LUm9IWORWeBNgitMsKc5TBZ7 ejyzal1qYqphbgwbxc7n5jFhdt4mxDPLVidFLbdYpfMwYdt5a6YkJfGiyMxJWORyZLqFMLND dMczgtNkdc53Rou8Tcy0p0enOWwL2JiYWINk3JRh9hbmU86Pk7M6+vvIvciPC1AADTgOShs7 SJl1uAFBR/2aAhQo8TcElx/6NMriJ4Ivj1rU/xIFdTkqZaMZQXHlj5FFvxSprkWyaxJeB61D z4c5CEfAyfPnh00E9qng7ot+jbxB4Uho7XtKyTwBh8Njf+9wQIsT4Nq7HkmnaVIKn7gRJMvB eD10Xj0wYpkInSfekrIlAK+Ffe1OWSZwCDx7W6FSeDpc+1JGyGMB/6GguW6IVBosg9ybNUjh SfDxdr1G4VD4cOTgCO+CC53tlBLOQ1Dfen+kvh5az5Wo5MEEngWXmuYocjg0DpYjZfB48A0U qmULYC3kHdQplhnQ8+qlSuEpcCY3nypCjGdUG8+oCp5RFTz/h51CZBWaLDhFW7ogss640Y/t RcNfNZJrQDfurW5DmEbMOG3tFiJFp+a3iztsbQhoggnSVrtQik5r4nfsFFyOVFemVRDbkEG6 66NEaHCaQ/r4dncqa4jV6/VcHDvXwLJMiJb2P9iow+m8W8gQBKfg+pdT0QGhexF3zNeedWno XPmUmpxoTQdDn+qanROZ3HLy96o60V8ysLshIrzkdR5fuqQp4fWdK7bEInO2ruJO0piu8IGc +xf7BpO3nY6vfWNM3BIroEL/zCdjApN/5U7wFW8iCy1E8PW8IMerkJpHX7ct3J/1ftfS2ytm bt28kjdNtVR/tU4r7mpmSNHMs5GES+T/AqkGpADAAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsWy7bCSvK4RN0ucwcZmEYv+x6+ZLc6f38Bu cbbpDbvFpsfXWC0u75rDZvG59wijxYzz+5gsbjeuYLOY+3sCmwOnx85Zd9k9Nq3qZPPYvKTe o2/LKkaPz5vkAlijuGxSUnMyy1KL9O0SuDI29XSyFbwSqzjx/gVLA+MPgS5GTg4JAROJro2t TF2MXBxCArsZJT5v38cIkZCUmHbxKHMXIweQLSxx+HAxRM1bRolbRyezg9QICwRL7P97G6xe REBVYvby5WCDmAXeMUmsa1zLCpIQEuhikujabwliswloSex/cYMNxOYXUJS4+uMxWDOvgJ3E 9meX2UCWsQANmrlHBCQsKhAmsXPJYyaIEkGJkzOfsICUcAoESjQeKQAJMwuoS/yZd4kZwhaX uPVkPhOELS+x/e0c5gmMwrOQdM9C0jILScssJC0LGFlWMUqmFhTnpucWGxYY5aWW6xUn5haX 5qXrJefnbmIER5eW1g7GEyfiDzEKcDAq8fBuSGOOE2JNLCuuzD3EKMHBrCTCu7qIMU6INyWx siq1KD++qDQntfgQozQHi5I4r3z+sUghgfTEktTs1NSC1CKYLBMHp1QDo4C/z7QDSwSX7LIy UJdN0pG/dXkPY/D0zSynuRR/nGLQiJf0m/Tup2u37KbQNpljW7z6X0emrN+SOemu2y5pm/2q SiePXLnf8bA7YovBohBjTw/rkOPmzq+NZeXtnxufqXC9UDj1kER/XbrTq7IvN614hRvWxj7m ythuKGP2mJ/neerMmLfCSizFGYmGWsxFxYkAA+r9J6oCAAA= X-CMS-MailID: 20191226012154epcas1p2edbed9b0b041607bc0d1d88eba93b973 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20191223191928epcas1p128d39bb875b8654d61ae21364e466ec7 References: <20191223191923.10450-1-tiny.windzz@gmail.com> <7230b556-7a96-14d1-ed22-43b5a6cd5a71@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 12/24/19 11:51 PM, Frank Lee wrote: > On Tue, Dec 24, 2019 at 12:00 PM Chanwoo Choi wrote: >> >> Hi, >> >> I think that you better to use 'devfreq-event' instead of just 'event' >> as following: >> >> PM / devfreq: exynos-bus: Add error log when fail to get devfreq-event >> >> On 12/24/19 4:19 AM, Yangtao Li wrote: >>> Adding an error log makes it easier to trace the function's error path. >>> Because the error code may be rewritten on return, print error code here. >>> >>> Signed-off-by: Yangtao Li >>> --- >>> drivers/devfreq/exynos-bus.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c >>> index 948e9340f91c..634d63fd00ea 100644 >>> --- a/drivers/devfreq/exynos-bus.c >>> +++ b/drivers/devfreq/exynos-bus.c >>> @@ -126,6 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev, >>> >>> ret = exynos_bus_get_event(bus, &edata); >>> if (ret < 0) { >>> + dev_err(dev, "failed to get event from devfreq-event devices %d\n", >>> + ret); > > Emmm, it looks a bit strange to me... If don't show the error value, it is possible to make it until 81 char. I edit it as following and applied it with modified patch title. diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 1259a0da7db7..8fa8eb541373 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -126,6 +126,7 @@ static int exynos_bus_get_dev_status(struct device *dev, ret = exynos_bus_get_event(bus, &edata); if (ret < 0) { + dev_err(dev, "failed to get event from devfreq-event devices\n"); stat->total_time = stat->busy_time = 0; goto err; } > V2 has been sent. > > Yours, > Yangtao > > >> >> Better to make it under 80 char as following: >> >> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c >> index f5d4c369c7fb..10f4fa1a0363 100644 >> --- a/drivers/devfreq/exynos-bus.c >> +++ b/drivers/devfreq/exynos-bus.c >> @@ -126,7 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev, >> >> ret = exynos_bus_get_event(bus, &edata); >> if (ret < 0) { >> - dev_err(dev, "failed to get event from devfreq-event devices %d\n", >> + dev_err(dev, >> + "failed to get event from devfreq-event devices %d\n", >> ret); >> stat->total_time = stat->busy_time = 0; >> goto err; >> >> >>> stat->total_time = stat->busy_time = 0; >>> goto err; >>> } >>> >> >> >> -- >> Best Regards, >> Chanwoo Choi >> Samsung Electronics > > -- Best Regards, Chanwoo Choi Samsung Electronics