From: Alim Akhtar <alim.akhtar@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs
Date: Thu, 22 Dec 2016 16:44:01 +0530 [thread overview]
Message-ID: <585BB579.9040403@samsung.com> (raw)
In-Reply-To: <1482141648-21294-1-git-send-email-m.szyprowski@samsung.com>
Hello,
On 12/19/2016 03:30 PM, Marek Szyprowski wrote:
> UART modules can use DMA for offloading data transfers and reducing
> interrupts, so enable this feature for Exynos5 boards. Tested on
> Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid
> XU3 (Exynos5422) boards.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> v3:
> - added Exynos5410
make failed with this patch with below error:
DTC arch/arm/boot/dts/exynos5410-odroidxu.dtb
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR: Input tree has errors, aborting (use -f to force output)
make[1]: *** [arch/arm/boot/dts/exynos5410-odroidxu.dtb] Error 2
make: *** [dtbs] Error 2
-------------------------------------
I tried building against linux-next with tag v4.9.
69973b8 Linux 4.9
2e4333c Merge branch 'upstream' of
git://git.linux-mips.org/pub/scm/ralf/upstream-linus
ba73515 MIPS: Lantiq: Fix mask of GPE frequency
Let me know if I am missing other patches.
> - fixed serial 1/2 again, in v2 they were incorrectly swaped as a result
> of my hurry in patch posting
>
> v2:
> - added Exynos5250
> - fixed copy/paste typo for serial 2 and 3
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++
> arch/arm/boot/dts/exynos5410.dtsi | 8 ++++++++
> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++
> 3 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index b6d7444..0e04460 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -1043,21 +1043,29 @@
> &serial_0 {
> clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 13>, <&pdma0 14>;
> + dma-names = "rx", "tx";
> };
>
> &serial_1 {
> clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 15>, <&pdma1 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_2 {
> clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 15>, <&pdma0 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_3 {
> clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 17>, <&pdma1 18>;
> + dma-names = "rx", "tx";
> };
>
> #include "exynos5250-pinctrl.dtsi"
> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
> index 2b6adaf..7eab4bc 100644
> --- a/arch/arm/boot/dts/exynos5410.dtsi
> +++ b/arch/arm/boot/dts/exynos5410.dtsi
> @@ -340,21 +340,29 @@
> &serial_0 {
> clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 13>, <&pdma0 14>;
> + dma-names = "rx", "tx";
> };
>
> &serial_1 {
> clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 15>, <&pdma1 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_2 {
> clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 15>, <&pdma0 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_3 {
> clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 17>, <&pdma1 18>;
> + dma-names = "rx", "tx";
> };
>
> &sss {
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 906a1a4..0154c2e 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -1406,21 +1406,29 @@
> &serial_0 {
> clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 13>, <&pdma0 14>;
> + dma-names = "rx", "tx";
> };
>
> &serial_1 {
> clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 15>, <&pdma1 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_2 {
> clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma0 15>, <&pdma0 16>;
> + dma-names = "rx", "tx";
> };
>
> &serial_3 {
> clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
> clock-names = "uart", "clk_uart_baud0";
> + dmas = <&pdma1 17>, <&pdma1 18>;
> + dma-names = "rx", "tx";
> };
>
> &sss {
>
next prev parent reply other threads:[~2016-12-22 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 12:27 [PATCH] ARM: dts: exynos: Enable DMA support for UART modules on Exynos542x SoCs Marek Szyprowski
2016-12-16 12:39 ` [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs Marek Szyprowski
2016-12-16 16:50 ` Krzysztof Kozlowski
2016-12-19 6:37 ` Marek Szyprowski
2016-12-19 9:55 ` Marek Szyprowski
2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski
[not found] ` <CGME20161222111557epcas4p3dd75d80c6a61b35c9477d5bd9bad75e3@epcas4p3.samsung.com>
2016-12-22 11:14 ` Alim Akhtar [this message]
2016-12-22 11:18 ` [v3] " Marek Szyprowski
2016-12-22 12:07 ` Alim Akhtar
2016-12-29 14:09 ` [PATCH v3] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585BB579.9040403@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).