From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Denis GNUtoo Carikli <GNUtoo@cyberdimension.org>,
Simon Shields <simon@lineageos.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Date: Mon, 31 Aug 2020 10:44:39 +0200 [thread overview]
Message-ID: <5d0ce951-4472-f7f4-31be-b1f7dc8f05cb@samsung.com> (raw)
In-Reply-To: <CAJKOXPfR8YVmBqCd5+8B2TdM_tXZbWobK0pLxXxxkrsDEMR-vw@mail.gmail.com>
Hi Krzysztof,
On 31.08.2020 10:38, Krzysztof Kozlowski wrote:
> On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>> On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
>>> The camera's pinctrl configuration is simply empty and not effective.
>>> Remove it to fix dtbs_check warning:
>>>
>>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> I think that this was intentional to properly enable support for
>> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
>> default values if no pinctrl properties are provided. Sylwester, could
>> you comment?
> Indeed it could be intentional... I see now errors:
> [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19
>
> I wonder why getting an empty pinctrl is needed... maybe the driver
> should accept missing pinctrl?
Please ensure that you have those patches applied:
https://patchwork.kernel.org/patch/11707579/
https://patchwork.kernel.org/patch/11707577/
https://patchwork.kernel.org/patch/11705409/
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-08-31 8:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 13:51 [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 02/33] ARM: dts: exynos: Correct GPU regulator properties " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 03/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 04/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Origen Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 05/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 06/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Universal C210 Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 07/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 08/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Galaxy I9100 Krzysztof Kozlowski
2020-09-02 15:41 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen Krzysztof Kozlowski
2020-08-31 9:16 ` Marek Szyprowski
2020-08-31 9:37 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 10/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 11/33] ARM: dts: exynos: Remove empty camera pinctrl configuration " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 12/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 13/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema " Krzysztof Kozlowski
2020-08-30 13:51 ` [RFT 14/33] ARM: dts: exynos: Replace deprecated GPIO spi-gpio properties " Krzysztof Kozlowski
2020-08-31 9:25 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 15/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 16/33] ARM: dts: exynos: Override thermal by label in Exynos4210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 17/33] ARM: dts: exynos: Override thermal by label in Galaxy I9000 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 18/33] ARM: dts: exynos: Override thermal by label in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 19/33] ARM: dts: exynos: Add CPU cooling in Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 20/33] ARM: dts: exynos: Add CPU cooling in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 21/33] ARM: dts: exynos: Add CPU cooling in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 22/33] ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100 Krzysztof Kozlowski
2020-09-02 15:45 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 Krzysztof Kozlowski
2020-08-31 8:31 ` Marek Szyprowski
2020-08-31 8:38 ` Krzysztof Kozlowski
2020-08-31 8:44 ` Marek Szyprowski [this message]
2020-08-31 10:35 ` Sylwester Nawrocki
2020-08-31 10:42 ` Krzysztof Kozlowski
2020-08-31 13:57 ` Sylwester Nawrocki
2020-08-31 13:59 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 24/33] ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards Krzysztof Kozlowski
2020-09-02 15:48 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 25/33] ARM: dts: exynos: Add S5M8767 clocks for RTC in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 26/33] ARM: dts: exynos: Override thermal by label in Midas Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 27/33] ARM: dts: exynos: Override thermal by label in Exynos4412 Odroids Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 28/33] ARM: dts: exynos: Add CPU cooling in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 29/33] ARM: dts: exynos: Add CPU cooling in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 30/33] ARM: dts: exynos: Add CPU cooling in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 31/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 32/33] ARM: dts: exynos: Correct S3C RTC bindings in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:52 ` [PATCH 33/33] ARM: dts: exynos: Correct whitespace and indentation issues Krzysztof Kozlowski
2020-09-02 15:38 ` [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0ce951-4472-f7f4-31be-b1f7dc8f05cb@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=GNUtoo@cyberdimension.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).