From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A161FC4332F for ; Wed, 6 Oct 2021 10:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 880776115A for ; Wed, 6 Oct 2021 10:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238180AbhJFKvZ (ORCPT ); Wed, 6 Oct 2021 06:51:25 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:59270 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238183AbhJFKvX (ORCPT ); Wed, 6 Oct 2021 06:51:23 -0400 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3D82E3F499 for ; Wed, 6 Oct 2021 10:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633517367; bh=fHV2H4TjtGE0HYth4tntm/Ia3ePfNo/5UUHL9sD7VwM=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=RmEgxO/HQg69YxjygV8Y6ulWuK1p3TBl1ZYSqNeaUJKR2so8OpG91ELBSxlUUN0fx 28I9ExUHpvbnSCB0ZsvzaVAkmg1DzWvEzNPAy6h9dxxyWBVJHpAfpgNIWSyljKMRtx YaeVOeIbIwEgDSBejKB8BsP7VJKmcZOl5vwxbg187SPifUn/tba2jGjWSgsKMKEFgG SNQrx4MWwm+jocq0wZt7oEejt50S9viqQCnW44QA1AG+6S0h5TdnrdU22VRp/UViK+ 9vW+zH+D2kZMC6q5DAIrmXt+W1aKnuTOtqXprYruEB1BzrWz+FbVqieryakMh788cG DhVusnYRWvQgg== Received: by mail-lf1-f70.google.com with SMTP id c42-20020a05651223aa00b003fd328cfeccso1678264lfv.4 for ; Wed, 06 Oct 2021 03:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fHV2H4TjtGE0HYth4tntm/Ia3ePfNo/5UUHL9sD7VwM=; b=hYIzeHpBWm/Whpbpbj4DnIoFOVDqHptbhuPpmh38Kw1t15AOcXLwpNPVapagl3cmXv M6MLEmZpjdDrFMJFD3SuAYKLKrDN1s9mB0Fa1eExvqGBOMTaokApd6bFJnhufRGKL0mm he06WeVTRQrVhgXkg6zS66DPmU26sH98I/ILMroP0nGwnwBytwoE8Cv+xIFMFalhuTIg iC5kbfS1CqKrJEbe+uxCr5oUHgkqf+y1wRU5vYXM5nEvwIG251E/A/2eeI2aCVFWtvgO 7ulrxr+HBGLc68VwaJ8P8ywusvO0ZZ9b7vM1cCcfGPV0lW5wrt/kD0b6b51ieQpjun0x oW7g== X-Gm-Message-State: AOAM532s+Xd4Zl2xExiZiDuYVy44UbeIczC0M1sXBSi243wbVgKmWHip oX9hjbYI84PJ8bfEzyVTLns1O0fp2ez6HFVkIJ5hDJjNzc81Jim8OrbtUpgzoGP3PjBtWopUuib WHZfvx1p3sbU3/REcjb/F6rYJNtttsfaNakhQJiq/LL+b5odL X-Received: by 2002:a05:651c:231:: with SMTP id z17mr28170689ljn.233.1633517366033; Wed, 06 Oct 2021 03:49:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxdzWARQNf2KRq6lRaEAGi+Oi/ccdXkqGkkKFTqJRc/mzEMQ6wTE7V49HtuYGG3JA4Z+uyuw== X-Received: by 2002:a05:651c:231:: with SMTP id z17mr28170655ljn.233.1633517365861; Wed, 06 Oct 2021 03:49:25 -0700 (PDT) Received: from [192.168.0.20] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id w21sm125488lfe.237.2021.10.06.03.49.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 03:49:25 -0700 (PDT) Subject: Re: [PATCH 4/6] dt-bindings: clock: Add bindings definitions for Exynos850 CMU To: Sam Protsenko , Chanwoo Choi , Sylwester Nawrocki Cc: =?UTF-8?Q?Pawe=c5=82_Chmiel?= , Chanwoo Choi , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , Linux Kernel Mailing List , Linux Samsung SOC References: <20210914155607.14122-1-semen.protsenko@linaro.org> <20210914155607.14122-5-semen.protsenko@linaro.org> <96e5587e-aca7-248e-6448-8edfc70784b7@gmail.com> From: Krzysztof Kozlowski Message-ID: <77d976c3-a0b4-294f-d49a-8fd46b112a28@canonical.com> Date: Wed, 6 Oct 2021 12:49:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 05/10/2021 12:28, Sam Protsenko wrote: > On Wed, 15 Sept 2021 at 19:37, Chanwoo Choi wrote: >> >> Hi, >> >> You don't add clock ids for the all defined clocks in clk-exynos850.c. >> I recommend that add all clock ids for the defined clocks if possible. >> >> If you want to change the parent clock of mux or change the clock rate >> of div rate for some clocks, you have to touch the files as following: >> - include/dt-bindings/clock/exynos850.h >> - drivers/clk/samsung/clk-exynos850.c >> - exynos850 dt files >> >> If you define the clock ids for all clocks added to this patchset, >> you can change the parent or rate by just editing the dt files. >> > > Hi Chanwoo, > > I see your point. But I have intentionally omitted some clock ids, > which can't be / shouldn't be used by consumers in device tree. > Actually I took that idea from clk-exynos7.c. > > Krzysztof, Sylwester: can you please advice if all clock ids should be > defined, or only those that are going to be used in dts clk consumers? > I don't mind reworking the patch, just want to be sure which design > approach we want to follow. > I would advise to define all clock IDs, unless the clock really, really should not be used. Why do you think several clocks should not be used? Have in mind it is not only about consumers but also clock reparenting and assigning rates. Best regards, Krzysztof