From: Sylwester Nawrocki <sylwester.nawrocki@gmail.com>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: platform: s3c-camif: Fix runtime PM imbalance on error
Date: Sun, 24 May 2020 21:15:34 +0200 [thread overview]
Message-ID: <7b48c521-d3fd-9246-d647-3db9d5159087@gmail.com> (raw)
In-Reply-To: <20200521132933.16450-1-dinghao.liu@zju.edu.cn>
Hi,
On 5/21/20 15:29, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Also, call pm_runtime_disable() when pm_runtime_get_sync() returns
> an error code.
>
> Signed-off-by: Dinghao Liu<dinghao.liu@zju.edu.cn>
Thanks for the patch:
Reviewed-by: Sylwester Nawrocki <snawrocki@kernel.org>
prev parent reply other threads:[~2020-05-24 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 13:29 [PATCH] media: platform: s3c-camif: Fix runtime PM imbalance on error Dinghao Liu
2020-05-24 19:15 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b48c521-d3fd-9246-d647-3db9d5159087@gmail.com \
--to=sylwester.nawrocki@gmail.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).