From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Lee Jones <lee.jones@linaro.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
alsa-devel@alsa-project.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Inki Dae <inki.dae@samsung.com>
Subject: Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
Date: Mon, 31 Aug 2020 15:11:58 +0200 [thread overview]
Message-ID: <84ec0795-2b7f-adde-4277-2238cede8c24@samsung.com> (raw)
In-Reply-To: <20200829142501.31478-10-krzk@kernel.org>
On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> The Wolfson Arizona codec is interrupt controller which is required by
> bindings. This fixes dtbs_check warnings like:
>
> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property
> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
However I really wonder if it makes sense to expose this to DTS. Indeed,
the main MFD device of the WM5110 chip is interrupt controller, but its
interrupts are requested internally by the respective drivers.
> ---
>
> Not tested on HQ. Please kindly review and test.
>
> Best regards,
> Krzysztof
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index bab6c1addd5f..49cd55d6891c 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -1242,6 +1242,8 @@
>
> gpio-controller;
> #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
>
> wlf,micd-detect-debounce = <300>;
> wlf,micd-bias-start-time = <0x1>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-08-31 13:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200829142522eucas1p2ecc9517be9060d7291b27deba1be8fe4@eucas1p2.samsung.com>
2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-29 14:24 ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
2020-08-31 12:15 ` Sylwester Nawrocki
2020-09-03 16:42 ` Rob Herring
2020-08-29 14:24 ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
2020-08-31 12:16 ` Sylwester Nawrocki
2020-09-03 16:42 ` Rob Herring
2020-08-29 14:24 ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
2020-08-31 12:30 ` Sylwester Nawrocki
2020-08-31 12:34 ` Krzysztof Kozlowski
2020-09-02 16:06 ` Krzysztof Kozlowski
2020-08-29 14:24 ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
2020-09-14 18:15 ` Rob Herring
2020-08-29 14:24 ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-31 12:31 ` Sylwester Nawrocki
2020-09-01 11:02 ` Mark Brown
2020-09-03 16:43 ` Rob Herring
2020-08-29 14:24 ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
2020-08-31 12:52 ` Marek Szyprowski
2020-08-31 12:58 ` Sylwester Nawrocki
2020-09-01 10:12 ` Krzysztof Kozlowski
2020-08-29 14:24 ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
2020-08-31 13:00 ` Sylwester Nawrocki
2020-09-01 10:13 ` Krzysztof Kozlowski
2020-08-29 14:25 ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
2020-08-31 12:50 ` Marek Szyprowski
2020-09-02 11:23 ` Andrzej Hajda
2020-09-16 7:59 ` Krzysztof Kozlowski
2020-08-29 14:25 ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
2020-08-31 13:11 ` Marek Szyprowski [this message]
2020-08-31 13:49 ` Krzysztof Kozlowski
2020-08-31 12:14 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Sylwester Nawrocki
2020-09-01 10:11 ` Krzysztof Kozlowski
2020-09-01 14:50 ` Mark Brown
2020-09-03 16:45 ` Rob Herring
2020-09-03 16:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ec0795-2b7f-adde-4277-2238cede8c24@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=snawrocki@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).