archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <>
To: Sergey Shtylyov <>
	Greg Kroah-Hartman <>,
	Krzysztof Kozlowski <>,,
Subject: Re: [PATCH v2 4/9] usb: gadget: udc: s3c2410: add IRQ check
Date: Thu, 12 Aug 2021 08:40:03 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Sergey Shtylyov <> writes:

> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to request_irq() (which takes
> *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
> error code. Stop calling request_irq() with the invalid IRQ #s.
> Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources")
> Signed-off-by: Sergey Shtylyov <>

Acked-by: Felipe Balbi <>


      parent reply	other threads:[~2021-08-12  5:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2021-08-09 20:35 ` Sergey Shtylyov
2021-08-10  6:53   ` Krzysztof Kozlowski
2021-08-12  5:40   ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 4/9] usb: gadget: udc: s3c2410: add IRQ check' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).