From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: samsung: soc: match preferred naming in entire compatible
Date: Fri, 30 Sep 2022 09:07:58 +0200 [thread overview]
Message-ID: <9d65aa4f-3db9-c7e1-f41c-41db8877372e@linaro.org> (raw)
In-Reply-To: <20220929212845.GA2725627-robh@kernel.org>
On 29/09/2022 23:28, Rob Herring wrote:
> On Mon, Sep 26, 2022 at 02:47:57PM +0200, Krzysztof Kozlowski wrote:
>> Compatible is a string-array, therefore the "select" should look for
>> anything containing Samsung SoC part. This allows to validate cases
>> like:
>> - "samsung,exynos5250-gsc", "samsung,exynos5-gsc"
>> - "samsung,exynos5250-pmu", "syscon"
>> - "tesla,fsd-mct", "samsung,exynos4210-mct"
>>
>> Since Tesla FSD builts on top of Exynos blocks, add an adidtional
>> pattern for it.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/arm/samsung/samsung-soc.yaml | 26 +++++++++++++++----
>> 1 file changed, 21 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
>> index 653f85997643..bb1fdc205b44 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
>> @@ -18,17 +18,33 @@ description: |
>> samsung,exynos5433-cmu-isp
>>
>> select:
>> - properties:
>> - compatible:
>> - pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$"
>> + allOf:
>> + - properties:
>> + $nodename:
>> + pattern: '^[a-z]'
>
> Why do you need this?
Because otherwise I am matching top-level board compatible, which
obviously do not fall into my patterns.
>
>> + - properties:
>> + compatible:
>> + contains:
>> + pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$"
>> required:
>> - compatible
>>
>> properties:
>> compatible:
>> oneOf:
>> - - description: Preferred naming style for compatibles of SoC components
>> - pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"
>> + - description: Preferred naming style for compatibles of S3C/S5P/Exynos SoC components
>> + minItems: 1
>> + items:
>> + - pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"
>> + - {}
>> + - {}
>
> Wouldn't just contains be fine here too:
>
> contains:
> pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"
Somehow it does not work like it should - nodes with wrong compatibles
pass. I tested with fake compatibles like:
samsung,cmu-exynos5433-cmu-top
samsung,exynos54xx-cmu-cpif
Best regards,
Krzysztof
prev parent reply other threads:[~2022-09-30 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:47 [PATCH] dt-bindings: samsung: soc: match preferred naming in entire compatible Krzysztof Kozlowski
2022-09-29 21:28 ` Rob Herring
2022-09-30 7:07 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d65aa4f-3db9-c7e1-f41c-41db8877372e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).