From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487BCC4320A for ; Mon, 9 Aug 2021 13:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E7DD61040 for ; Mon, 9 Aug 2021 13:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234509AbhHINJb (ORCPT ); Mon, 9 Aug 2021 09:09:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:51290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233999AbhHINJb (ORCPT ); Mon, 9 Aug 2021 09:09:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0177861019; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514551; bh=YzG7BnFCln4Yyp6LxrxvxeyUMj5GmzMjIhVfIPMKSYc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=B8pvYpwPzQ18zhH2+y0BGlUA/OJhSA/B0e0InC/nca080ep3tJvTyYkjw4iA0bIXy YJkfsyL7WJqFEvGlYZsDdfkS8W4gkzs2dxMYwyXUt2VpcSaAsgcNhIj8ai/6CAVUZ2 ldHAUzQEOhshkYgfdQv79fOgiKArwiLUzaIB6uXf33e9Dwx6fJNaNUWADrL3Q2AY27 Bl9LecINy6PsqQyvEgFzW02xNT9GIlS0Tp9TuaVC5l/yfox0JcJblrMOq9WQey5+Yx UjWS8SLAwRaq9m1jBvtg7XtqOaG9lvGylZ+m8LNCf4Md/cmndcHE0D+U5Qp6wYUHub B20Q3cXMUBSvw== Received: by mail-lf1-f51.google.com with SMTP id x8so33826708lfe.3; Mon, 09 Aug 2021 06:09:10 -0700 (PDT) X-Gm-Message-State: AOAM5316n5Q6fSgE4xpMZGJ3ifgWZBV90+3ZkWDC4HNdFLIzSkZxLY6c yFo8QwUpkzJExX7zXdxj5aVPLXZNs5UtfjZ3RQ== X-Google-Smtp-Source: ABdhPJzottn9lR1w4Ou5tspJmaMhExuHvfqLuRluAKs7dQZoer2iHn4k6bWFWu6HusN3FgH38v3t3o0558IoBlRW8NU= X-Received: by 2002:a17:906:4156:: with SMTP id l22mr6919385ejk.75.1628514539014; Mon, 09 Aug 2021 06:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210625082222.3845-1-tzimmermann@suse.de> <20210625082222.3845-14-tzimmermann@suse.de> In-Reply-To: <20210625082222.3845-14-tzimmermann@suse.de> From: Chun-Kuang Hu Date: Mon, 9 Aug 2021 21:08:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled To: Thomas Zimmermann Cc: Daniel Vetter , David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xinhui.Pan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com, brian.starkey@arm.com, Maarten Lankhorst , Maxime Ripard , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org, tiantao6@hisilicon.com, john.stultz@linaro.org, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Chun-Kuang Hu , Matthias Brugger , Ben Skeggs , Tomi Valkeinen , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , jonathanh@nvidia.com, Jyri Sarha , emma@anholt.net, linux-graphics-maintainer@vmware.com, zackr@vmware.com, hyun.kwon@xilinx.com, Laurent Pinchart , michal.simek@xilinx.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, Russell King , kieran.bingham+renesas@ideasonboard.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , amd-gfx@lists.freedesktop.org, DRI Development , Linux ARM , linux-samsung-soc@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Intel Graphics Development , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi, Thomas: Thomas Zimmermann =E6=96=BC 2021=E5=B9=B46=E6=9C=8825= =E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:22=E5=AF=AB=E9=81=93=EF=BC= =9A > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med= iatek/mtk_drm_drv.c > index b46bdb8985da..9b60bec33d3b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm) > goto err_component_unbind; > } > > - /* > - * We don't use the drm_irq_install() helpers provided by the DRM > - * core, so we need to set this manually in order to allow the > - * DRM_IOCTL_WAIT_VBLANK to operate correctly. > - */ > - drm->irq_enabled =3D true; > ret =3D drm_vblank_init(drm, MAX_CRTC); > if (ret < 0) > goto err_component_unbind; > -- > 2.32.0 >